From patchwork Fri Dec 13 05:46:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 2022631 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=mYorVxIB; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Zcp6MC4b; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Y8ddM1kH3z1yRC for ; Fri, 13 Dec 2024 16:47:03 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OgrfRcQ5D7A6ERgXNvs+eXnZOj83NHCoL0Ihmlfk+yE=; b=mYorVxIBU6aa9U soSo2cX1/PP2ymPnUyBU1kKGmvPT/1gdvXbXk8tiKGmaY6d9Oc651xuIiB0BVbjhRPf5qq2F6ED4b SfQQbEiQRqpPPAe6MfIU/qs2Scq+vWEgFTUelBKg/4wwhlAghx2ly19WlpbJBj6VPdBdBBVITH7C7 JoMkGpacAmaVxjglMLxfLaJaO3e1MwStczQwihRvAnMoh2fRRnXic4SdPBujRMimph7E0roANSKrh rF0pcaHSym+z0cJQS4wQyIrHKGSOsw9/tHR1hiuUjXUoxRvpRBZXXIDs5S/lgSIzlJpFUg/rxrTzp YQXE8nyGSGojbwvf9+Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tLyVy-00000002nZn-1HlN; Fri, 13 Dec 2024 05:47:02 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tLyVw-00000002nYX-1jps for linux-snps-arc@lists.infradead.org; Fri, 13 Dec 2024 05:47:01 +0000 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-21644aca3a0so16639045ad.3 for ; Thu, 12 Dec 2024 21:47:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734068819; x=1734673619; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fVaAhWgLsrOIaawWt+Es3lyBYssP2HU9Cngct4cKfGw=; b=Zcp6MC4bCcz3ZhK1T7rFNvfT6BzcJD4MeaMFZO9ROpotAV/SjOiB8+vlW5kLrbDieV uJ76yGJaWVqqLlL44lZi6LyuRxGmcyh5KGirXm/jFf93/1d7vbgnchOIxKs+npPJpKMp n6XfiiBFZcd/Y1lrDP7tx+zJCqwaa9/4OQGWWGfn8OxBIdFe+O+/CVZ27bOwd/nJGfOa GA8HdxFN3lpPTvivFRjG8wCBgh3K9QNRJsi4STiqgbPv8NjMevzhJ5kCCBCgm/zDjFEy 2/zfZ2jXs3Kpz9GtqGvY3laRxy4JdV2PwmL0jZA7hhSpEKrTR1IsG6vy1gV8zgtOGeNP RMJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734068819; x=1734673619; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fVaAhWgLsrOIaawWt+Es3lyBYssP2HU9Cngct4cKfGw=; b=W94J4bvqcI6Q4rcOpoSsZAV8GowZz2CqRwbuFMGsTWl+YltArk+nc2f51dsuCDjU7x P4UYlaRIdA3tegKokxLCNNrVpqpQz5urjI2fBulaR2mVbmlWV4jBAsZGOOR0MnjlNfJK ocCYIzLKYtNN0q0ouVECd5GMxIl2EEwxajRi99g+fVZHdTBSKR0aQfhw+mCAFFOLwyfz WSQFJw/n0aJsmHrJ9gHZDWnOR+gYvGrDEjpVundUXt8slPEIdTO+FeMALmP3FcBmJbRs dfs/mla7rvpOFS7D9YdWhIeE1URJYBGT4PCkp2WXpqnLtwZcLLl3JL1+Y2ZgdLxXO82+ ia6g== X-Forwarded-Encrypted: i=1; AJvYcCUoJiQ8qskLHFTiisECZ+mjjAtaXtDZj4XRn5YMuJjb4DtL77W8YSpeJRD9UGJRELMRd6/KJHHCcQQzEcUASw==@lists.infradead.org X-Gm-Message-State: AOJu0Ywz3yV4PxQ8p3uuefmjukCETqUBp+5zq4r+ltgRW3jVJMDi4EAY RPO16ctfDKrz5RH5OdbwbTm3AATkFZGv5oBVqD7HKDntXdiwlhCE X-Gm-Gg: ASbGncu6Zn4ajKmQrAe5etnSQMU60a+2oNE0MuidZnq9UxXr0XIV6h3os84oppsUAJF tqll7fuM/g6JCgoGahU5oyIFu4dsoRmHirGPToigF3lbq2t9+24sHPmUedy3yxsSnxWC7io0IfW YEiArjsMxQzjuFYiX3F1Sov1LUm6xBYjbsFsgDAN3H8kRcIC4hBO/KUgtEALEQMRdGTymX45Wup YYlzQX3NzR3Fv4w8S18c9Y0YaPfj1QS4ESZE8M1JxuY0SIiF6fOFD3K+DydaMBPcKML7JDa3i+z huGrMw0= X-Google-Smtp-Source: AGHT+IGnQMpyX4qO4c9TaUxIvkW9bvqpb4HtTDVE3C9gZFkXCVV6ksZB8lAWhFJzpiBj11HO1t8PNw== X-Received: by 2002:a17:902:e88b:b0:212:615f:c1 with SMTP id d9443c01a7336-218929a19c2mr20599995ad.14.1734068819460; Thu, 12 Dec 2024 21:46:59 -0800 (PST) Received: from localhost.localdomain ([180.159.118.224]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-216483dd292sm82564985ad.226.2024.12.12.21.46.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 12 Dec 2024 21:46:58 -0800 (PST) From: Yafang Shao To: torvalds@linux-foundation.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org, linux-snps-arc@lists.infradead.org, linux-wireless@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, ocfs2-devel@lists.linux.dev, Yafang Shao , Serge Hallyn , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?utf-8?q?Andr=C3=A9_Almeida?= Subject: [PATCH 2/7] kernel: Replace get_task_comm() with %pTN Date: Fri, 13 Dec 2024 13:46:05 +0800 Message-Id: <20241213054610.55843-3-laoar.shao@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) In-Reply-To: <20241213054610.55843-1-laoar.shao@gmail.com> References: <20241213054610.55843-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241212_214700_449930_FD275481 X-CRM114-Status: GOOD ( 12.64 ) X-Spam-Score: -2.1 (--) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__Since_task-=3Ecomm_is_guaranteed_to_be?= =?unknown-8bit?q?_NUL-terminated=2C_we_can?= =?unknown-8bit?q?_print_it_directly_without_the_need_to_copye_it_into_a_sepa?= =?unknown-8bit?q?rate_buffer=2E_This?= =?unknown-8bit?q?_simplifies_the_code_and_avoids_unnecessary_operations=2E_S?= =?unknown-8bit?q?igned-off-by=3A_Yafang?= =?unknown-8bit?q?_Shao_Cc=3A_Serge_Hallyn_Cc=3A_Thomas_Gleixner_Cc=3A_Ingo_M?= =?unknown-8bit?q?olnar_Cc=3A_Peter_Zijlstra?= =?unknown-8bit?q?_Cc=3A_Darren_Hart_Cc=3A_Davidlohr_Bueso_Cc=3A_=22Andr=C3?= =?unknown-8bit?q?=A9_Almeida=22_---_kernel/capability=2Ec?= =?unknown-8bit?b?IHwgMTIgWy4uLl0g?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=28-2=2E1_points=2C_5=2E0_re?= =?unknown-8bit?q?quired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyNjA3OmY4YjA6NDg2NDoyMDowOjA6MDo2MmYgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from_author=27s?= =?unknown-8bit?q?_domain?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from?= =?unknown-8bit?q?_envelope-from_domain?= =?unknown-8bit?q?_-1=2E9_BAYES=5F00_______________BODY=3A_Bayes_spam_probabi?= =?unknown-8bit?q?lity_is_0_to_1=25?= =?unknown-8bit?q?_=5Bscore=3A_0=2E0000=5D?= =?unknown-8bit?q?_0=2E0_FREEMAIL=5FFROM__________Sender_email_is_commonly_ab?= =?unknown-8bit?q?used_enduser_mail_provider?= =?unknown-8bit?b?IFtsYW9hci5zaGFvKGF0KWdtYWlsLmNvbV0=?= X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since task->comm is guaranteed to be NUL-terminated, we can print it directly without the need to copye it into a separate buffer. This simplifies the code and avoids unnecessary operations. Signed-off-by: Yafang Shao Cc: Serge Hallyn Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Darren Hart Cc: Davidlohr Bueso Cc: "André Almeida" --- kernel/capability.c | 12 ++++-------- kernel/futex/waitwake.c | 5 ++--- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/kernel/capability.c b/kernel/capability.c index dac4df77e376..4512cd797f49 100644 --- a/kernel/capability.c +++ b/kernel/capability.c @@ -38,10 +38,8 @@ __setup("no_file_caps", file_caps_disable); static void warn_legacy_capability_use(void) { - char name[sizeof(current->comm)]; - - pr_info_once("warning: `%s' uses 32-bit capabilities (legacy support in use)\n", - get_task_comm(name, current)); + pr_info_once("warning: `%pTN' uses 32-bit capabilities (legacy support in use)\n", + current); } /* @@ -62,10 +60,8 @@ static void warn_legacy_capability_use(void) static void warn_deprecated_v2(void) { - char name[sizeof(current->comm)]; - - pr_info_once("warning: `%s' uses deprecated v2 capabilities in a way that may be insecure\n", - get_task_comm(name, current)); + pr_info_once("warning: `%pTN' uses deprecated v2 capabilities in a way that may be insecure\n", + current); } /* diff --git a/kernel/futex/waitwake.c b/kernel/futex/waitwake.c index 3a10375d9521..df8f8c85d776 100644 --- a/kernel/futex/waitwake.c +++ b/kernel/futex/waitwake.c @@ -210,13 +210,12 @@ static int futex_atomic_op_inuser(unsigned int encoded_op, u32 __user *uaddr) if (encoded_op & (FUTEX_OP_OPARG_SHIFT << 28)) { if (oparg < 0 || oparg > 31) { - char comm[sizeof(current->comm)]; /* * kill this print and return -EINVAL when userspace * is sane again */ - pr_info_ratelimited("futex_wake_op: %s tries to shift op by %d; fix this program\n", - get_task_comm(comm, current), oparg); + pr_info_ratelimited("futex_wake_op: %pTN tries to shift op by %d; fix this program\n", + current, oparg); oparg &= 31; } oparg = 1 << oparg;