From patchwork Thu Sep 14 18:37:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Ogness X-Patchwork-Id: 1834396 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=29cs3iSW; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=Z8UeMKj4; dkim=fail reason="signature verification failed" header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=6i/Rykkl; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RmmLm4cMFz1yhd for ; Fri, 15 Sep 2023 04:39:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=S0CAOlgKUZ12YZ4I8IgXOO3qbgpxhmWcwDi7BZ+ViYY=; b=29cs3iSWPSv/Xv l/1N4IkMW+fCGsOfJ4hgDw0Wh00z8ePLsUOZxQxIf+wIxhUaFEIogvKlBpqiVcW4kFdofs5h+nsbc vVZ0XNoQcrNB59IWjlkmHcqpeA0MjzEQP6Z6Z2UMk4FW8B5pxCLch+ZglxHtWvsTtnC7rdr9HMg5r fZ82PJHoGVgrcbBqaZUu+9MBr/na+Dc8bMXCdkPmTHvfHjyMxlRN14EzBYmw6JWMon6kTkms/oQ2g Snw0m22nkGPlN+2bUbGbVkByTsjlp19V0ZT5rdz+LuTPWXV4Kf80iMNphVq+MPlU35MgoYg8ZavNy E6r2v7tzPGzBKUy2ntOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgrF9-0094yC-0v; Thu, 14 Sep 2023 18:39:11 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgrEt-0094k0-0v; Thu, 14 Sep 2023 18:38:58 +0000 From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1694716719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=aQcu0Tj+ffJBWZVQ9fNZPj8/IhtyreTS7DJJKIPF900=; b=Z8UeMKj4Fav9MLhk6d+JmpTi5nJHEpVJNO1ur5Ad3vBiVWCnoe9Eog0Qg33XlH6id3FWbz S8l2Lt2jSbU2XHwf8xi9UIitF4+b8K7paGx1bjjYr5t2rdTDVV0Fim6UAKFi2CtuZ1mb3L E0TJN4HYA+tWtKTLOiVDx3F+jVsGlfsYYAnFZvFt3iKUUrP7SkGJJcZ1UIkJ/UqIQ0831V SMEuLB8ZIcl+FG04i7hT9/QWq5F02SyOTdFIc9j7ps1+LHHwMSHMPuADoGutw3ZHkUAICp RXxdloN+Gh4cSEl07/GwEgsU+m8aqlGccQ2NbBYv7A5wSEzPoJaqC36jkiHDjg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1694716719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=aQcu0Tj+ffJBWZVQ9fNZPj8/IhtyreTS7DJJKIPF900=; b=6i/Rykkl4Rl5SBtIHP9RIQNQNOB8Crkkj2AcFISLN8Dmxq51odZMyUMI6Usmo7xHPgkuGu 8OGeRMSrDoYZsqCg== To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-serial@vger.kernel.org, Petr Mladek , Thomas Gleixner , linux-kernel@vger.kernel.org, Tobias Klauser , Thierry Reding , Joel Stanley , Andrew Jeffery , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, Al Cooper , Broadcom internal kernel review list , Tony Lindgren , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4?= =?utf-8?q?rvinen?= , Florian Fainelli , Andrew Davis , Matthew Howell , =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= , Johan Hovold , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , linux-mediatek@lists.infradead.org, Lukas Wunner , Matthias Schiffer , Arnd Bergmann , Kumaravel Thiagarajan , Tharun Kumar P , Russell King , "Maciej W. Rozycki" , Hongyu Xie , Jiamei Xie , Rob Herring , delisun , Lino Sanfilippo , Yangtao Li , Vineet Gupta , linux-snps-arc@lists.infradead.org, Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Arend van Spriel , Christophe Leroy , Baruch Siach , Sherry Sun , Shenwei Wang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sergey Organov , Tom Rix , Marek Vasut , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Vladimir Zapolskiy , Jacky Huang , Shan-Chun Hung , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Dmitry Rokosov , Lucas Tanure , linux-amlogic@lists.infradead.org, Taichi Sugaya , Takao Orito , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, =?utf-8?q?Pali_Roh=C3=A1r?= , Andrew Morton , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , linux-actions@lists.infradead.org, Xiongfeng Wang , Yuan Can , Michael Ellerman , Nicholas Piggin , linuxppc-dev@lists.ozlabs.org, linux-unisoc@lists.infradead.org, Kevin Cernekee , Krzysztof Kozlowski , Alim Akhtar , linux-samsung-soc@vger.kernel.org, Lukas Bulwahn , Lech Perczak , Hugo Villeneuve , Andy Shevchenko , Isaac True , Laxman Dewangan , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org, Biju Das , Geert Uytterhoeven , Palmer Dabbelt , Paul Walmsley , Nick Hu , Ruan Jinjie , Samuel Holland , linux-riscv@lists.infradead.org, Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Valentin Caron , Sebastian Andrzej Siewior , linux-stm32@st-md-mailman.stormreply.com, "David S. Miller" , sparclinux@vger.kernel.org, Hammer Hsieh , Peter Korsgaard , Timur Tabi , Mukesh Ojha , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , Michal Simek Subject: [PATCH tty v1 00/74] serial: wrappers for uart port lock Date: Thu, 14 Sep 2023 20:43:17 +0206 Message-Id: <20230914183831.587273-1-john.ogness@linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_113855_627177_99EEF4C5 X-CRM114-Status: GOOD ( 15.88 ) X-Spam-Score: -1.9 (-) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: When a serial port is used for kernel console output, then all modifications to the UART registers which are done from other contexts, e.g. getty, termios, are interference points for the kernel conso [...] Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2a0a:51c0:0:12e:550:0:0:1 listed in] [list.dnswl.org] 0.6 INVALID_DATE_TZ_ABSURD Invalid Date: header (timezone does not exist) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org When a serial port is used for kernel console output, then all modifications to the UART registers which are done from other contexts, e.g. getty, termios, are interference points for the kernel console. So far this has been ignored and the printk output is based on the principle of hope. The rework of the console infrastructure which aims to support threaded and atomic consoles, requires to mark sections which modify the UART registers as unsafe. This allows the atomic write function to make informed decisions and eventually to restore operational state. It also allows to prevent the regular UART code from modifying UART registers while printk output is in progress. All modifications of UART registers are guarded by the UART port lock, which provides an obvious synchronization point with the console infrastructure. Provide and use wrapper functions for spin_[un]lock*(port->lock) invocations so that the console mechanics can be applied later on at a single place and does not require to copy the same logic all over the drivers. Patch 1 adds the wrapper functions. Patches 2-74 switch all uart port locking call sites to use the new wrappers. These patches were automatically generated using coccinelle. The 2 used coccinelle scripts are included below and executed as follows: $ spatch --sp-file uartlock-1.cocci $FILE $ spatch --sp-file uartlock-2.cocci --recursive-includes $FILE This series brings no functional change. Patches 2-74 contain identical commit message bodies. Feel free to fold them into a single commit if that seems more reasonable. Thomas Gleixner (74): serial: core: Provide port lock wrappers serial: core: Use lock wrappers serial: 21285: Use port lock wrappers serial: 8250_aspeed_vuart: Use port lock wrappers serial: 8250_bcm7271: Use port lock wrappers serial: 8250: Use port lock wrappers serial: 8250_dma: Use port lock wrappers serial: 8250_dw: Use port lock wrappers serial: 8250_exar: Use port lock wrappers serial: 8250_fsl: Use port lock wrappers serial: 8250_mtk: Use port lock wrappers serial: 8250_omap: Use port lock wrappers serial: 8250_pci1xxxx: Use port lock wrappers serial: altera_jtaguart: Use port lock wrappers serial: altera_uart: Use port lock wrappers serial: amba-pl010: Use port lock wrappers serial: amba-pl011: Use port lock wrappers serial: apb: Use port lock wrappers serial: ar933x: Use port lock wrappers serial: arc_uart: Use port lock wrappers serial: atmel: Use port lock wrappers serial: bcm63xx-uart: Use port lock wrappers serial: cpm_uart: Use port lock wrappers serial: digicolor: Use port lock wrappers serial: dz: Use port lock wrappers serial: linflexuart: Use port lock wrappers serial: fsl_lpuart: Use port lock wrappers serial: icom: Use port lock wrappers serial: imx: Use port lock wrappers serial: ip22zilog: Use port lock wrappers serial: jsm: Use port lock wrappers serial: liteuart: Use port lock wrappers serial: lpc32xx_hs: Use port lock wrappers serial: ma35d1: Use port lock wrappers serial: mcf: Use port lock wrappers serial: men_z135_uart: Use port lock wrappers serial: meson: Use port lock wrappers serial: milbeaut_usio: Use port lock wrappers serial: mpc52xx: Use port lock wrappers serial: mps2-uart: Use port lock wrappers serial: msm: Use port lock wrappers serial: mvebu-uart: Use port lock wrappers serial: omap: Use port lock wrappers serial: owl: Use port lock wrappers serial: pch: Use port lock wrappers serial: pic32: Use port lock wrappers serial: pmac_zilog: Use port lock wrappers serial: pxa: Use port lock wrappers serial: qcom-geni: Use port lock wrappers serial: rda: Use port lock wrappers serial: rp2: Use port lock wrappers serial: sa1100: Use port lock wrappers serial: samsung_tty: Use port lock wrappers serial: sb1250-duart: Use port lock wrappers serial: sc16is7xx: Use port lock wrappers serial: tegra: Use port lock wrappers serial: core: Use port lock wrappers serial: mctrl_gpio: Use port lock wrappers serial: txx9: Use port lock wrappers serial: sh-sci: Use port lock wrappers serial: sifive: Use port lock wrappers serial: sprd: Use port lock wrappers serial: st-asc: Use port lock wrappers serial: stm32: Use port lock wrappers serial: sunhv: Use port lock wrappers serial: sunplus-uart: Use port lock wrappers serial: sunsab: Use port lock wrappers serial: sunsu: Use port lock wrappers serial: sunzilog: Use port lock wrappers serial: timbuart: Use port lock wrappers serial: uartlite: Use port lock wrappers serial: ucc_uart: Use port lock wrappers serial: vt8500: Use port lock wrappers serial: xilinx_uartps: Use port lock wrappers drivers/tty/serial/21285.c | 8 +- drivers/tty/serial/8250/8250_aspeed_vuart.c | 6 +- drivers/tty/serial/8250/8250_bcm7271.c | 28 +++--- drivers/tty/serial/8250/8250_core.c | 12 +-- drivers/tty/serial/8250/8250_dma.c | 8 +- drivers/tty/serial/8250/8250_dw.c | 8 +- drivers/tty/serial/8250/8250_exar.c | 4 +- drivers/tty/serial/8250/8250_fsl.c | 6 +- drivers/tty/serial/8250/8250_mtk.c | 8 +- drivers/tty/serial/8250/8250_omap.c | 52 +++++----- drivers/tty/serial/8250/8250_pci1xxxx.c | 8 +- drivers/tty/serial/8250/8250_port.c | 100 ++++++++++---------- drivers/tty/serial/altera_jtaguart.c | 28 +++--- drivers/tty/serial/altera_uart.c | 20 ++-- drivers/tty/serial/amba-pl010.c | 20 ++-- drivers/tty/serial/amba-pl011.c | 72 +++++++------- drivers/tty/serial/apbuart.c | 8 +- drivers/tty/serial/ar933x_uart.c | 26 ++--- drivers/tty/serial/arc_uart.c | 16 ++-- drivers/tty/serial/atmel_serial.c | 24 ++--- drivers/tty/serial/bcm63xx_uart.c | 22 ++--- drivers/tty/serial/cpm_uart.c | 8 +- drivers/tty/serial/digicolor-usart.c | 18 ++-- drivers/tty/serial/dz.c | 32 +++---- drivers/tty/serial/fsl_linflexuart.c | 26 ++--- drivers/tty/serial/fsl_lpuart.c | 88 ++++++++--------- drivers/tty/serial/icom.c | 26 ++--- drivers/tty/serial/imx.c | 84 ++++++++-------- drivers/tty/serial/ip22zilog.c | 36 +++---- drivers/tty/serial/jsm/jsm_neo.c | 4 +- drivers/tty/serial/jsm/jsm_tty.c | 16 ++-- drivers/tty/serial/liteuart.c | 20 ++-- drivers/tty/serial/lpc32xx_hs.c | 26 ++--- drivers/tty/serial/ma35d1_serial.c | 22 ++--- drivers/tty/serial/mcf.c | 20 ++-- drivers/tty/serial/men_z135_uart.c | 8 +- drivers/tty/serial/meson_uart.c | 30 +++--- drivers/tty/serial/milbeaut_usio.c | 16 ++-- drivers/tty/serial/mpc52xx_uart.c | 12 +-- drivers/tty/serial/mps2-uart.c | 16 ++-- drivers/tty/serial/msm_serial.c | 38 ++++---- drivers/tty/serial/mvebu-uart.c | 18 ++-- drivers/tty/serial/omap-serial.c | 38 ++++---- drivers/tty/serial/owl-uart.c | 26 ++--- drivers/tty/serial/pch_uart.c | 10 +- drivers/tty/serial/pic32_uart.c | 20 ++-- drivers/tty/serial/pmac_zilog.c | 52 +++++----- drivers/tty/serial/pxa.c | 30 +++--- drivers/tty/serial/qcom_geni_serial.c | 8 +- drivers/tty/serial/rda-uart.c | 34 +++---- drivers/tty/serial/rp2.c | 20 ++-- drivers/tty/serial/sa1100.c | 20 ++-- drivers/tty/serial/samsung_tty.c | 50 +++++----- drivers/tty/serial/sb1250-duart.c | 12 +-- drivers/tty/serial/sc16is7xx.c | 40 ++++---- drivers/tty/serial/serial-tegra.c | 32 +++---- drivers/tty/serial/serial_core.c | 88 ++++++++--------- drivers/tty/serial/serial_mctrl_gpio.c | 4 +- drivers/tty/serial/serial_port.c | 4 +- drivers/tty/serial/serial_txx9.c | 26 ++--- drivers/tty/serial/sh-sci.c | 68 ++++++------- drivers/tty/serial/sifive.c | 16 ++-- drivers/tty/serial/sprd_serial.c | 30 +++--- drivers/tty/serial/st-asc.c | 18 ++-- drivers/tty/serial/stm32-usart.c | 38 ++++---- drivers/tty/serial/sunhv.c | 28 +++--- drivers/tty/serial/sunplus-uart.c | 26 ++--- drivers/tty/serial/sunsab.c | 34 +++---- drivers/tty/serial/sunsu.c | 46 ++++----- drivers/tty/serial/sunzilog.c | 42 ++++---- drivers/tty/serial/timbuart.c | 8 +- drivers/tty/serial/uartlite.c | 18 ++-- drivers/tty/serial/ucc_uart.c | 4 +- drivers/tty/serial/vt8500_serial.c | 8 +- drivers/tty/serial/xilinx_uartps.c | 56 +++++------ include/linux/serial_core.h | 91 ++++++++++++++++-- 76 files changed, 1086 insertions(+), 1007 deletions(-) base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d Signed-off-by: John Ogness