| Message ID | 20220107210012.4091153-4-farosas@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | KVM: PPC: MMIO fixes | expand |
Excerpts from Fabiano Rosas's message of January 8, 2022 7:00 am: > If MMIO emulation fails we deliver a Program interrupt to the > guest. This is a normal event for the host, so use pr_info. > > Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com> > --- Should it be rate limited to prevent guest spamming host log? In the case of informational messages it's always good if it gives the administrator some idea of what to do with it. If it's normal for the host does it even need a message? If yes, then identifying which guest and adding something like "(this might becaused by a bug in guest driver)" would set the poor admin's mind at rest. Thanks, Nick > arch/powerpc/kvm/powerpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c > index 92e552ab5a77..4d7d0d080232 100644 > --- a/arch/powerpc/kvm/powerpc.c > +++ b/arch/powerpc/kvm/powerpc.c > @@ -308,7 +308,7 @@ int kvmppc_emulate_mmio(struct kvm_vcpu *vcpu) > > kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst); > /* XXX Deliver Program interrupt to guest. */ > - pr_emerg("%s: emulation failed (%08x)\n", __func__, last_inst); > + pr_info("%s: emulation failed (%08x)\n", __func__, last_inst); > r = RESUME_HOST; > break; > } > -- > 2.33.1 > >
Nicholas Piggin <npiggin@gmail.com> writes: > Excerpts from Fabiano Rosas's message of January 8, 2022 7:00 am: >> If MMIO emulation fails we deliver a Program interrupt to the >> guest. This is a normal event for the host, so use pr_info. >> >> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com> >> --- > > Should it be rate limited to prevent guest spamming host log? In the > case of informational messages it's always good if it gives the > administrator some idea of what to do with it. If it's normal > for the host does it even need a message? If yes, then identifying which > guest and adding something like "(this might becaused by a bug in guest > driver)" would set the poor admin's mind at rest. I'll drop this message then and improve the other one that is emitted earlier at the emulation code.
diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c index 92e552ab5a77..4d7d0d080232 100644 --- a/arch/powerpc/kvm/powerpc.c +++ b/arch/powerpc/kvm/powerpc.c @@ -308,7 +308,7 @@ int kvmppc_emulate_mmio(struct kvm_vcpu *vcpu) kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst); /* XXX Deliver Program interrupt to guest. */ - pr_emerg("%s: emulation failed (%08x)\n", __func__, last_inst); + pr_info("%s: emulation failed (%08x)\n", __func__, last_inst); r = RESUME_HOST; break; }
If MMIO emulation fails we deliver a Program interrupt to the guest. This is a normal event for the host, so use pr_info. Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com> --- arch/powerpc/kvm/powerpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)