Message ID | 20250111002921.167301-2-sridhar.samudrala@intel.com |
---|---|
State | Under Review |
Delegated to: | Anthony Nguyen |
Headers | show |
Series | [iwl-net] idpf: fix handling rsc packet with a single segment | expand |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Samudrala, Sridhar > Sent: Friday, January 10, 2025 4:29 PM > To: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org > Cc: Samudrala, Sridhar <sridhar.samudrala@intel.com>; Kitszel, Przemyslaw > <przemyslaw.kitszel@intel.com> > Subject: [Intel-wired-lan] [PATCH iwl-net] idpf: fix handling rsc packet with a > single segment > > Handle rsc packet with a single segment same as a multi segment rsc packet so > that CHECKSUM_PARTIAL is set in the > skb->ip_summed field. The current code is passing CHECKSUM_NONE > resulting in TCP GRO layer doing checksum in SW and hiding the issue. This will > fail when using dmabufs as payload buffers as skb frag would be unreadable. > > Fixes: 3a8845af66ed ("idpf: add RX splitq napi poll support") > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Tested-by: Samuel Salin <Samuel.salin@intel.com>
diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c index 2fa9c36e33c9..c9fcf8f4d736 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c @@ -3008,8 +3008,6 @@ static int idpf_rx_rsc(struct idpf_rx_queue *rxq, struct sk_buff *skb, return -EINVAL; rsc_segments = DIV_ROUND_UP(skb->data_len, rsc_seg_len); - if (unlikely(rsc_segments == 1)) - return 0; NAPI_GRO_CB(skb)->count = rsc_segments; skb_shinfo(skb)->gso_size = rsc_seg_len;