| Message ID | 20241212153417.165919-2-mschmidt@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ice: GNSS reading improvements | expand |
On Thu, Dec 12, 2024 at 04:34:15PM +0100, Michal Schmidt wrote: > gnss_insert_raw() will reject the GNSS data the ice driver produces > whenever userspace has the gnss device open, but is not reading it fast > enough for whatever reason. > > Do not spam kernel logs just because userspace misbehaves. > > Signed-off-by: Michal Schmidt <mschmidt@redhat.com> Reviewed-by: Simon Horman <horms@kernel.org>
On 12.12.2024 16:34 CET Michal Schmidt wrote: > gnss_insert_raw() will reject the GNSS data the ice driver produces > whenever userspace has the gnss device open, but is not reading it fast > enough for whatever reason. > > Do not spam kernel logs just because userspace misbehaves. > > Signed-off-by: Michal Schmidt <mschmidt@redhat.com> > --- > drivers/net/ethernet/intel/ice/ice_gnss.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Karol Kolacinski <karol.kolacinski@intel.com>
diff --git a/drivers/net/ethernet/intel/ice/ice_gnss.c b/drivers/net/ethernet/intel/ice/ice_gnss.c index 66390eeb2343..9b1f970f4825 100644 --- a/drivers/net/ethernet/intel/ice/ice_gnss.c +++ b/drivers/net/ethernet/intel/ice/ice_gnss.c @@ -146,9 +146,9 @@ static void ice_gnss_read(struct kthread_work *work) count = gnss_insert_raw(pf->gnss_dev, buf, i); if (count != i) - dev_warn(ice_pf_to_dev(pf), - "gnss_insert_raw ret=%d size=%d\n", - count, i); + dev_dbg(ice_pf_to_dev(pf), + "gnss_insert_raw ret=%d size=%d\n", + count, i); delay = ICE_GNSS_TIMER_DELAY_TIME; free_buf: free_page((unsigned long)buf);
gnss_insert_raw() will reject the GNSS data the ice driver produces whenever userspace has the gnss device open, but is not reading it fast enough for whatever reason. Do not spam kernel logs just because userspace misbehaves. Signed-off-by: Michal Schmidt <mschmidt@redhat.com> --- drivers/net/ethernet/intel/ice/ice_gnss.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)