| Message ID | 20241204132218.1060616-1-przemyslaw.korba@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Anthony Nguyen |
| Headers | show |
| Series | [iwl-net,v2] ice: fix incorrect PHY settings for 100 GB/s | expand |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Przemyslaw Korba > Sent: 04 December 2024 18:52 > To: intel-wired-lan@lists.osuosl.org > Cc: netdev@vger.kernel.org; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; richardcochran@gmail.com; andrew@lunn.ch; olteanv@gmail.com; Olech, Milena <milena.olech@intel.com>; pmenzel@molgen.mpg.de; Korba, Przemyslaw <przemyslaw.korba@intel.com> > Subject: [Intel-wired-lan] [PATCH iwl-net v2] ice: fix incorrect PHY settings for 100 GB/s > > ptp4l application reports too high offset when ran on E823 device with a 100GB/s link. Those values cannot go under 100ns, like in a working case when using 100 GB/s cable. > > This is due to incorrect frequency settings on the PHY clocks for > 100 GB/s speed. Changes are introduced to align with the internal hardware documentation, and correctly initialize frequency in PHY clocks with the frequency values that are in our HW spec. > > To reproduce the issue run ptp4l as a Time Receiver on E823 device, and observe the offset, which will never approach values seen in the PTP working case. > > Reproduction output: > ptp4l -i enp137s0f3 -m -2 -s -f /etc/ptp4l_8275.conf > ptp4l[5278.775]: master offset 12470 s2 freq +41288 path delay -3002 > ptp4l[5278.837]: master offset 10525 s2 freq +39202 path delay -3002 > ptp4l[5278.900]: master offset -24840 s2 freq -20130 path delay -3002 > ptp4l[5278.963]: master offset 10597 s2 freq +37908 path delay -3002 > ptp4l[5279.025]: master offset 8883 s2 freq +36031 path delay -3002 > ptp4l[5279.088]: master offset 7267 s2 freq +34151 path delay -3002 > ptp4l[5279.150]: master offset 5771 s2 freq +32316 path delay -3002 > ptp4l[5279.213]: master offset 4388 s2 freq +30526 path delay -3002 > ptp4l[5279.275]: master offset -30434 s2 freq -28485 path delay -3002 > ptp4l[5279.338]: master offset -28041 s2 freq -27412 path delay -3002 > ptp4l[5279.400]: master offset 7870 s2 freq +31118 path delay -3002 > > Fixes: 3a7496234d17 ("ice: implement basic E822 PTP support") > Reviewed-by: Milena Olech <milena.olech@intel.com> > Signed-off-by: Przemyslaw Korba <przemyslaw.korba@intel.com> > --- > Changelog: > v2: > change commit message > v1: > https://lore.kernel.org/intel-wired-lan/20241126102311.344972-1-przemyslaw.korba@intel.com/ > --- > drivers/net/ethernet/intel/ice/ice_ptp_consts.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_consts.h b/drivers/net/ethernet/intel/ice/ice_ptp_consts.h index 6620642077bb..bdb1020147d1 100644 --- a/drivers/net/ethernet/intel/ice/ice_ptp_consts.h +++ b/drivers/net/ethernet/intel/ice/ice_ptp_consts.h @@ -761,9 +761,9 @@ const struct ice_vernier_info_e82x e822_vernier[NUM_ICE_PTP_LNK_SPD] = { /* rx_desk_rsgb_par */ 644531250, /* 644.53125 MHz Reed Solomon gearbox */ /* tx_desk_rsgb_pcs */ - 644531250, /* 644.53125 MHz Reed Solomon gearbox */ + 390625000, /* 390.625 MHz Reed Solomon gearbox */ /* rx_desk_rsgb_pcs */ - 644531250, /* 644.53125 MHz Reed Solomon gearbox */ + 390625000, /* 390.625 MHz Reed Solomon gearbox */ /* tx_fixed_delay */ 1620, /* pmd_adj_divisor */
ptp4l application reports too high offset when ran on E823 device with a 100GB/s link. Those values cannot go under 100ns, like in a working case when using 100 GB/s cable. This is due to incorrect frequency settings on the PHY clocks for 100 GB/s speed. Changes are introduced to align with the internal hardware documentation, and correctly initialize frequency in PHY clocks with the frequency values that are in our HW spec. To reproduce the issue run ptp4l as a Time Receiver on E823 device, and observe the offset, which will never approach values seen in the PTP working case. Reproduction output: ptp4l -i enp137s0f3 -m -2 -s -f /etc/ptp4l_8275.conf ptp4l[5278.775]: master offset 12470 s2 freq +41288 path delay -3002 ptp4l[5278.837]: master offset 10525 s2 freq +39202 path delay -3002 ptp4l[5278.900]: master offset -24840 s2 freq -20130 path delay -3002 ptp4l[5278.963]: master offset 10597 s2 freq +37908 path delay -3002 ptp4l[5279.025]: master offset 8883 s2 freq +36031 path delay -3002 ptp4l[5279.088]: master offset 7267 s2 freq +34151 path delay -3002 ptp4l[5279.150]: master offset 5771 s2 freq +32316 path delay -3002 ptp4l[5279.213]: master offset 4388 s2 freq +30526 path delay -3002 ptp4l[5279.275]: master offset -30434 s2 freq -28485 path delay -3002 ptp4l[5279.338]: master offset -28041 s2 freq -27412 path delay -3002 ptp4l[5279.400]: master offset 7870 s2 freq +31118 path delay -3002 Fixes: 3a7496234d17 ("ice: implement basic E822 PTP support") Reviewed-by: Milena Olech <milena.olech@intel.com> Signed-off-by: Przemyslaw Korba <przemyslaw.korba@intel.com> --- Changelog: v2: change commit message v1: https://lore.kernel.org/intel-wired-lan/20241126102311.344972-1-przemyslaw.korba@intel.com/ --- drivers/net/ethernet/intel/ice/ice_ptp_consts.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 6ef5f61a4aa7d4df94a855a44f996bff08b0be83