Message ID | 20240905055530.26519-3-allen.ye@mediatek.com |
---|---|
State | New |
Headers | show
Return-Path: <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=46/ERi5W; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256 header.s=dk header.b=JSXlrtJg; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WzpXm4VWLz1yg7 for <incoming@patchwork.ozlabs.org>; Thu, 5 Sep 2024 15:57:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lZTeGqEpSt23alruziasajPWR1y6BhZ+pJPx+3oGKBM=; b=46/ERi5Ws/QFs2 Sp9+j2zqQpy3W6T564YxaWqQYQ1qf84ERe7AFw2T0ismkT+UlR+HcTCdHHEnCVOE3eZEnzEx+skur Wg4a7I3v6zNEENfcBR+3xKNCMTmt2KE1yDrBUmvvaJumofTQ7i7w0bupbgAkVKkiFFViu2BZNC17h kpKv7BJsq2c6a+3LUIGbuYf6aEKYtllS0gplsQjnBO/p1iKMNYtAZ9/GdUDr6mF0nHUFOLQywoumX PS4pZaoyUoIQet3+tQFl+MuCP9GkwSticgclZ0Kub1H4mFRoPAa6kbeaGo4p8+ZH7R9+8TcsB2Y5C ivH2ciN3pZ40AKvOQ9SA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm5UF-000000076VR-1YTm; Thu, 05 Sep 2024 05:56:55 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sm5U9-000000076SG-3wZx for hostap@lists.infradead.org; Thu, 05 Sep 2024 05:56:52 +0000 X-UUID: a1a4a18e6b4b11efb3adad29d29602c1-20240904 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=f5USsd144PVzpu7PjQZn6mnIDEdd6kNl5iDVeZ2A0so=; b=JSXlrtJgwgksr3laJwGe1g46WFywOJrgOPseOEXnVYyf5NYfiPToz9XqL07D3XtF2ZdGf4GTMyYdfDiJ3+xm6R3nKy5nYg+CVJelMCsOAAHX5MZVLvKwkCn77lqtu6PWakiQFp6QK1okuPfqk0kc6RwWueg8BJgJC5jJzjZHOpE=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.41,REQID:afea8e89-ad90-46f1-bd50-47ec986b8c90,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:2,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:2 X-CID-META: VersionHash:6dc6a47,CLOUDID:b8a27abf-d7af-4351-93aa-42531abf0c7b,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULN X-UUID: a1a4a18e6b4b11efb3adad29d29602c1-20240904 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw01.mediatek.com (envelope-from <allen.ye@mediatek.com>) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 721900750; Wed, 04 Sep 2024 22:56:45 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 5 Sep 2024 13:56:13 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 5 Sep 2024 13:56:13 +0800 From: Allen Ye <allen.ye@mediatek.com> To: Jouni Malinen <j@w1.fi> CC: <hostap@lists.infradead.org>, Felix Fietkau <nbd@nbd.name>, Evelyn Tsai <evelyn.tsai@mediatek.com>, "Money . Wang" <money.wang@mediatek.com>, "Allen Ye" <allen.ye@mediatek.com> Subject: [PATCH 3/3] hostapd: Fix wrong puncturing bitmap in bandwidth indication subelement Date: Thu, 5 Sep 2024 13:55:30 +0800 Message-ID: <20240905055530.26519-3-allen.ye@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20240905055530.26519-1-allen.ye@mediatek.com> References: <20240905055530.26519-1-allen.ye@mediatek.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--5.799700-8.000000 X-TMASE-MatchedRID: 24o13rjD2huMWJBKyAKo0bIGMNfiwa5NUK80YYUAl4sXdhT0BAdFzlO4 BD7nLMxnThbvLLI8RvN4LHI6F5wnnFxxDx5qbkR9FEUknJ/kEl5q8/xv2Um1avoLR4+zsDTtIAm DJ33CtzxAbPJ+MdBkmHWh3gm/noMeXxnJ7mrP1BrJ/tnugoGWveimkbXjmqIC X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.799700-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: E8E54B151D10A0A132B6A8A0733391216B1AD9316D974BE4FB57D77F3E045A662000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_225650_062826_36DC13F9 X-CRM114-Status: GOOD ( 10.22 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The bandwidth indication subelement should present the puncturing bitmap of channel switch request, but the bitmap returned by hostapd_get_punct_bitmap is the original one. Co-developed-by: Money Wang <money.wang@mediatek.com> Signed-off-by: Allen Ye <allen.ye@mediatek.com> --- src/ap/ieee802_11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [216.200.240.184 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [216.200.240.184 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [216.200.240.184 listed in sa-accredit.habeas.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <hostap.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/hostap>, <mailto:hostap-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/hostap/> List-Post: <mailto:hostap@lists.infradead.org> List-Help: <mailto:hostap-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/hostap>, <mailto:hostap-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Hostap" <hostap-bounces@lists.infradead.org> Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
hostapd: Fix length of bandwidth indication subelement
|
expand
|
diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c index aeac546ff..ce7fe5f48 100644 --- a/src/ap/ieee802_11.c +++ b/src/ap/ieee802_11.c @@ -7304,7 +7304,7 @@ static u8 * hostapd_eid_wb_channel_switch(struct hostapd_data *hapd, u8 *eid, static u8 * hostapd_eid_bw_indication(struct hostapd_data *hapd, u8 *eid, u8 chan1, u8 chan2) { - u16 punct_bitmap = hostapd_get_punct_bitmap(hapd); + u16 punct_bitmap = hapd->cs_freq_params.punct_bitmap; struct ieee80211_bw_ind_element *bw_ind_elem; size_t elen = 4;
The bandwidth indication subelement should present the puncturing bitmap of channel switch request, but the bitmap returned by hostapd_get_punct_bitmap is the original one. Co-developed-by: Money Wang <money.wang@mediatek.com> Signed-off-by: Allen Ye <allen.ye@mediatek.com> --- src/ap/ieee802_11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)