| Message ID | 20240807214801.2030506-1-jintaolin@chromium.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | p2p: consult driver capabilities before setting HE bit in GO's conf | expand |
On Wed, Aug 07, 2024 at 09:48:01PM +0000, Jintao Lin wrote: > p2p_go_he could be set to 1 in the global config file while the device > might only has a VHT WiFi nic. Consult driver capabilities before > setting the HE bit for the GO's conf so that latter AP configuration > does not fail due to wrong AP configuration, like > hostapd_get_oper_centr_freq_seg0_idx. This config bit is checked and set > in wpa_supplicant_conf_ap_ht. Thus there is no need to override this > bit specifically for GO. Thanks, applied.
diff --git a/wpa_supplicant/ap.c b/wpa_supplicant/ap.c index 69a0e5ee1..729277907 100644 --- a/wpa_supplicant/ap.c +++ b/wpa_supplicant/ap.c @@ -540,12 +540,6 @@ static int wpa_supplicant_conf_ap(struct wpa_supplicant *wpa_s, conf->supported_rates = list; } -#ifdef CONFIG_IEEE80211AX - if (ssid->mode == WPAS_MODE_P2P_GO || - ssid->mode == WPAS_MODE_P2P_GROUP_FORMATION) - conf->ieee80211ax = ssid->he; -#endif /* CONFIG_IEEE80211AX */ - bss->isolate = !wpa_s->conf->p2p_intra_bss; bss->extended_key_id = wpa_s->conf->extended_key_id; bss->force_per_enrollee_psk = wpa_s->global->p2p_per_sta_psk;
p2p_go_he could be set to 1 in the global config file while the device might only has a VHT WiFi nic. Consult driver capabilities before setting the HE bit for the GO's conf so that latter AP configuration does not fail due to wrong AP configuration, like hostapd_get_oper_centr_freq_seg0_idx. This config bit is checked and set in wpa_supplicant_conf_ap_ht. Thus there is no need to override this bit specifically for GO. Signed-off-by: Jintao Lin <jintaolin@chromium.org> --- wpa_supplicant/ap.c | 6 ------ 1 file changed, 6 deletions(-)