From patchwork Thu Sep 26 09:09:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Schwab X-Patchwork-Id: 1989720 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MlAijK1s; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=AM4ORzB9; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MlAijK1s; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=AM4ORzB9; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XDnqx4Xl7z1xt6 for ; Thu, 26 Sep 2024 19:10:21 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CDF243858432 for ; Thu, 26 Sep 2024 09:10:19 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 1C6553857022 for ; Thu, 26 Sep 2024 09:09:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C6553857022 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C6553857022 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727341800; cv=none; b=SSDmxbFxjytpIKo4pX9FFtjwidtdmjW4ldyp1xhXGQXLZeUd4RkXl8cmM4wPtBmH75qo3XGgg2wyFwc47zkj6uo7+H+2xP9HtQiZYm0ReK6xK0fUJSHf5vaeJkN1zkRTKLgJMre2GmOLC9PO3uMg9CmFi7rOORRraGSvusjxEtk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727341800; c=relaxed/simple; bh=coVE/uhXkiNC7mQUrTcL2vroo55ctXavYUGulgNY/Cc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=BqV+Hk5FvjChBOFM46zJmPSpKf9ltXDUoRPUkLbTqKqE81rSWONpVWNUfXTwUlEuH/OCsDxlf/I4nthIJWYvYpJhVSUeji/eJwsDb7qR4wZ+Ad6COHVCGJkjHalXveIWSw6TUTH31McDIVKBvmO7MJjcoB8h10joHFHYlg6/v68= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from hawking.nue2.suse.org (unknown [IPv6:2a07:de40:a101:3:92b1:1cff:fe69:ddc]) by smtp-out1.suse.de (Postfix) with ESMTP id 094BF21A22 for ; Thu, 26 Sep 2024 09:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727341798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=rF5WjMro6tPucOqPQWmg+QsMNdNG4V3X/0YZfHx+Q70=; b=MlAijK1s01MshDChVJgh2bPH4Mchhn0XunUnGYVuAqlqOViSyBWFpDXWvF71qoLP3JcrNa ZHLeMaGj2B1XDcZ00+LWu8iLUXC3WlAQ0dPNG6xCB8XyfyVwahZqJ2DWwjzoWl/wb+/dQi Ebqhh1RqDSIonPo0ODhSTEG+2c05MJI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727341798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=rF5WjMro6tPucOqPQWmg+QsMNdNG4V3X/0YZfHx+Q70=; b=AM4ORzB9Dx3kQFvDKHTGyFn6QFJAEPEbSzflyBOdL4xo8utHjjsvN8juB1D11Y92qryYXp AYzcK6jG/wpBSCBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MlAijK1s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=AM4ORzB9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727341798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=rF5WjMro6tPucOqPQWmg+QsMNdNG4V3X/0YZfHx+Q70=; b=MlAijK1s01MshDChVJgh2bPH4Mchhn0XunUnGYVuAqlqOViSyBWFpDXWvF71qoLP3JcrNa ZHLeMaGj2B1XDcZ00+LWu8iLUXC3WlAQ0dPNG6xCB8XyfyVwahZqJ2DWwjzoWl/wb+/dQi Ebqhh1RqDSIonPo0ODhSTEG+2c05MJI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727341798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=rF5WjMro6tPucOqPQWmg+QsMNdNG4V3X/0YZfHx+Q70=; b=AM4ORzB9Dx3kQFvDKHTGyFn6QFJAEPEbSzflyBOdL4xo8utHjjsvN8juB1D11Y92qryYXp AYzcK6jG/wpBSCBg== Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id E631D4A03E4; Thu, 26 Sep 2024 11:09:57 +0200 (CEST) From: Andreas Schwab To: libc-alpha@sourceware.org Subject: [PATCH] Fix missing randomness in __gen_tempname (bug 32214) X-Yow: Why was I BORN? Date: Thu, 26 Sep 2024 11:09:57 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Spamd-Result: default: False [15.28 / 50.00]; SPAM_FLAG(5.00)[]; NEURAL_SPAM_LONG(3.50)[1.000]; BAYES_HAM(-3.00)[99.99%]; NEURAL_SPAM_SHORT(2.99)[0.997]; HFILTER_HOSTNAME_UNKNOWN(2.50)[]; RDNS_NONE(2.00)[]; ONCE_RECEIVED(1.20)[]; HFILTER_HELO_IP_A(1.00)[hawking.nue2.suse.org]; HFILTER_HELO_NORES_A_OR_MX(0.30)[hawking.nue2.suse.org]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; DIRECT_TO_MX(0.00)[Gnus/5.13 (Gnus v5.13)]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email] X-Spam-Score: 15.28 X-Rspamd-Queue-Id: 094BF21A22 X-Rspamd-Action: add header X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Bar: +++++++++++++++ X-Spam: Yes X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org Make sure to update the random value also if getrandom fails. Fixes: 686d542025 ("posix: Sync tempname with gnulib") --- sysdeps/posix/tempname.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sysdeps/posix/tempname.c b/sysdeps/posix/tempname.c index c00fe0c181..fc30958a0c 100644 --- a/sysdeps/posix/tempname.c +++ b/sysdeps/posix/tempname.c @@ -117,6 +117,8 @@ random_bits (random_value *r, random_value s) succeed. */ #if !_LIBC *r = mix_random_values (v, clock ()); +#else + *r = v; #endif return false; }