diff mbox series

malloc: cleanup casts in tst-calloc

Message ID a8e97df74ee86759fe071035959db427d789c3f1.1737777707.git.sam@gentoo.org
State New
Headers show
Series malloc: cleanup casts in tst-calloc | expand

Commit Message

Sam James Jan. 25, 2025, 4:01 a.m. UTC 
Followup to c3d1dac96bdd10250aa37bb367d5ef8334a093a1. As pointed out by
Maciej W. Rozycki, the casts are obviously useless now.
---

 malloc/tst-calloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 8ab34497de14e35aff09b607222fe1309ef156da

Comments

H.J. Lu Jan. 25, 2025, 4:07 a.m. UTC | #1 
On Sat, Jan 25, 2025 at 12:02 PM Sam James <sam@gentoo.org> wrote:
>
> Followup to c3d1dac96bdd10250aa37bb367d5ef8334a093a1. As pointed out by
> Maciej W. Rozycki, the casts are obviously useless now.
> ---
>
>  malloc/tst-calloc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/malloc/tst-calloc.c b/malloc/tst-calloc.c
> index 122b2cbeaf..e0c1a06603 100644
> --- a/malloc/tst-calloc.c
> +++ b/malloc/tst-calloc.c
> @@ -106,8 +106,8 @@ null_test (void)
>    calloc (0, 0);
>    calloc (0, max_size);
>    calloc (max_size, 0);
> -  calloc (0, ~((size_t) zero_size));
> -  calloc (~((size_t) zero_size), 0);
> +  calloc (0, ~zero_size);
> +  calloc (~zero_size, 0);
>    DIAG_POP_NEEDS_COMMENT;
>  }
>
>
> base-commit: 8ab34497de14e35aff09b607222fe1309ef156da
> --
> 2.48.1
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.
Sam James Jan. 25, 2025, 5:36 a.m. UTC | #2 
"H.J. Lu" <hjl.tools@gmail.com> writes:

> On Sat, Jan 25, 2025 at 12:02 PM Sam James <sam@gentoo.org> wrote:
>>
>> Followup to c3d1dac96bdd10250aa37bb367d5ef8334a093a1. As pointed out by
>> Maciej W. Rozycki, the casts are obviously useless now.
>> ---
>>
>>  malloc/tst-calloc.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/malloc/tst-calloc.c b/malloc/tst-calloc.c
>> index 122b2cbeaf..e0c1a06603 100644
>> --- a/malloc/tst-calloc.c
>> +++ b/malloc/tst-calloc.c
>> @@ -106,8 +106,8 @@ null_test (void)
>>    calloc (0, 0);
>>    calloc (0, max_size);
>>    calloc (max_size, 0);
>> -  calloc (0, ~((size_t) zero_size));
>> -  calloc (~((size_t) zero_size), 0);
>> +  calloc (0, ~zero_size);
>> +  calloc (~zero_size, 0);
>>    DIAG_POP_NEEDS_COMMENT;
>>  }
>>
>>
>> base-commit: 8ab34497de14e35aff09b607222fe1309ef156da
>> --
>> 2.48.1
>>
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

>
> Thanks.
diff mbox series

Patch

diff --git a/malloc/tst-calloc.c b/malloc/tst-calloc.c
index 122b2cbeaf..e0c1a06603 100644
--- a/malloc/tst-calloc.c
+++ b/malloc/tst-calloc.c
@@ -106,8 +106,8 @@  null_test (void)
   calloc (0, 0);
   calloc (0, max_size);
   calloc (max_size, 0);
-  calloc (0, ~((size_t) zero_size));
-  calloc (~((size_t) zero_size), 0);
+  calloc (0, ~zero_size);
+  calloc (~zero_size, 0);
   DIAG_POP_NEEDS_COMMENT;
 }