From patchwork Sat Sep 21 17:26:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 1988161 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=T5AotMtI; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X9x5W4gmlz1xsM for ; Sun, 22 Sep 2024 03:27:11 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 804BE3858416 for ; Sat, 21 Sep 2024 17:27:09 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 7FAE53858C31 for ; Sat, 21 Sep 2024 17:26:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FAE53858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7FAE53858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726939611; cv=none; b=oYUvijGMSLavCHXWAiiefa9ohi+CYWdozX5tXIW8rmmoP+oDdEbCj9cdbZ+CZRhT3eUT8dZ/q0JWFas8D5819u5ZADhheLnR2Qc/5jUVuXtkNcWo1eNW1sv/7Ecu0aFYkTDRhN+RPpCcwSEH+ol3MzWX/tpPkJWJ2t51ps0MRf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726939611; c=relaxed/simple; bh=KFNLByEA2shFiEogyiKNEh4EOYtntpUdVRP/ErSbhhA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=x6nGm9phXyjXFhq1TsmMwuZtqcTKQ5kPXeYoogoEA7ELlOzCEeINeZ7/Vy2jH6NQESi6WyMvRsXD7cAYhG+FJ6GaxHHlpPcOh0gcWPBVfy0cZz702nT4Z1nz60pfrffYiHXi8AQ8m0V7utVfEhg1Y5TQMfNdCcjPzT4mGT24nAM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726939608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=vPoFLMQvgmiuOFh+stc2nLxHo9pEcXW2iZoAsZhj9A4=; b=T5AotMtIqwNGUZa3S2jk/R/taEyAbFvoEr0/lNvYaR6Ism4ItSlzypZY/J9vfHtzqrTfc7 0tfIGkgVB7BNzBMN0qolzVMHS8VDEtPdmBKrgW7QD+3QR5Beqvdp6IyLG/YXRb9rwAzA/Y Mv5nmzBsdrI1v3zPHaNhASY+mcDSzSM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-43-cX87qSnjNaWyoA09U_KUUg-1; Sat, 21 Sep 2024 13:26:47 -0400 X-MC-Unique: cX87qSnjNaWyoA09U_KUUg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B18A3190FEFF for ; Sat, 21 Sep 2024 17:26:46 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.45.224.47]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C0B78195608A for ; Sat, 21 Sep 2024 17:26:45 +0000 (UTC) From: Florian Weimer To: libc-alpha@sourceware.org Subject: [PATCH COMMITTED] support: Fix memory leaks in FUSE tests Date: Sat, 21 Sep 2024 19:26:42 +0200 Message-ID: <87tte8yl2l.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org The internal read buffer (used by all FUSE tests) was not freed. The support/tst-support_fuse test missed a deallocation. --- support/support_fuse.c | 1 + support/tst-support_fuse.c | 1 + 2 files changed, 2 insertions(+) base-commit: e3db0a699c639e97deddcb15939fd9c162801c77 diff --git a/support/support_fuse.c b/support/support_fuse.c index 135dbf1198..f6c063b549 100644 --- a/support/support_fuse.c +++ b/support/support_fuse.c @@ -659,6 +659,7 @@ support_fuse_unmount (struct support_fuse *f) if (rmdir (f->mountpoint) != 0) FAIL ("FUSE: rmdir (\"%s\"): %m", f->mountpoint); xclose (f->fd); + free (f->buffer_start); free (f->mountpoint); free (f->readdir_buffer); free (f); diff --git a/support/tst-support_fuse.c b/support/tst-support_fuse.c index c4075a6608..9ee637cbab 100644 --- a/support/tst-support_fuse.c +++ b/support/tst-support_fuse.c @@ -331,6 +331,7 @@ do_test (void) { char *subdir_path = xasprintf ("%s/subdir", support_fuse_mountpoint (f)); xmkdir (subdir_path, 01234); + free (subdir_path); } {