From patchwork Thu Oct 3 18:51:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Ruoyao X-Patchwork-Id: 1992470 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xry111.site header.i=@xry111.site header.a=rsa-sha256 header.s=default header.b=XxXUROKY; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XKLRP3kvlz1xsn for ; Fri, 4 Oct 2024 04:53:21 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3860C384A821 for ; Thu, 3 Oct 2024 18:53:19 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 842E9385DDD1 for ; Thu, 3 Oct 2024 18:52:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 842E9385DDD1 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 842E9385DDD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727981567; cv=none; b=HdjqLTSfwnUkiopjzmDWSvRE+ymExaRGczx0lsGlCFFqBQcL3QtKRUXDaPuMiQujNx+VB7TKQvzPI02e2B4pBt2tHjsuScx7Wz3itrjRz6FPfJc7tOyczdGd2AetBVMWaj7B3qvfigwcEANt0JgkbehA604dufHQ93dneAjW7Mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727981567; c=relaxed/simple; bh=hFCXZ4fqV9/tnKHBrlwckaODmst3mrp7DdM9VPmLqqw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=jPVKfqY7z28YiYAy2HWonnVIlFxoNsrvbs85+sCVmGCjulYfb2r6El19voEjwnGvDNR57O4pP9GpgS98BlaQJ6i38bef6drzDXttfiM9Q0D4Xn5T4mglRvGc5Iathipm8Qh2FJkCOz+6G3ieG3kkKnH/uYaFnBxze1MWJHM53YQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xry111.site; s=default; t=1727981553; bh=BUi5Gk6G5Alz6h5KBrIqpd0tSqqtoPWdWlsBnA55WLE=; h=From:To:Cc:Subject:Date:From; b=XxXUROKYn56CQbkdukwVVoBGmcj7CMk9o9C60t0sXdF3lWNmO/XN+fSm3npz93FLd BFEMMvRlEWvOL/MKLaUE8PCNTyn609si+jiZ812S0psBVWJAGnFQ27lr5YCUwO2dLj 8npYAVzX1v6nP+6g2+jHlqdoNwOemQAC4veiPDPM= Received: from stargazer.. (unknown [IPv6:240e:358:11b8:8400:8482:f9d4:87c2:28ee]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 6465167320; Thu, 3 Oct 2024 14:52:29 -0400 (EDT) From: Xi Ruoyao To: libc-alpha@sourceware.org Cc: Florian Weimer , Adhemerval Zanella , Joseph Myers , Miao Wang , Xi Ruoyao Subject: [PATCH] io: statx, fstatat: Drop nonnull attribute on the path argument Date: Fri, 4 Oct 2024 02:51:40 +0800 Message-ID: <20241003185139.1600545-2-xry111@xry111.site> X-Mailer: git-send-email 2.46.2 MIME-Version: 1.0 X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org From: Miao Wang Since Linux 6.11 the kernel allows path to be NULL if flags & AT_EMPTY_PATH. Let's allow users to take the advantage if they don't care running on old kernels. [ xry111: separate the obvious change from the controversial "io: statx, fstatat64: allow using NULL as path" patch ] Signed-off-by: Miao Wang Signed-off-by: Xi Ruoyao --- io/bits/statx-generic.h | 2 +- io/sys/stat.h | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/io/bits/statx-generic.h b/io/bits/statx-generic.h index 19c3565edc..c0e00c9d8b 100644 --- a/io/bits/statx-generic.h +++ b/io/bits/statx-generic.h @@ -62,6 +62,6 @@ __BEGIN_DECLS /* Fill *BUF with information about PATH in DIRFD. */ int statx (int __dirfd, const char *__restrict __path, int __flags, unsigned int __mask, struct statx *__restrict __buf) - __THROW __nonnull ((2, 5)); + __THROW __nonnull ((5)); __END_DECLS diff --git a/io/sys/stat.h b/io/sys/stat.h index 3b4ba80132..7ea39b8755 100644 --- a/io/sys/stat.h +++ b/io/sys/stat.h @@ -263,14 +263,14 @@ extern int __REDIRECT_NTH (fstat64, (int __fd, struct stat64 *__buf), # ifndef __USE_FILE_OFFSET64 extern int fstatat (int __fd, const char *__restrict __file, struct stat *__restrict __buf, int __flag) - __THROW __nonnull ((2, 3)); + __THROW __nonnull ((3)); # else # ifdef __USE_TIME64_REDIRECTS # ifdef __REDIRECT_NTH extern int __REDIRECT_NTH (fstatat, (int __fd, const char *__restrict __file, struct stat *__restrict __buf, int __flag), - __fstatat64_time64) __nonnull ((2, 3)); + __fstatat64_time64) __nonnull ((3)); # else # define fstatat __fstatat64_time64 # endif @@ -279,7 +279,7 @@ extern int __REDIRECT_NTH (fstatat, (int __fd, const char *__restrict __file, extern int __REDIRECT_NTH (fstatat, (int __fd, const char *__restrict __file, struct stat *__restrict __buf, int __flag), - fstatat64) __nonnull ((2, 3)); + fstatat64) __nonnull ((3)); # else # define fstatat fstatat64 # endif @@ -290,7 +290,7 @@ extern int __REDIRECT_NTH (fstatat, (int __fd, const char *__restrict __file, # ifndef __USE_TIME64_REDIRECTS extern int fstatat64 (int __fd, const char *__restrict __file, struct stat64 *__restrict __buf, int __flag) - __THROW __nonnull ((2, 3)); + __THROW __nonnull ((3)); # else # ifdef __REDIRECT_NTH extern int __REDIRECT_NTH (fstatat64, (int __fd, @@ -298,7 +298,7 @@ extern int __REDIRECT_NTH (fstatat64, (int __fd, struct stat64 *__restrict __buf, int __flag), __fstatat64_time64) - __nonnull ((2, 3)); + __nonnull ((3)); # else # define fstatat64 __fstatat64_time64 # endif