diff mbox series

[htdocs] bugs: mention ASAN too

Message ID de620f81f811b5801dfca28a3c0403b7a7e8071b.1731311513.git.sam@gentoo.org
State New
Headers show
Series [htdocs] bugs: mention ASAN too | expand

Commit Message

Sam James Nov. 11, 2024, 7:51 a.m. UTC
Request that reporters try `-fsanitize=address,undefined` rather than
just `-fsanitize=undefined` when reporting bugs. We get invalid bug
reports which ASAN would've caught sometimes, even if it's less often
than where UBSAN would help.
---
OK?

 htdocs/bugs/index.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 96aaafdcdba21aad22fb1b745c75a01855dc5f0c

Comments

Sam James Nov. 20, 2024, 6:14 p.m. UTC | #1
Sam James <sam@gentoo.org> writes:

> Request that reporters try `-fsanitize=address,undefined` rather than
> just `-fsanitize=undefined` when reporting bugs. We get invalid bug
> reports which ASAN would've caught sometimes, even if it's less often
> than where UBSAN would help.
> ---
> OK?

Ping.

>
>  htdocs/bugs/index.html | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/htdocs/bugs/index.html b/htdocs/bugs/index.html
> index c7d2f310..d6556b26 100644
> --- a/htdocs/bugs/index.html
> +++ b/htdocs/bugs/index.html
> @@ -52,7 +52,7 @@ try a current release</strong> or development snapshot.</p>
>  with <code>gcc -Wall -Wextra</code> and see whether this shows anything
>  wrong with your code.  Similarly, if compiling with
>  <code>-fno-strict-aliasing -fwrapv -fno-aggressive-loop-optimizations</code>
> -makes a difference, or if compiling with <code>-fsanitize=undefined</code>
> +makes a difference, or if compiling with <code>-fsanitize=address,undefined</code>
>  produces any run-time errors, then your code is probably not correct.
>  </p>
>  
>
> base-commit: 96aaafdcdba21aad22fb1b745c75a01855dc5f0c
Gerald Pfeifer Nov. 20, 2024, 6:28 p.m. UTC | #2
On Mon, 11 Nov 2024, Sam James wrote:
> Request that reporters try `-fsanitize=address,undefined` rather than
> just `-fsanitize=undefined` when reporting bugs. We get invalid bug
> reports which ASAN would've caught sometimes, even if it's less often
> than where UBSAN would help.

I don't have a strong opinion on this and would prefer someone else to 
chime in. That said, if we don't hear from someone else by early next 
week, please go ahead and push.


Just one (naive) question: Are there instances where -fsanitize=undefined 
may be available/working where -fsanitize=address,undefined may be not?

If so, perhaps provide both invocations as in
   <code>-fsanitize=undefined</code> or <code>-fsanitize=address,un...
?

Your call; just a thought.

Gerald


>  htdocs/bugs/index.html | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/htdocs/bugs/index.html b/htdocs/bugs/index.html
> index c7d2f310..d6556b26 100644
> --- a/htdocs/bugs/index.html
> +++ b/htdocs/bugs/index.html
> @@ -52,7 +52,7 @@ try a current release</strong> or development snapshot.</p>
>  with <code>gcc -Wall -Wextra</code> and see whether this shows anything
>  wrong with your code.  Similarly, if compiling with
>  <code>-fno-strict-aliasing -fwrapv -fno-aggressive-loop-optimizations</code>
> -makes a difference, or if compiling with <code>-fsanitize=undefined</code>
> +makes a difference, or if compiling with <code>-fsanitize=address,undefined</code>
>  produces any run-time errors, then your code is probably not correct.
>  </p>
diff mbox series

Patch

diff --git a/htdocs/bugs/index.html b/htdocs/bugs/index.html
index c7d2f310..d6556b26 100644
--- a/htdocs/bugs/index.html
+++ b/htdocs/bugs/index.html
@@ -52,7 +52,7 @@  try a current release</strong> or development snapshot.</p>
 with <code>gcc -Wall -Wextra</code> and see whether this shows anything
 wrong with your code.  Similarly, if compiling with
 <code>-fno-strict-aliasing -fwrapv -fno-aggressive-loop-optimizations</code>
-makes a difference, or if compiling with <code>-fsanitize=undefined</code>
+makes a difference, or if compiling with <code>-fsanitize=address,undefined</code>
 produces any run-time errors, then your code is probably not correct.
 </p>