From patchwork Wed Feb 16 14:24:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 83368 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B8E56B7116 for ; Thu, 17 Feb 2011 01:24:46 +1100 (EST) Received: (qmail 25776 invoked by alias); 16 Feb 2011 14:24:43 -0000 Received: (qmail 25673 invoked by uid 22791); 16 Feb 2011 14:24:41 -0000 X-SWARE-Spam-Status: No, hits=-3.4 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Feb 2011 14:24:37 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) by mx2.suse.de (Postfix) with ESMTP id CE9EA86A2E for ; Wed, 16 Feb 2011 15:24:34 +0100 (CET) Date: Wed, 16 Feb 2011 15:24:34 +0100 (CET) From: Richard Guenther To: gcc-patches@gcc.gnu.org Subject: [PATCH] "Fix" PR47738 Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This fixes PR47738 with release checking by making sure the invalid IL that is detected during SSA verification from the loop manip machinery does not survive until after the end of the pass. The verificiation ICE still occurs though, thus the patch only migitates the possibly bad effect on later passes. The patch also fixes what is probably only an oversight - tree_predictive_commoning returns TODO_cleanup_cfg if it did anything but we just return zero from its caller. Oops. Bootstrapped (with -fpredicitive-commoning in BOOT_CFLAGS) and tested on x86_64-unknown-linux-gnu, applied to trunk. No testcase since that still ICEs. Richard. 2011-02-12 Richard Guenther PR tree-optimization/47738 * tree-ssa-loop.c (run_tree_predictive_commoning): Return the TODO from tree_predictive_commoning. Index: gcc/tree-ssa-loop.c =================================================================== --- gcc/tree-ssa-loop.c (revision 170210) +++ gcc/tree-ssa-loop.c (working copy) @@ -179,8 +179,7 @@ run_tree_predictive_commoning (void) if (!current_loops) return 0; - tree_predictive_commoning (); - return 0; + return tree_predictive_commoning (); } static bool