From patchwork Tue Nov 12 19:36:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John David Anglin X-Patchwork-Id: 2010526 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XnxW32jrPz1y09 for ; Wed, 13 Nov 2024 06:36:45 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B55C23858C41 for ; Tue, 12 Nov 2024 19:36:43 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from paco.parisc-linux.org (paco.parisc-linux.org [62.169.29.180]) by sourceware.org (Postfix) with ESMTPS id 2C0C83858D20 for ; Tue, 12 Nov 2024 19:36:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C0C83858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=parisc-linux.org Authentication-Results: sourceware.org; spf=none smtp.mailfrom=parisc-linux.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2C0C83858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=62.169.29.180 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731440185; cv=none; b=PT5ErBhL0ctQFCRUluBslvPj/xOSbpRQKpV3BHSdt5wu0wDav2v7ND2u+cpgPF5PiGDg09mIyVZ/iYcPsDblhhmdTxHPkGSVewmbovNmJZUaraXJmka3G+Ra9PNPAQm5E7tBd0tInjYPRYD+dh02O+WmCwGRJstFOt6is8XffqY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1731440185; c=relaxed/simple; bh=Oim84VwkoWTQ4dHFQZxVimvDI316Tu6uhTZha9oRAUk=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=GHQtxSUDJxunxM1/YGGWvT0ya1fqw78ViGw64K26PsB5FA0hWEr9To0A/8PEEXH77A14osynReWwYAK358v50PECzUU68dMecCFowKAN7R32slkJC9VJLDETrj7jalUuXSgdxpiZXXKIvN6MB709xy6TTQnEZ40GBAm7R4YtN1M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mx3210.localdomain (bras-base-otwaon0906w-grc-23-142-126-196-195.dsl.bell.ca [142.126.196.195]) by paco.parisc-linux.org (Postfix) with ESMTPSA id 1F45617E1040; Tue, 12 Nov 2024 19:36:21 +0000 (UTC) Received: by mx3210.localdomain (Postfix, from userid 1000) id A3731D60412; Tue, 12 Nov 2024 14:36:18 -0500 (EST) Date: Tue, 12 Nov 2024 14:36:18 -0500 From: John David Anglin To: GCC Patches Subject: [committed] hppa: Fix decrement_and_branch_until_zero constraint Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Noticed reload1.cc was miscompiled with LRA. Tested on hppa-unknown-linux-gnu and hppa64-hp-hpux11.11. Committed to active branches. Dave --- hppa: Fix decrement_and_branch_until_zero constraint The third alternative for argument 4 needs to be an early clobber constraint. Noticed testing LRA. 2024-11-12 John David Anglin gcc/ChangeLog: * config/pa/pa.md (decrement_and_branch_until_zero): Fix constraint. diff --git a/gcc/config/pa/pa.md b/gcc/config/pa/pa.md index bf59b7f601e..360198e9d08 100644 --- a/gcc/config/pa/pa.md +++ b/gcc/config/pa/pa.md @@ -9567,7 +9567,7 @@ add,l %2,%3,%3\;bv,n %%r0(%3)" (pc))) (set (match_dup 0) (plus:SI (match_dup 0) (match_dup 1))) - (clobber (match_scratch:SI 4 "=X,r,r"))] + (clobber (match_scratch:SI 4 "=X,r,&r"))] "" "* return pa_output_dbra (operands, insn, which_alternative); " ;; Do not expect to understand this the first time through.