From patchwork Fri Oct 4 10:07:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1992673 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ER615k0S; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XKkkS6Hcbz1xsn for ; Fri, 4 Oct 2024 20:07:44 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1701F38449DA for ; Fri, 4 Oct 2024 10:07:43 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E4919385DDD7 for ; Fri, 4 Oct 2024 10:07:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4919385DDD7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E4919385DDD7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728036441; cv=none; b=sUoqbwGCUbmclX5HNPycWr2UHOJKXYSdgygOZXSzsgHhK8u/M+ufmL0NNnOZNG8qr2Pn5vNkVzwXM3Z9OTQySr6QtqLad4oT6UQy4QePMnPsGeAxxMy7GHqTrRw3Kk1VxKowkb2T1rtMmK30i9KFgtCDT4+qdWUqgjVe9mi6kdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728036441; c=relaxed/simple; bh=ko+sw2cTPpjnb7eo6pIMe6si+0Hdz16WR9q4JTLzUIM=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=HoUB951Fp+PWZypIed3KlFF/OFtiP8S7JFjqwFiv30XOYT6ISpELSXcRUpNsQOMufY/j6PGYFRPvTAuiQMXZ3CKJykhUy24wWWD65XksNA7MSZmRdbRDzjQaedkK1HD5ELx697WUC8YzSLZj/z8xqKZcn7zwKkaXMa6fQ5SfRWE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728036439; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=m79aSVI8SfQC7EpEYXjk4fWlNBqjP0Sq6YuLUA4fmgY=; b=ER615k0S7p1dbPMEUwwwt0XvYReicuoXpKQb7WWI7cmSNLAw+OYagc61MBDlAeHBYc1TvC 74/3hyYUyuNrLhTp3EWhFXxSeyy2terdksazrHvg/gHQX0Hv+Gp9Q+wnZI9oRcQS4WrQeY Bpy1Zog8Ju5jt8EoUVo5t93Ip29eZfI= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-378-nlhM9ZNSN9O1Cz-0HELGKw-1; Fri, 04 Oct 2024 06:07:18 -0400 X-MC-Unique: nlhM9ZNSN9O1Cz-0HELGKw-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1F2FA1955F3C; Fri, 4 Oct 2024 10:07:17 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.61]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 434531955E93; Fri, 4 Oct 2024 10:07:16 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 494A7DOB2242056 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 4 Oct 2024 12:07:13 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 494A7DpE2242055; Fri, 4 Oct 2024 12:07:13 +0200 Date: Fri, 4 Oct 2024 12:07:12 +0200 From: Jakub Jelinek To: Uros Bizjak , Hongtao Liu Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] i386: Fix up *minmax3_2 splitter [PR116925] Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Hi! While *minmax3_1 correctly uses if (MEM_P (operands[1])) operands[1] = force_reg (mode, operands[1]); to ensure operands[1] is not a MEM, *minmax3_2 does it wrongly by calling force_reg but ignoring its return value. The following borderingly obvious patch fixes that, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Didn't find similar other errors in the backend with force_reg calls. 2024-10-04 Jakub Jelinek PR target/116925 * config/i386/sse.md (*minmax3_2): Assign force_reg result back to operands[2] instead of throwing it away. * g++.target/i386/avx-pr116925.C: New test. Jakub --- gcc/config/i386/sse.md.jj 2024-10-01 09:38:57.000000000 +0200 +++ gcc/config/i386/sse.md 2024-10-03 17:33:12.071507421 +0200 @@ -3269,7 +3269,7 @@ (define_insn_and_split "*minmax3_2 u = UNSPEC_IEEE_MAX; if (MEM_P (operands[2])) - force_reg (mode, operands[2]); + operands[2] = force_reg (mode, operands[2]); rtvec v = gen_rtvec (2, operands[2], operands[1]); rtx tmp = gen_rtx_UNSPEC (mode, v, u); emit_move_insn (operands[0], tmp); --- gcc/testsuite/g++.target/i386/avx-pr116925.C.jj 2024-10-03 17:36:10.124061111 +0200 +++ gcc/testsuite/g++.target/i386/avx-pr116925.C 2024-10-03 17:35:26.805656671 +0200 @@ -0,0 +1,12 @@ +// PR target/116925 +// { dg-do compile } +// { dg-options "-O2 -mavx -ffloat-store" } + +typedef float V __attribute__((vector_size (16))); +V a, b, c; + +void +foo () +{ + c = a > b ? a : b; +}