| Message ID | 20241126160638.1354607-1-dmalcolm@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | csky: use quotes when referring to cpus and archs [PR90160] | expand |
On 11/26/24 9:06 AM, David Malcolm wrote: > OK for trunk? (caveat: not properly tested) > > gcc/ChangeLog: > PR translation/90160 > * config/csky/csky.cc (csky_configure_build_target): Use %qs when > referring to cpu and arch names. > (csky_option_override): Likewise. It may be a dead port at this point. I'm not sure anyone is doing anything with csky. Regardless, this is OK and similar patches are per-approved anywhere else you need them. jeff
* Jeff Law: > On 11/26/24 9:06 AM, David Malcolm wrote: >> OK for trunk? (caveat: not properly tested) >> gcc/ChangeLog: >> PR translation/90160 >> * config/csky/csky.cc (csky_configure_build_target): Use %qs when >> referring to cpu and arch names. >> (csky_option_override): Likewise. > It may be a dead port at this point. I'm not sure anyone is doing > anything with csky. We are still building glibc with it. 8-> Last test results have been submitted for glibc 2.34 (three years ago). Last potentially non-generic change was from Alibaba (which matches the GCC maintainers' employer on record). Would it make sense to reach out and ask about port removal at this point? Thanks, Florian
On 11/26/24 11:43 AM, Florian Weimer wrote: > * Jeff Law: > >> On 11/26/24 9:06 AM, David Malcolm wrote: >>> OK for trunk? (caveat: not properly tested) >>> gcc/ChangeLog: >>> PR translation/90160 >>> * config/csky/csky.cc (csky_configure_build_target): Use %qs when >>> referring to cpu and arch names. >>> (csky_option_override): Likewise. > >> It may be a dead port at this point. I'm not sure anyone is doing >> anything with csky. > > We are still building glibc with it. 8-> It's still in my tester as well, so I build glibc for it daily. > > Last test results have been submitted for glibc 2.34 (three years ago). > Last potentially non-generic change was from Alibaba (which matches > the GCC maintainers' employer on record). Would it make sense to reach > out and ask about port removal at this point? IIRC it's Alibaba's chip. I'd heard through the grapevine that they're more focused on RISC-V these days. Xianmiao is definitely active on the RISC-V side, hopefully he'll chime in (now on cc). Jeff
On Tue, 2024-11-26 at 13:52 -0700, Jeff Law wrote: > > > On 11/26/24 11:43 AM, Florian Weimer wrote: > > * Jeff Law: > > > > > On 11/26/24 9:06 AM, David Malcolm wrote: > > > > OK for trunk? (caveat: not properly tested) > > > > gcc/ChangeLog: > > > > PR translation/90160 > > > > * config/csky/csky.cc (csky_configure_build_target): > > > > Use %qs when > > > > referring to cpu and arch names. > > > > (csky_option_override): Likewise. > > > > > It may be a dead port at this point. I'm not sure anyone is > > > doing > > > anything with csky. > > > > We are still building glibc with it. 8-> > It's still in my tester as well, so I build glibc for it daily. > > > > > Last test results have been submitted for glibc 2.34 (three years > > ago). > > Last potentially non-generic change was from Alibaba (which matches > > the GCC maintainers' employer on record). Would it make sense to > > reach > > out and ask about port removal at this point? > IIRC it's Alibaba's chip. I'd heard through the grapevine that > they're > more focused on RISC-V these days. Xianmiao is definitely active on > the RISC-V side, hopefully he'll chime in (now on cc). FWIW I've pushed the wording patch to trunk as r15-5703- ge2db825f857da1.
diff --git a/gcc/config/csky/csky.cc b/gcc/config/csky/csky.cc index 72619ea30312..5d295238ba58 100644 --- a/gcc/config/csky/csky.cc +++ b/gcc/config/csky/csky.cc @@ -2541,7 +2541,7 @@ csky_configure_build_target (struct csky_build_target *target, between different cpu & arch, should based on arch. */ if (csky_selected_arch && (csky_selected_cpu->base_arch != csky_selected_arch->base_arch)) - warning (0, "cpu %s is not based on arch %s, ignoring the arch", + warning (0, "cpu %qs is not based on arch %qs, ignoring the arch", csky_selected_cpu->name, csky_selected_arch->name); if (!csky_selected_arch) csky_selected_arch = &all_architectures[csky_selected_cpu->base_arch]; @@ -2607,7 +2607,7 @@ csky_option_override (void) || CSKY_TARGET_ARCH (CK860))) { flag_pic = 0; - warning (0, "%qs is not supported by arch %s", + warning (0, "%qs is not supported by arch %qs", "-fPIC", csky_active_target.arch_pp_name); } @@ -2645,7 +2645,7 @@ csky_option_override (void) } if (CSKY_TARGET_ARCH (CK801) || CSKY_TARGET_ARCH (CK802)) - error ("%qs is not supported by arch %s", + error ("%qs is not supported by arch %qs", "-mhard-float", csky_active_target.arch_pp_name); else if (csky_fpu_index == TARGET_FPU_auto) error ("%<-mhard-float%> is not supported by the selected CPU"); @@ -2710,7 +2710,7 @@ csky_option_override (void) pools are placed. */ if ((CSKY_TARGET_ARCH (CK801) || CSKY_TARGET_ARCH (CK802)) && !TARGET_CONSTANT_POOL) - error ("%qs is not supported by arch %s", + error ("%qs is not supported by arch %qs", "-mno-constpool", csky_active_target.arch_pp_name); else if (TARGET_CONSTANT_POOL == -1) TARGET_CONSTANT_POOL = (CSKY_TARGET_ARCH (CK801) @@ -2733,7 +2733,7 @@ csky_option_override (void) else if (TARGET_MINI_REGISTERS == -1) TARGET_MINI_REGISTERS = 0; if (TARGET_HIGH_REGISTERS > 0) - warning (0, "%qs is not supported by arch %s", + warning (0, "%qs is not supported by arch %qs", "-mhigh-registers", csky_active_target.arch_pp_name); TARGET_HIGH_REGISTERS = 0; } @@ -2750,7 +2750,7 @@ csky_option_override (void) if (CSKY_TARGET_ARCH (CK801)) { if (TARGET_MULTIPLE_STLD > 0) - warning (0, "%qs is not supported by arch %s", + warning (0, "%qs is not supported by arch %qs", "-mmultiple-stld", csky_active_target.arch_pp_name); TARGET_MULTIPLE_STLD = 0; }
OK for trunk? (caveat: not properly tested) gcc/ChangeLog: PR translation/90160 * config/csky/csky.cc (csky_configure_build_target): Use %qs when referring to cpu and arch names. (csky_option_override): Likewise. Signed-off-by: David Malcolm <dmalcolm@redhat.com> --- gcc/config/csky/csky.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)