| Message ID | 20241110125550.787007-8-hjl.tools@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Improve outgoing integer argument promotion | expand |
On Sun, Nov 10, 2024 at 1:56 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > Since the C frontend no longer promotes char argument, ssa-fre-4.c will > fail for all targets. Skip it for all targets. Maybe instead do /* { dg-final { scan-tree-dump-not " = \\\(\[^)\]*\\\)" "fre1" } } */ thus verify there are no casts in the IL for all targets? Or simply remove the test, skipping for all targets doesn't make much sense. Richard. > PR middle-end/14907 > * gcc.dg/tree-ssa/ssa-fre-4.c: Skip for all targets. > > Signed-off-by: H.J. Lu <hjl.tools@gmail.com> > --- > gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c > index 5a7588febaa..07d4d81996a 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c > @@ -1,6 +1,6 @@ > -/* If the target returns false for TARGET_PROMOTE_PROTOTYPES, then there > - will be no casts for FRE to eliminate and the test will fail. */ > -/* { dg-do compile { target i?86-*-* x86_64-*-* hppa*-*-* m68k*-*-* } } */ > +/* Since the C frontend no longer promotes char argument, there will be > + no casts for FRE to eliminate and the test will fail. */ > +/* { dg-do compile { target !*-*-* } } */ > /* { dg-options "-O -fno-tree-ccp -fno-tree-forwprop -fdump-tree-fre1-details" } */ > > /* From PR21608. */ > -- > 2.47.0 >
On Wed, Nov 20, 2024 at 10:27 PM Richard Biener <richard.guenther@gmail.com> wrote: > On Sun, Nov 10, 2024 at 1:56 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > > > Since the C frontend no longer promotes char argument, ssa-fre-4.c will > > fail for all targets. Skip it for all targets. > > Maybe instead do > > /* { dg-final { scan-tree-dump-not " = \\\(\[^)\]*\\\)" "fre1" } } */ > > thus verify there are no casts in the IL for all targets? Or simply > remove the test, > I will check. Thanks. > skipping for all targets doesn't make much sense. > > Richard. > > > PR middle-end/14907 > > * gcc.dg/tree-ssa/ssa-fre-4.c: Skip for all targets. > > > > Signed-off-by: H.J. Lu <hjl.tools@gmail.com> > > --- > > gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c > b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c > > index 5a7588febaa..07d4d81996a 100644 > > --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c > > +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c > > @@ -1,6 +1,6 @@ > > -/* If the target returns false for TARGET_PROMOTE_PROTOTYPES, then there > > - will be no casts for FRE to eliminate and the test will fail. */ > > -/* { dg-do compile { target i?86-*-* x86_64-*-* hppa*-*-* m68k*-*-* } } > */ > > +/* Since the C frontend no longer promotes char argument, there will be > > + no casts for FRE to eliminate and the test will fail. */ > > +/* { dg-do compile { target !*-*-* } } */ > > /* { dg-options "-O -fno-tree-ccp -fno-tree-forwprop > -fdump-tree-fre1-details" } */ > > > > /* From PR21608. */ > > -- > > 2.47.0 > > >
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c index 5a7588febaa..07d4d81996a 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c @@ -1,6 +1,6 @@ -/* If the target returns false for TARGET_PROMOTE_PROTOTYPES, then there - will be no casts for FRE to eliminate and the test will fail. */ -/* { dg-do compile { target i?86-*-* x86_64-*-* hppa*-*-* m68k*-*-* } } */ +/* Since the C frontend no longer promotes char argument, there will be + no casts for FRE to eliminate and the test will fail. */ +/* { dg-do compile { target !*-*-* } } */ /* { dg-options "-O -fno-tree-ccp -fno-tree-forwprop -fdump-tree-fre1-details" } */ /* From PR21608. */
Since the C frontend no longer promotes char argument, ssa-fre-4.c will fail for all targets. Skip it for all targets. PR middle-end/14907 * gcc.dg/tree-ssa/ssa-fre-4.c: Skip for all targets. Signed-off-by: H.J. Lu <hjl.tools@gmail.com> --- gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)