| Message ID | 20241108174453.2660197-1-torbjorn.svensson@foss.st.com |
|---|---|
| State | New |
| Headers | show |
| Series | testsuite: arm: Use effective-target for pr68674.c test | expand |
On Fri, 8 Nov 2024 at 18:54, Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> wrote: > > Ok for trunk and releases/gcc-14? > Can you describe what problem you are trying to fix? I'm guessing it's similar to your other patch for attr-neon* tests? And that the best / easiest course of action for the moment is to skip this test on M-profile? Thanks, Christophe > -- > > gcc/testsuite/ChangeLog: > > * gcc.target/arm/pr68674.c: Use effective-target arm_arch_v7a > and arm_libc_fp_abi. > > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > --- > gcc/testsuite/gcc.target/arm/pr68674.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/arm/pr68674.c b/gcc/testsuite/gcc.target/arm/pr68674.c > index 0b3237458fe..3fd562d0518 100644 > --- a/gcc/testsuite/gcc.target/arm/pr68674.c > +++ b/gcc/testsuite/gcc.target/arm/pr68674.c > @@ -1,9 +1,10 @@ > /* PR target/68674 */ > /* { dg-do compile } */ > -/* { dg-require-effective-target arm_neon_ok } */ > -/* { dg-require-effective-target arm_fp_ok } */ > +/* { dg-require-effective-target arm_arch_v7a_ok } */ > +/* { dg-require-effective-target arm_libc_fp_abi_ok } */ > /* { dg-options "-O2" } */ > -/* { dg-add-options arm_fp } */ > +/* { dg-add-options arm_arch_v7a } */ > +/* { dg-add-options arm_libc_fp_abi } */ > > #pragma GCC target ("fpu=vfp") > > -- > 2.25.1 >
On 2024-11-14 16:26, Christophe Lyon wrote: > On Fri, 8 Nov 2024 at 18:54, Torbjörn SVENSSON > <torbjorn.svensson@foss.st.com> wrote: >> >> Ok for trunk and releases/gcc-14? >> > Can you describe what problem you are trying to fix? > > I'm guessing it's similar to your other patch for attr-neon* tests? > And that the best / easiest course of action for the moment is to skip > this test on M-profile? Exactly. Without my patch, it would fail for armv8.1-m.main targets with -mfloat-abi=hard due to that the include file "arm_neon.h" is not compatible with Cortex-M. The test cases will therefor fail due to excess errors (about 2500 lines of errors). With my patch, we are always testing this in armv7-a context where the FPU used in the test case is compatible. Kind regards, Torbjörn > > Thanks, > > Christophe > >> -- >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/arm/pr68674.c: Use effective-target arm_arch_v7a >> and arm_libc_fp_abi. >> >> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> >> --- >> gcc/testsuite/gcc.target/arm/pr68674.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/gcc/testsuite/gcc.target/arm/pr68674.c b/gcc/testsuite/gcc.target/arm/pr68674.c >> index 0b3237458fe..3fd562d0518 100644 >> --- a/gcc/testsuite/gcc.target/arm/pr68674.c >> +++ b/gcc/testsuite/gcc.target/arm/pr68674.c >> @@ -1,9 +1,10 @@ >> /* PR target/68674 */ >> /* { dg-do compile } */ >> -/* { dg-require-effective-target arm_neon_ok } */ >> -/* { dg-require-effective-target arm_fp_ok } */ >> +/* { dg-require-effective-target arm_arch_v7a_ok } */ >> +/* { dg-require-effective-target arm_libc_fp_abi_ok } */ >> /* { dg-options "-O2" } */ >> -/* { dg-add-options arm_fp } */ >> +/* { dg-add-options arm_arch_v7a } */ >> +/* { dg-add-options arm_libc_fp_abi } */ >> >> #pragma GCC target ("fpu=vfp") >> >> -- >> 2.25.1 >>
diff --git a/gcc/testsuite/gcc.target/arm/pr68674.c b/gcc/testsuite/gcc.target/arm/pr68674.c index 0b3237458fe..3fd562d0518 100644 --- a/gcc/testsuite/gcc.target/arm/pr68674.c +++ b/gcc/testsuite/gcc.target/arm/pr68674.c @@ -1,9 +1,10 @@ /* PR target/68674 */ /* { dg-do compile } */ -/* { dg-require-effective-target arm_neon_ok } */ -/* { dg-require-effective-target arm_fp_ok } */ +/* { dg-require-effective-target arm_arch_v7a_ok } */ +/* { dg-require-effective-target arm_libc_fp_abi_ok } */ /* { dg-options "-O2" } */ -/* { dg-add-options arm_fp } */ +/* { dg-add-options arm_arch_v7a } */ +/* { dg-add-options arm_libc_fp_abi } */ #pragma GCC target ("fpu=vfp")
Ok for trunk and releases/gcc-14? -- gcc/testsuite/ChangeLog: * gcc.target/arm/pr68674.c: Use effective-target arm_arch_v7a and arm_libc_fp_abi. Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> --- gcc/testsuite/gcc.target/arm/pr68674.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)