diff mbox series

[1/3] aarch64: libgcc: Cleanup warnings in lse.S

Message ID 20241003194450.1052220-2-christophe.lyon@linaro.org
State New
Headers show
Series aarch64: Clean warnings in libgcc | expand

Commit Message

Christophe Lyon Oct. 3, 2024, 7:44 p.m. UTC 
Since
  Commit c608ada288ced0268bbbbc1fd4136f56c34b24d4
  Author:     Zac Walker <zacwalker@microsoft.com>
  CommitDate: 2024-01-23 15:32:30 +0000

  Ifdef `.hidden`, `.type`, and `.size` pseudo-ops for `aarch64-w64-mingw32` target

lse.S includes aarch64-asm.h, leading to a conflicting definition of macro 'L':
- in lse.S it expands to either '' or 'L'
- in aarch64-asm.h it is used to generate .L ## label

lse.S does not use the second, so this patch just undefines L after
the inclusion of aarch64-asm.h.

libgcc/
	* config/aarch64/lse.S: Undefine L() macro.
---
 libgcc/config/aarch64/lse.S | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Kyrylo Tkachov Oct. 4, 2024, 7:55 a.m. UTC | #1 
> On 3 Oct 2024, at 21:44, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> 
> External email: Use caution opening links or attachments
> 
> 
> Since
>  Commit c608ada288ced0268bbbbc1fd4136f56c34b24d4
>  Author:     Zac Walker <zacwalker@microsoft.com>
>  CommitDate: 2024-01-23 15:32:30 +0000
> 
>  Ifdef `.hidden`, `.type`, and `.size` pseudo-ops for `aarch64-w64-mingw32` target
> 
> lse.S includes aarch64-asm.h, leading to a conflicting definition of macro 'L':
> - in lse.S it expands to either '' or 'L'
> - in aarch64-asm.h it is used to generate .L ## label
> 
> lse.S does not use the second, so this patch just undefines L after
> the inclusion of aarch64-asm.h.


Ok.
Thanks,
Kyrill

> 
> libgcc/
>        * config/aarch64/lse.S: Undefine L() macro.
> ---
> libgcc/config/aarch64/lse.S | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/libgcc/config/aarch64/lse.S b/libgcc/config/aarch64/lse.S
> index ecef47086c6..77b3dc5a981 100644
> --- a/libgcc/config/aarch64/lse.S
> +++ b/libgcc/config/aarch64/lse.S
> @@ -54,6 +54,10 @@ see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
> #include "aarch64-asm.h"
> #include "auto-target.h"
> 
> +/* L is defined in aarch64-asm.h for a different purpose than why we
> +   use it here.  */
> +#undef L
> +
> /* Tell the assembler to accept LSE instructions.  */
> #ifdef HAVE_AS_LSE
>        .arch armv8-a+lse
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/libgcc/config/aarch64/lse.S b/libgcc/config/aarch64/lse.S
index ecef47086c6..77b3dc5a981 100644
--- a/libgcc/config/aarch64/lse.S
+++ b/libgcc/config/aarch64/lse.S
@@ -54,6 +54,10 @@  see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
 #include "aarch64-asm.h"
 #include "auto-target.h"
 
+/* L is defined in aarch64-asm.h for a different purpose than why we
+   use it here.  */
+#undef L
+
 /* Tell the assembler to accept LSE instructions.  */
 #ifdef HAVE_AS_LSE
 	.arch armv8-a+lse