From patchwork Thu Oct 3 16:08:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 1992424 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=VLcONNb7; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XKGp72dgrz1xtk for ; Fri, 4 Oct 2024 02:09:16 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CBD843846423 for ; Thu, 3 Oct 2024 16:09:13 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by sourceware.org (Postfix) with ESMTPS id 09D90385DC3C for ; Thu, 3 Oct 2024 16:08:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09D90385DC3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 09D90385DC3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727971732; cv=none; b=dq21OXapuK/aoKk1jNPmO0GKr0FNoCh0pZtvbdyNSxzMf6fJjKZdkX4vkI2LLBGj4YEUvvc89gzYrl+IkCB2qxhJYLjyKw/YStTd1Kzx1DySpn43Ny7e9vhi86lk/x9al8Ip8aFeFthT/NiJ+ZkyTgEHJqBzyJUa009t07JuwwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727971732; c=relaxed/simple; bh=hpXREUNr2Dc80qnLRKQHmw1alitCW5/BQbtY8KwLzmY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=T/qIiHG6GELmvfixJe/wqgEfRoM/nktj3u7PeENQAF38GSQYW26GvXuJOkptYxlieQsPL3UWetI6hVZiIQ6AI5kKEt8IDm/PrOrLlaYvAzrIEerTmd2vupaFtPxWQ7ThwDqRXl9hfUI6IGM3d/hrPVPftavDz+NQWxwrBdaahK4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4939OjlC021918 for ; Thu, 3 Oct 2024 16:08:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=0CPBPHAAfmu9XojINlRSdm fiymhp6VpRdqvyzELJH8Y=; b=VLcONNb7MQyAiEWBVp5BfWGAR/KcsrAzr2moS/ RYA76ABK2mAuleq7TTM57s8Z4pbGR+i8mRx6dx/8xN1+Vuh8SgJTkdTKXxcPyMuG n12ito8AEAcJa+xn+x9yFD9r+PQKKJG5pIYutowiw87S7Sc6z2R+PmTt2nBmEIs5 NVJaKI2mr3/HHup49JP1lLgiJscxsoYZhtC/3OclQsuzxJBvSBKQPGWBCIT2lYZu b/JNsig8o796U3GMxbkA7IYgUGuz9DeP9H6LquAp3jJcd6b9USbiqiAtZEffYWKr uM428tcNWzYAqA7/4YePFRgFZc8UThOxa7XOxhgNxmdfBVgw== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41yprau8yy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 03 Oct 2024 16:08:49 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 493G8mR6030138 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 3 Oct 2024 16:08:49 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 3 Oct 2024 09:08:48 -0700 From: Andrew Pinski To: CC: Andrew Pinski Subject: [PATCH 1/3] cfgexpand: Expand comment on when non-var clobbers can show up Date: Thu, 3 Oct 2024 09:08:34 -0700 Message-ID: <20241003160836.2297144-1-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: tdqWuAFtzQL8yoVkZHTFXyXGx5N5nLhh X-Proofpoint-ORIG-GUID: tdqWuAFtzQL8yoVkZHTFXyXGx5N5nLhh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 impostorscore=0 clxscore=1015 adultscore=0 mlxlogscore=689 bulkscore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2410030117 X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org The comment here is not wrong, just it would be better if mentioning the C++ front-end instead of just the nested function lowering. gcc/ChangeLog: * cfgexpand.cc (add_scope_conflicts_1): Expand comment on when non-var clobbers show up. Signed-off-by: Andrew Pinski --- gcc/cfgexpand.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gcc/cfgexpand.cc b/gcc/cfgexpand.cc index f32cf1b20c9..6c1096363af 100644 --- a/gcc/cfgexpand.cc +++ b/gcc/cfgexpand.cc @@ -639,8 +639,9 @@ add_scope_conflicts_1 (basic_block bb, bitmap work, bool for_conflict) { tree lhs = gimple_assign_lhs (stmt); unsigned *v; - /* Nested function lowering might introduce LHSs - that are COMPONENT_REFs. */ + /* Handle only plain var clobbers. + Nested functions lowering and C++ front-end inserts clobbers + which are not just plain variables. */ if (!VAR_P (lhs)) continue; if (DECL_RTL_IF_SET (lhs) == pc_rtx