From patchwork Thu Oct 3 00:42:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 1992203 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=X4iXk7WU; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XJtFW4q2Qz1xtk for ; Thu, 3 Oct 2024 10:43:07 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 38CE0385DDD5 for ; Thu, 3 Oct 2024 00:43:05 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id 11EC83858C48 for ; Thu, 3 Oct 2024 00:42:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11EC83858C48 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 11EC83858C48 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727916162; cv=none; b=m7JNtffj6OceGE449HGYjCuXqXRgt4ci+dtgTtfHSeYGUnWXMiKHajwz9Y+jtcFO8SARaDW1e2witGk9e1lb4mRA3rYsxUK/BiGDEKZOEpcB/YyMSr4MM0WBxVbl2vyiY3WxDTjaWl1QAgmb4pRVl9KkAbIr9kVzRtNCWvcPv3Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727916162; c=relaxed/simple; bh=DGex2ohpVV6Mug0sI0Q5859b02p/7Bl5k7kSxGnU98Y=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=twfsLhGYa8FTM68jxM/+gSRM9PI7HNfW4cu6Jf09aSoGsSh1HxyFRupRk2O4vnUNs2SmYKwUypopKpZHr4sj7SMVpdIQ8PQjHV7ZUXx3P5ZYW1wnHfrM3OC0pKCTBOVQb0S5XtjqG2cepTanrdS5AlWak9pFQxy7UIwuSDq77TA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 492Fio3w018305 for ; Thu, 3 Oct 2024 00:42:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=YrUwNFdCl6bzmpDyHzVCst L1OZ2gCKPoBgxS9HROHW0=; b=X4iXk7WUmMSYIHVYoPaSAwnwn7TrtTk5e9TyN2 pIu3ZztCPyQANS4jygBH/QCbMAWbf98yiBsf95nGseglXfWd8HTksc41teVXLFvv iHx/6uWnVJEMxIeR17PNKI8hTwvwzBQYLf9qKWGuyeWQCnW2hF0DfZsB60wq3X3I f4RUcyhqkszF6+Jj6OPGoUqJkqLcIjyZ0qEpnceaRbX+dJd7AV6L6V3xwqo/omWt Acic7/uAfu4bMjf7DIamNP2Aj8GHA61UXd963BbC/BG7RZ9nBv6ifqnbFbIJGCB8 K944R2xl4NNU0LzIzLcB2sY8LNLlcyihtRqDx6UIxQpqBAtA== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41x94hn0jh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 03 Oct 2024 00:42:40 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4930gdUe011978 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 3 Oct 2024 00:42:39 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 2 Oct 2024 17:42:38 -0700 From: Andrew Pinski To: CC: Andrew Pinski Subject: [PATCH] aarch64: Fix early ra for -fno-delete-dead-exceptions [PR116927] Date: Wed, 2 Oct 2024 17:42:28 -0700 Message-ID: <20241003004228.1934239-1-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: -fJvasm8BD-PXI-Lr18eWvLoUSzeFi3k X-Proofpoint-ORIG-GUID: -fJvasm8BD-PXI-Lr18eWvLoUSzeFi3k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2410030003 X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Early-RA was considering throwing instructions as being dead and removing them even if -fno-delete-dead-exceptions was in use. This fixes that oversight. Built and tested for aarch64-linux-gnu. PR target/116927 gcc/ChangeLog: * config/aarch64/aarch64-early-ra.cc (early_ra::is_dead_insn): Insns that throw are not dead with -fno-delete-dead-exceptions. gcc/testsuite/ChangeLog: * g++.dg/torture/pr116927-1.C: New test. Signed-off-by: Andrew Pinski --- gcc/config/aarch64/aarch64-early-ra.cc | 6 ++++++ gcc/testsuite/g++.dg/torture/pr116927-1.C | 15 +++++++++++++++ 2 files changed, 21 insertions(+) create mode 100644 gcc/testsuite/g++.dg/torture/pr116927-1.C diff --git a/gcc/config/aarch64/aarch64-early-ra.cc b/gcc/config/aarch64/aarch64-early-ra.cc index 5f269d029b4..6e544dd6191 100644 --- a/gcc/config/aarch64/aarch64-early-ra.cc +++ b/gcc/config/aarch64/aarch64-early-ra.cc @@ -3389,6 +3389,12 @@ early_ra::is_dead_insn (rtx_insn *insn) if (side_effects_p (set)) return false; + /* If we can't delete dead exceptions and the insn throws, + then the instruction is not dead. */ + if (!cfun->can_delete_dead_exceptions + && !insn_nothrow_p (insn)) + return false; + return true; } diff --git a/gcc/testsuite/g++.dg/torture/pr116927-1.C b/gcc/testsuite/g++.dg/torture/pr116927-1.C new file mode 100644 index 00000000000..22fa1dbd7e1 --- /dev/null +++ b/gcc/testsuite/g++.dg/torture/pr116927-1.C @@ -0,0 +1,15 @@ +// { dg-do compile } +// { dg-additional-options "-fnon-call-exceptions -fno-delete-dead-exceptions" } + +// PR target/116927 +// aarch64's Early ra was removing possiblely trapping +// floating point insn + +void +foo (float f) +{ + try { + f ++; + }catch(...) + {} +}