From patchwork Tue Oct 1 09:47:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1991381 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=N1HZTNZk; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=cNq9N49m; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=N1HZTNZk; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=cNq9N49m; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XHtQV0L2zz1xsq for ; Tue, 1 Oct 2024 19:47:30 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA5F2386D609 for ; Tue, 1 Oct 2024 09:47:27 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 7CDC7386D603 for ; Tue, 1 Oct 2024 09:47:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7CDC7386D603 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7CDC7386D603 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727776026; cv=none; b=mXK7oY2s1c1bOZgSjdueRCuK8Tc3GTlvP6vA7bWtzmEAPWkNPGe1qP1KQ9vLHF4GiHYmNstcUMP+mz+hrD3EiX1YBwnuqsqprsIlfmoJ98pIbO9zVD1RSfYjalnNbbT10ujm3+rOTwqQ01wcVqnUqHnNNDKAMvdLq1itsovSbs4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727776026; c=relaxed/simple; bh=i5ZEg/F2tS4eO9XxpbUwOJgq1fyPYjAZTtDERl95rCQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=AOJ5AlXsrWGvO2Y8GiQDZAO0Ta5apiZRZrpmxPQPifVUVCITyXfNmJvABJ4Cqu5X6bAAwHV+vbJivkWjA0ydLEFc+8dppQwY20RNrbTVTS76J+5gHs3wHq0sLDTZfc99h99spuI5/ww2WNZDLo3Vz/de3XJSmW8hJzL889q5z7Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 71AAF21AEC for ; Tue, 1 Oct 2024 09:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727776022; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=5LTFCmUJ6pBM8cXO5vZM3+xBsZblKEKJ8Kk8kskJfio=; b=N1HZTNZkU9KLYhN/bZ7w6Ja0EydMb05YzUTgLC8kI4LL/s/PDxJZopRwQeGla9t77pNONt DPo6AW7DmEC2Em/8CEOCDXcydAa5wva3k5Qo47lFgUZauSxpE/TZaObY2iK6fSXuWkMVgw lxM4pdlRZQaB8caKOy21Mi6326hSQvQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727776022; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=5LTFCmUJ6pBM8cXO5vZM3+xBsZblKEKJ8Kk8kskJfio=; b=cNq9N49m80PwZVJ16nLpdHVKFnFpJoUz3Cm0U4HUe5HO/f3xvbYvBrzxiukMsizjwmXhWZ czld9oFu3GXKLhCA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727776022; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=5LTFCmUJ6pBM8cXO5vZM3+xBsZblKEKJ8Kk8kskJfio=; b=N1HZTNZkU9KLYhN/bZ7w6Ja0EydMb05YzUTgLC8kI4LL/s/PDxJZopRwQeGla9t77pNONt DPo6AW7DmEC2Em/8CEOCDXcydAa5wva3k5Qo47lFgUZauSxpE/TZaObY2iK6fSXuWkMVgw lxM4pdlRZQaB8caKOy21Mi6326hSQvQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727776022; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=5LTFCmUJ6pBM8cXO5vZM3+xBsZblKEKJ8Kk8kskJfio=; b=cNq9N49m80PwZVJ16nLpdHVKFnFpJoUz3Cm0U4HUe5HO/f3xvbYvBrzxiukMsizjwmXhWZ czld9oFu3GXKLhCA== Date: Tue, 1 Oct 2024 11:47:02 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/116905 - ICE with bogus range ops MIME-Version: 1.0 X-Spam-Level: X-Spamd-Result: default: False [-0.05 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MISSING_MID(2.50)[]; NEURAL_SPAM_SHORT(0.88)[0.294]; NEURAL_HAM_LONG(-0.33)[-0.328]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; RCPT_COUNT_ONE(0.00)[1]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[murzim.nue2.suse.org:helo] X-Spam-Score: -0.05 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20241001094727.DA5F2386D609@sourceware.org> The following avoids querying ranges of vector entities. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. PR tree-optimization/116905 * tree-vect-stmts.cc (supportable_indirect_convert_operation): Fix guard for vect_get_range_info. * gcc.dg/pr116905.c: New testcase. --- gcc/testsuite/gcc.dg/pr116905.c | 14 ++++++++++++++ gcc/tree-vect-stmts.cc | 6 ++++-- 2 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/pr116905.c diff --git a/gcc/testsuite/gcc.dg/pr116905.c b/gcc/testsuite/gcc.dg/pr116905.c new file mode 100644 index 00000000000..0a2b96ac1c1 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr116905.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target float16 } */ +/* { dg-options "-frounding-math" } */ +/* { dg-additional-options "-mavx" { target avx } } */ + +typedef __attribute__((__vector_size__(16))) _Float16 F; +typedef __attribute__((__vector_size__(32))) int V; +F f; + +void +foo() +{ + f += __builtin_convertvector((V){3307}, F); +} diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index c0f8351d3de..e1e4f762078 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -14805,8 +14805,10 @@ supportable_indirect_convert_operation (code_helper code, In the future, if it is supported, changes may need to be made to this part, such as checking the RANGE of each element in the vector. */ - if ((TREE_CODE (op0) == SSA_NAME && !SSA_NAME_RANGE_INFO (op0)) - || !vect_get_range_info (op0, &op_min_value, &op_max_value)) + if (TREE_CODE (op0) != SSA_NAME + || !SSA_NAME_RANGE_INFO (op0) + || !vect_get_range_info (op0, &op_min_value, + &op_max_value)) break; if (cvt_type == NULL_TREE