From patchwork Mon Sep 30 07:10:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1990752 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wkxl5f6E; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=jVgYSA9U; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wkxl5f6E; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=jVgYSA9U; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XHC0N4yCgz1xsc for ; Mon, 30 Sep 2024 17:10:56 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0C786385F023 for ; Mon, 30 Sep 2024 07:10:54 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 1638C385EC0B for ; Mon, 30 Sep 2024 07:10:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1638C385EC0B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1638C385EC0B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727680235; cv=none; b=mj+HcK8Dj0A7dMNWPOOxJ9H6CK0PlfriO+JVeQc8uBda5SeLnEvwbbFvt9EgFU9a7VdsSQMd/r/fl84pPA+jMAYycAuYGVWUcvJWa2qhelZZDcGoJKFVk/6UttcCL9Y0OfIgW8YGg6xEb4kEXOxWUqgWFFIlp48oYm2Izc0a6Nc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727680235; c=relaxed/simple; bh=VBXxQbtsVtQjysnI0Y0ioS2E/vuhudqbeF0hf42Prcw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=twwSUYLCgr4jjoIk66TOiKQnUwSgzK5Aelz5BekQ9HtAI3JBVOd3vSGcU/h9HrsOhuHZDurhF/sand9p96JU7DtPxQ5Mjzle8WH0466qPK3gKPqfSK90kd/H7xZeLEqk1bWeuCEzCBGDfGvuQRu+EHUfcogrLeXmjAv+QFpW5mA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 98CE6219CD; Mon, 30 Sep 2024 07:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727680232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=xm3pDmCKBmIMOFwvq8eRw2XvNNI5kg/bLkmW1jUcyK0=; b=wkxl5f6ERdrTtcd2s9oGrQDB/+lkSG5XlvVXzu/X7lJ2on/cytfz8LTLaPHXTOfQEdrsLb ACEAcDvAS/yidUuPjdIYSJwad9s4iMajkUoTTcsbS/iciKXE8yEg4oW/eMpwKVXgJiYJYy gGHpObrmisAV39WOWYpIQtSx7Z+SXHg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727680232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=xm3pDmCKBmIMOFwvq8eRw2XvNNI5kg/bLkmW1jUcyK0=; b=jVgYSA9UK9lnCWZ5mvP8g2wBTKHj8ak5Zmap9KWByxHD3WB3r/6E6wp8XqPv2u+06KSyxr n8/iwaTTGw/QekBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wkxl5f6E; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jVgYSA9U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1727680232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=xm3pDmCKBmIMOFwvq8eRw2XvNNI5kg/bLkmW1jUcyK0=; b=wkxl5f6ERdrTtcd2s9oGrQDB/+lkSG5XlvVXzu/X7lJ2on/cytfz8LTLaPHXTOfQEdrsLb ACEAcDvAS/yidUuPjdIYSJwad9s4iMajkUoTTcsbS/iciKXE8yEg4oW/eMpwKVXgJiYJYy gGHpObrmisAV39WOWYpIQtSx7Z+SXHg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1727680232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=xm3pDmCKBmIMOFwvq8eRw2XvNNI5kg/bLkmW1jUcyK0=; b=jVgYSA9UK9lnCWZ5mvP8g2wBTKHj8ak5Zmap9KWByxHD3WB3r/6E6wp8XqPv2u+06KSyxr n8/iwaTTGw/QekBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6E028136CB; Mon, 30 Sep 2024 07:10:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id pSUnGehO+maRAQAAD6G6ig (envelope-from ); Mon, 30 Sep 2024 07:10:32 +0000 Date: Mon, 30 Sep 2024 09:10:24 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: Jan Hubicka Subject: [PATCH] tree-optimization/113197 - bougs assert in PTA MIME-Version: 1.0 Message-Id: <20240930071032.6E028136CB@imap1.dmz-prg2.suse.org> X-Rspamd-Queue-Id: 98CE6219CD X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,imap1.dmz-prg2.suse.org:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -4.51 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org PTA asserts that EAF_NO_DIRECT_READ is not set when flags are set consistently which doesn't make sense. The following removes the assert. Bootstrap & regtest running on x86_64-unknown-linux-gnu. Richard. PR tree-optimization/113197 * tree-ssa-structalias.cc (handle_call_arg): Remove bougs assert. * gcc.dg/lto/pr113197_0.c: New testcase. * gcc.dg/lto/pr113197_1.c: Likewise. --- gcc/testsuite/gcc.dg/lto/pr113197_0.c | 15 +++++++++++++++ gcc/testsuite/gcc.dg/lto/pr113197_1.c | 3 +++ gcc/tree-ssa-structalias.cc | 1 - 3 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/lto/pr113197_0.c create mode 100644 gcc/testsuite/gcc.dg/lto/pr113197_1.c diff --git a/gcc/testsuite/gcc.dg/lto/pr113197_0.c b/gcc/testsuite/gcc.dg/lto/pr113197_0.c new file mode 100644 index 00000000000..293c8207dee --- /dev/null +++ b/gcc/testsuite/gcc.dg/lto/pr113197_0.c @@ -0,0 +1,15 @@ +/* { dg-lto-do link } */ +/* { dg-lto-options { { -O -flto -fpie } } } */ +/* { dg-extra-ld-options { -r -nostdlib -flinker-output=nolto-rel } } */ + +enum a { b } register_dccp(); +void c(); +void __attribute__((noreturn)) exit_error(enum a d) { + __builtin_va_list va; + __builtin_va_end(va); + if (d) + c(); + c(); + __builtin_exit(1); +} +int main() { register_dccp(); } diff --git a/gcc/testsuite/gcc.dg/lto/pr113197_1.c b/gcc/testsuite/gcc.dg/lto/pr113197_1.c new file mode 100644 index 00000000000..30bf6f7e7c5 --- /dev/null +++ b/gcc/testsuite/gcc.dg/lto/pr113197_1.c @@ -0,0 +1,3 @@ +int a; +void exit_error(); +void register_dccp() { exit_error(a); } diff --git a/gcc/tree-ssa-structalias.cc b/gcc/tree-ssa-structalias.cc index 54c4818998d..73ba5aa6195 100644 --- a/gcc/tree-ssa-structalias.cc +++ b/gcc/tree-ssa-structalias.cc @@ -4194,7 +4194,6 @@ handle_call_arg (gcall *stmt, tree arg, vec *results, int flags, { make_transitive_closure_constraints (tem); callarg_transitive = true; - gcc_checking_assert (!(flags & EAF_NO_DIRECT_READ)); } /* If necessary, produce varinfo for indirect accesses to ARG. */