[v2,0/3] Add support for SVE2 faminmax

Message ID	20241001120933.1269122-1-saurabh.jha@arm.com
Headers	show Return-Path: <gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org> DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F38B43845152 Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: <saurabh.jha@arm.com> To: <gcc-patches@gcc.gnu.org> CC: <ktkachov@nvidia.com>, <richard.sandiford@arm.com>, Saurabh Jha <saurabh.jha@arm.com> Subject: [PATCH v2 0/3] Add support for SVE2 faminmax Date: Tue, 1 Oct 2024 13:09:30 +0100 Message-ID: <20241001120933.1269122-1-saurabh.jha@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain NoDisclaimer: true Precedence: list Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org
Series	Add support for SVE2 faminmax \| expand [v2,0/3] Add support for SVE2 faminmax [v2,1/3] aarch64: Add SVE2 faminmax intrinsics [v2,2/3] aarch64: Introduce new unspecs for smax/smin [v2,3/3] aarch64: Add codegen support for SVE2 faminmax

Message ID

20241001120933.1269122-1-saurabh.jha@arm.com

Headers

DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F38B43845152
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: <saurabh.jha@arm.com>
To: <gcc-patches@gcc.gnu.org>
CC: <ktkachov@nvidia.com>, <richard.sandiford@arm.com>, Saurabh Jha
 <saurabh.jha@arm.com>
Subject: [PATCH v2 0/3] Add support for SVE2 faminmax
Date: Tue, 1 Oct 2024 13:09:30 +0100
Message-ID: <20241001120933.1269122-1-saurabh.jha@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
NoDisclaimer: true
X-Microsoft-Antispam-Message-Info-Original: 
 V3l1fP309KTRIYtDHKMMgflXnw1Oly7hGs71gTsHYtbejzwl64Rk3Clox9gcB+jZs8mNtzGUpYueJnIv01Dm1Jn+F/XzQj1mhUyJWdmuCxkKdm4GY7icDgK4QeT3dKNnTxcXcH7uOHAhstHFHerIoQqFX2rdSOO6VbAWwN2FxzU2ebEJvCGs5gY0ESN3F8A4P26DAeVbpmEOou7hXqNSzVc0HoIRLH2dK/+fiJb3gsDIiUqLF1HwlCtjaGMGBMcoV57/ye9hmhvN1Pt0n8ES8xbflABCIz2o7YvcAGgWgfa3lJAtena4QJutNgSjnxvYMCgxu0DoSxeSOZ2lOiBc+bCTqQByMsL6+e++AB96nPvzjbnH3FYuXlzDJxfDzDSw1V+V1nP3eyatraeMmiftLr/jktOIwYchoRtsVeRisyvv4F8S5tgvoC5679tGLAXen4y8D0JxRjf9Qhw7BNcjrQMLNLXs+5UVbOHNQgaqOIaaHOui7N8Dq7+xPDvjjzF9vur3Y1tKFn16x0Z8JX7Jz0AsAF0yfSRKdJFkGwjmpMH6siD5qVzRXBIj0yIf4dsi4QUfT0ejC2w+jzOhUuySLG66ZQpX8MoIEoKWPxgajR4kmHPWJUQaX6lMizgBY/T9vA58FlcGKSLPKUBpUx2UlKxlNP7fxlCD5r1qP+lEuGtWI1kh7ra0XPVoJTiUiZNOOmmzOSofLPKBlpdylGInfEdos6Hnpu1nID02oam3sNCXYeX7jSAwha0mbFReN90X15YTAKtUB16kvaQxt4LI0NMwbHyOG36wj2czl5xvMVTqw+WIVpiKbyxApvcYEkiTIH0+U0rsPAGUijqzOzOMJzkk5KYTq6S/ZSXO+pwD4Z48qk+U2wSEEWdUx1xrPDEvFlp1WOgkFfmaxxm5Pzc6K4vrVuutNuFBhyP8nwFmNZ6XOBO+vN8VS3+UuCMNInG2UpR+BsxNbioglpKmz5B0GohZChgKwU9MFOiQtiReHAoJfIXkjuJObBdQj0uYZdM+ZX3kJs0vrtzvCBZi8woma3bDn///5gXYka6+CzIyAbIolrsfbb0/ATbk0Yuqes72pVibdQPFVQLIIgFuWOUUdP1hJLGGoj7SuIJswFfozdLHwqXHKVmYW1F5ZrIwOkN6NcGtbQidZjHz5otj0tE3diF9fseEEZOqJ6Mos7M+nL6jEZQ0K17vQ/I2IvnG7hFl006Xon+HApIYSGd10lJAUvGY0lHh/Ofg0xshnIask/kDnJ5/j7RUAEGZ7iFhYgvDnltosRdNbUdR+YL2uikCApd983CQQWHPWgBI1piBEFrfcTCMmhwU4ntNeaXLL5BDXJarGekmcqyjUV5nDBLlFjXwRNfw0QaRhhAOmAU7Y1X2BCwJ+V6tK4sq3Yk2+zmQHY0G03KZoAxmQxlPuMI/Tkq9s6mbVt6FN4IfOQxhbFqhqBLHnAvEBtsDMarzJzOs
X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en;
 SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent;
 CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026);
 DIR:OUT; SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8644
X-MS-Exchange-SkipListedInternetSender: ip=[2603:10a6:20b:499::20];
 domain=AS9PR05CA0089.eurprd05.prod.outlook.com
X-MS-Exchange-Transport-CrossTenantHeadersStripped: 
 DU6PEPF0000A7E4.eurprd02.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 
 599994a9-def7-4e05-0001-08dce211ecce
X-Microsoft-Antispam: BCL:0;
 ARA:13230040|82310400026|35042699022|376014|36860700013|1800799024;
X-Microsoft-Antispam-Message-Info: 
 F77R6z/GCZa9bdZYxBOUwU0SGrmyQmI14au4F4lfZPfvjbKCrzGFYnml93GszReZ6JlOKrBJxd83LSoygblnHof02yv5iQervR518s+HYYRz7eVpSE+UNmHazYnrwzQSVBp66wDINmAoe9nKmXALVe4YnbQVhIggjbWo7BBAQjWkhiKd/k68Vsji6kTXnYxPR7gSZLmKPI1H7eTzhGFzW1+UFC/Dltfbn2UST1gq9GGYb8EAARWjNIPaAZCcbkVcfzNZhCfJFnf1P8kbapNJBox8bgMgHWP81eSJHhmgjqXprgf/W97Z6KaCNEE/uXluvmSDJPckJ7IyTgyqO9fKfwr9DpP0ZZsOmLjDlx31C6D8feLFksnqER+e4AFZaqKtvatPd3Tk/IKJnsVmENIEjAPCrmrKMZTqSOcondlFGaRXWgJYI/TWQkyRENeVbBcoYPjfhl7WaIogG0wp36rW9fuimY/X1PaQmVokMpfMRz2Zpc5KQD64tJ8uJaLc096Gccxmf5/sj98ssqkc5FNm/4afQ1GM8joEoivEN6ep9DY5n/gmm4nTov9wA3bZWO3XygiBK8NlP+IGB9C5mvUHLxdHTEAGB4RglcxkXrjjsGWEtqN21cqzv7QHDKkF+kUHX2r4yJW3LUgBPG091rf9SkHMNo8TAmXZBQV+/4OC3bBGz6GOjGAAS4bmlDDI8FGbSbpiit98R67lfYJEAdjRU4HHELIWoTKvuWeO3HCKvWVwVtQRP2Pp0r/a3uUQK07Dmp5wvz/sgXqXxebFkgrrLRaPf22nrXCgYS43mQT/slOL1+8hd1cshVt3dnCVB3bst6ihQSD9Efybvss1vzgVHUHL6VaBhcZaPLrZlQBiALT60VuAms2vO1I1ysTWfSW9jbVkjJyy3kqyyPECg1IDfov0lXVJjpOT8J/81SF3l1OnRc3+SAr5+vrQ51C9EAqFeWcz2En1LeDbKp9AdL9pouVBMyoVpAJeNMgE+z+sHRWjkIRKAMmvXedGvzrmUuBZRmNRpM/ek6GYoAjW3rbTDmVjXVAeyzjRjsqqKxDIKh1BMd+STVNg2JOOLgFocKToBhb+Xbh2/H2X8sxD8/CX0Dt7VvuCeT8O85MbS+F6gVrpAOl4R56fb1+v67v0nV8PeIpM8s+WRWYc1a594jahj+0KzNW2su+VbUQRjn21zlx279MKFIcuKc63GP4ypBC/yyjVCSxd7jZgT80jJb6FxOjxq9xsn+J65KH7xhJtDhInlkEguKH9e3jx/hdbP6bHmhr3FJoMs98VjdX028AY0ULQ7gDvzSFkna81JOnEKlAiT9LjzA9K6+nFrDo1LLPR3uBW24QQ5/6upU0mKftsez51RMYJHG2TGDXx8UQrx8dZ+Mqg1sIfyyUCBKxvw9J6s1qlf5yYsGhREDGwp4R2ktcOvJvr7W9YZzSKu/9Lc20JJPJI84Ggn97Ap50C47vc
X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;
 IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;
 PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE;
 SFS:(13230040)(82310400026)(35042699022)(376014)(36860700013)(1800799024);
 DIR:OUT; SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 12:09:51.6959 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 e8187e30-ed07-4e94-4cd7-08dce211f41c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: 
 TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];
 Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: 
 DU6PEPF0000A7E4.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB10337
X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, KAM_SHORT,
 SPF_HELO_PASS, SPF_NONE, TXREP,
 UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org

Series

Add support for SVE2 faminmax | expand

Message

Saurabh Jha Oct. 1, 2024, 12:09 p.m. UTC

From: Saurabh Jha <saurabh.jha@arm.com>

This patch series a revised version of an earlier patch series:
https://gcc.gnu.org/pipermail/gcc-patches/2024-September/662951.html.

The main change in this patch series is the introduction of the two
unspecs, UNSPEC_COND_SMAX and UNSPEC_COND_SMIN, and using them for
existing minmax instructions and for the code generation of faminmax
instructions.

Other changes in this patch series are to address review comments:
1. [PATCH 1] Removing stray gcc/testsuite/gcc.target/aarch64/aminmax.h.
2. [PATCH 1] Fixing formatting in new iterators in iterators.md.
3. [PATCH 1] Using pragma "+sve+faminmax" in test cases. Remove options
   directive.
4. [PATCH 2] Move instruction pattern to aarch64-sve2.md.
5. [PATCH 2] Fix use of operand 2.
6. [PATCH 2] Fix use of assemble directive.
7. [PATCH 2] Using pragma "+sve+faminmax" and remove them from options.
8. [PATCH 2] New test cases to make sure we are not operator combine
   while using intrinsics.

Another minor change was in aarch64-sve-builtins-base.cc where we
fixed the formatting.

Saurabh Jha (3):
  aarch64: Add SVE2 faminmax intrinsics
  aarch64: Introduce new unspecs for smax/smin
  aarch64: Add codegen support for SVE2 faminmax

 .../aarch64/aarch64-sve-builtins-base.cc      |   4 +
 .../aarch64/aarch64-sve-builtins-base.def     |   5 +
 .../aarch64/aarch64-sve-builtins-base.h       |   2 +
 gcc/config/aarch64/aarch64-sve.md             |  33 ----
 gcc/config/aarch64/aarch64-sve2.md            |  31 ++++
 gcc/config/aarch64/aarch64.h                  |   1 +
 gcc/config/aarch64/iterators.md               |  97 +++++++----
 .../gcc.target/aarch64/sve/faminmax_1.c       |  85 ++++++++++
 .../gcc.target/aarch64/sve/faminmax_2.c       | 154 ++++++++++++++++++
 .../aarch64/sve2/acle/asm/amax_f16.c          | 142 ++++++++++++++++
 .../aarch64/sve2/acle/asm/amax_f32.c          | 142 ++++++++++++++++
 .../aarch64/sve2/acle/asm/amax_f64.c          | 142 ++++++++++++++++
 .../aarch64/sve2/acle/asm/amin_f16.c          | 142 ++++++++++++++++
 .../aarch64/sve2/acle/asm/amin_f32.c          | 142 ++++++++++++++++
 .../aarch64/sve2/acle/asm/amin_f64.c          | 142 ++++++++++++++++
 15 files changed, 1202 insertions(+), 62 deletions(-)
 create mode 100644 gcc/testsuite/gcc.target/aarch64/sve/faminmax_1.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/sve/faminmax_2.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f16.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f32.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amax_f64.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f16.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f32.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/sve2/acle/asm/amin_f64.c