From patchwork Mon Aug 5 07:22:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ivanhu X-Patchwork-Id: 1968912 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WcnvQ3mrHz1yZl for ; Mon, 5 Aug 2024 17:22:25 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1sas2r-0002tu-DX; Mon, 05 Aug 2024 07:22:17 +0000 Received: from smtp-relay-canonical-1.internal ([10.131.114.174] helo=smtp-relay-canonical-1.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1sas2p-0002tn-RZ for fwts-devel@lists.ubuntu.com; Mon, 05 Aug 2024 07:22:15 +0000 Received: from canonical.com (unknown [122.147.171.160]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 18F883F20C for ; Mon, 5 Aug 2024 07:22:14 +0000 (UTC) From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: acpipld: downgrade the severity for PLD on the not connected port Date: Mon, 5 Aug 2024 15:22:11 +0800 Message-Id: <20240805072211.57845-1-ivan.hu@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" BugLink: https://bugs.launchpad.net/fwts/+bug/2073023 Although it doesn't make sense for _UPC to claime the usb port not connectable, but still gets _PLD method with invalid value. The kernel patch https://github.com/torvalds/linux/commit/f3ac348e6e04501479fecf55250b25ff2092540b has fixed this warning on kernel. Additionally the implementation of the _PLD method does not actually impact USB functionality. Therefore, lower the severity of this test to warning. Signed-off-by: Ivan Hu --- src/acpi/acpipld/acpipld.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/acpi/acpipld/acpipld.c b/src/acpi/acpipld/acpipld.c index df81ae0f..ebb545ee 100644 --- a/src/acpi/acpipld/acpipld.c +++ b/src/acpi/acpipld/acpipld.c @@ -88,9 +88,7 @@ static int acpipld_test1(fwts_framework *fw) obj = buf.Pointer; if (obj->Package.Elements[0].Integer.Value == 0) { - fwts_failed(fw, LOG_LEVEL_MEDIUM, - "ACPIPLDExistNotConnectable", - "The ACPI method %s exists on the port " + fwts_warning(fw, "The ACPI method %s exists on the port " "claimed not connectable by the %s.", name, name_upc); failed = true;