diff mbox series

acpi: acpipld: downgrade the severity for PLD on the not connected port

Message ID 20240805072211.57845-1-ivan.hu@canonical.com
State Accepted
Headers show
Series acpi: acpipld: downgrade the severity for PLD on the not connected port | expand

Commit Message

ivanhu Aug. 5, 2024, 7:22 a.m. UTC
BugLink: https://bugs.launchpad.net/fwts/+bug/2073023

Although it doesn't make sense for _UPC to claime the usb port not
connectable, but still gets _PLD method with invalid value.
The kernel patch https://github.com/torvalds/linux/commit/f3ac348e6e04501479fecf55250b25ff2092540b
has fixed this warning on kernel. Additionally the implementation of
the _PLD method does not actually impact USB functionality.
Therefore, lower the severity of this test to warning.

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 src/acpi/acpipld/acpipld.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/src/acpi/acpipld/acpipld.c b/src/acpi/acpipld/acpipld.c
index df81ae0f..ebb545ee 100644
--- a/src/acpi/acpipld/acpipld.c
+++ b/src/acpi/acpipld/acpipld.c
@@ -88,9 +88,7 @@  static int acpipld_test1(fwts_framework *fw)
 
 					obj = buf.Pointer;
 					if (obj->Package.Elements[0].Integer.Value == 0) {
-						fwts_failed(fw, LOG_LEVEL_MEDIUM,
-							"ACPIPLDExistNotConnectable",
-							"The ACPI method %s exists on the port "
+						fwts_warning(fw, "The ACPI method %s exists on the port "
 							"claimed not connectable by the %s.",
 							name, name_upc);
 							failed = true;