diff mbox series

acpi: s3: enable debug messages on S0ix failure for Intel platforms

Message ID 20240126075049.35922-1-ivan.hu@canonical.com
State Accepted
Headers show
Series acpi: s3: enable debug messages on S0ix failure for Intel platforms | expand

Commit Message

ivanhu Jan. 26, 2024, 7:50 a.m. UTC 
BugLink: https://bugs.launchpad.net/fwts/+bug/2051336

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 src/acpi/s3/s3.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
diff mbox series

Patch

diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c
index 15e5e871..903f22f4 100644
--- a/src/acpi/s3/s3.c
+++ b/src/acpi/s3/s3.c
@@ -37,10 +37,13 @@ 
 #define PM_SUSPEND_TOTAL_HW_SLEEP	"/sys/power/suspend_stats/total_hw_sleep"
 #define WAKEUP_SOURCE_PATH		"/sys/kernel/debug/wakeup_sources"
 #define INTEL_PM_S2IDLE_SLP_S0		"/sys/kernel/debug/pmc_core/slp_s0_residency_usec"
+#define INTEL_PM_S0IX_WARN		"/sys/module/intel_pmc_core/parameters/warn_on_s0ix_failures"
 
 static char sleep_type[7];
 static char sleep_type_orig[7];
 
+static bool s0ix2_warn_enable_orig = false;
+
 static int  s3_multiple = 1;		/* number of s3 multiple tests to run */
 static int  s3_min_delay = 0;		/* min time between resume and next suspend */
 static int  s3_max_delay = 30;		/* max time between resume and next suspend */
@@ -222,15 +225,32 @@  static int s3_init(fwts_framework *fw)
 		strncpy(sleep_type, "S3", strlen("S3") + 1);
 	}
 
+	str = fwts_get(INTEL_PM_S0IX_WARN);
+	if (str && strstr(str, "N"))
+		(void)fwts_set(INTEL_PM_S0IX_WARN, "Y");
+	else if (str && strstr(str, "Y"))
+		s0ix2_warn_enable_orig = true;
+	if (str)
+		free(str);
+
 	return FWTS_OK;
 }
 
 static int s3_deinit(fwts_framework *fw)
 {
+	char *str;
 
 	FWTS_UNUSED(fw);
 	(void)fwts_set(PM_SUSPEND_PATH, sleep_type_orig);
 
+	str = fwts_get(INTEL_PM_S0IX_WARN);
+	if (str && strstr(str, "N") && s0ix2_warn_enable_orig)
+		(void)fwts_set(INTEL_PM_S0IX_WARN, "Y");
+	else if (str && strstr(str, "Y") && !s0ix2_warn_enable_orig)
+		(void)fwts_set(INTEL_PM_S0IX_WARN, "N");
+	if (str)
+		free(str);
+
 	return FWTS_OK;
 }