From patchwork Thu Jan 11 10:21:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ivanhu X-Patchwork-Id: 1885455 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4T9ggg4xr2z1yPp for ; Thu, 11 Jan 2024 21:21:34 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rNsBg-0000pG-Ud; Thu, 11 Jan 2024 10:21:25 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rNsBa-0000oM-TV for fwts-devel@lists.ubuntu.com; Thu, 11 Jan 2024 10:21:19 +0000 Received: from canonical.com (unknown [106.104.136.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id B3299413BC for ; Thu, 11 Jan 2024 10:21:17 +0000 (UTC) From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH 1/2] acpi: ccel: add tests for ACPI CCEL table (mantis 2314) Date: Thu, 11 Jan 2024 18:21:03 +0800 Message-Id: <20240111102104.374625-1-ivan.hu@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" BugLink: https://bugs.launchpad.net/fwts/+bug/2047212 The ACPI CCEL(CC Event Log) table was added to ACPI6.5, add tests for the CCEL table. Signed-off-by: Ivan Hu --- src/Makefile.am | 1 + src/acpi/ccel/ccel.c | 78 +++++++++++++++++++++++++++++++++++++ src/lib/include/fwts_acpi.h | 13 +++++++ 3 files changed, 92 insertions(+) create mode 100644 src/acpi/ccel/ccel.c diff --git a/src/Makefile.am b/src/Makefile.am index dde55098..ecb6d63a 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -69,6 +69,7 @@ fwts_SOURCES = main.c \ acpi/brightness/brightness-helper.c \ acpi/brightness/brightness.c \ acpi/brightness/autobrightness.c \ + acpi/ccel/ccel.c \ acpi/cedt/cedt.c \ acpi/checksum/checksum.c \ acpi/cpep/cpep.c \ diff --git a/src/acpi/ccel/ccel.c b/src/acpi/ccel/ccel.c new file mode 100644 index 00000000..0d979a2a --- /dev/null +++ b/src/acpi/ccel/ccel.c @@ -0,0 +1,78 @@ +/* + * Copyright (C) 2024 Canonical + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + */ +#include "fwts.h" + +#if defined(FWTS_HAS_ACPI) + +#include +#include +#include +#include +#include + +static fwts_acpi_table_info *table; +acpi_table_init(CCEL, &table) + +static int ccel_test1(fwts_framework *fw) +{ + + bool passed = true; + fwts_acpi_table_ccel *ccel = (fwts_acpi_table_ccel *)table->data; + + if (ccel->header.length != sizeof(fwts_acpi_table_ccel)) { + fwts_failed(fw, LOG_LEVEL_HIGH, + "CCELBadTableLength", + "CCEL table lengthe shoud be %" PRIu32 ", got %" PRIu32 + " instead.", (uint32_t)sizeof(fwts_acpi_table_ccel), + ccel->header.length); + return FWTS_OK; + } + + fwts_log_info_verbatim(fw, "CC Event Log ACPI Table:"); + fwts_log_info_simp_int(fw, " CC Type: ", ccel->cc_type); + if (ccel->cc_type == 0 || ccel->cc_type >= 3) { + fwts_failed(fw, LOG_LEVEL_HIGH, + "CCELBadCCType", + "CCEL CC types must not have the reaserved value 0, 0x03..0xff, " + "got 0x%2.2" PRIx8 " instead.", ccel->cc_type); + passed = false; + } + fwts_log_info_simp_int(fw, " CC Subtype: ", ccel->cc_subtype); + fwts_log_info_simp_int(fw, " Reserved: ", ccel->reserved); + fwts_acpi_reserved_zero("CCEL", "Reserved", ccel->reserved, &passed); + fwts_log_info_simp_int(fw, " Log Area Minimum Length(LAML): ", ccel->laml); + fwts_log_info_simp_int(fw, " Log Area Start Address(LASA): ", ccel->lasa); + fwts_log_nl(fw); + + if (passed) + fwts_passed(fw, "No issues found in CCEL table."); + + return FWTS_OK; +} + +static fwts_framework_minor_test ccel_tests[] = { + { ccel_test1, "Validate CCEL table." }, + { NULL, NULL } +}; + +static fwts_framework_ops ccel_ops = { + .description = "CCEL CC Event Log ACPI Table test.", + .init = CCEL_init, + .minor_tests = ccel_tests +}; + +FWTS_REGISTER("ccel", &ccel_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ACPI) + +#endif diff --git a/src/lib/include/fwts_acpi.h b/src/lib/include/fwts_acpi.h index a78aa577..2538a847 100644 --- a/src/lib/include/fwts_acpi.h +++ b/src/lib/include/fwts_acpi.h @@ -2819,4 +2819,17 @@ typedef struct { fwts_acpi_misc_guided_entry entry[0]; } __attribute__ ((packed)) fwts_acpi_table_misc; +/* + * CC Event Log ACPI Table + * ACPI6.5 5.2.34 + */ +typedef struct { + fwts_acpi_table_header header; + uint8_t cc_type; + uint8_t cc_subtype; + uint16_t reserved; + uint64_t laml; + uint64_t lasa; +} __attribute__ ((packed)) fwts_acpi_table_ccel; + #endif