| Message ID | 20230919185151.70591-1-mario.limonciello@amd.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | acpi: Recognize Pluton TPM | expand |
On 9/20/23 02:51, Mario Limonciello wrote: > Pluton TPM uses start method 0xd and is supported by the TPM CRB driver. > This shouldn't cause a test failure. > ``` > tpm2: TPM2's Start Method must be between one to eleven, got 0xd > ``` > Link: https://github.com/torvalds/linux/blob/v6.5/include/acpi/actbl3.h#L446 > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > src/acpi/tpm2/tpm2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/acpi/tpm2/tpm2.c b/src/acpi/tpm2/tpm2.c > index 02147d18..8d9cc9f1 100644 > --- a/src/acpi/tpm2/tpm2.c > +++ b/src/acpi/tpm2/tpm2.c > @@ -51,11 +51,11 @@ static int tpm2_test1(fwts_framework *fw) > > fwts_acpi_reserved_zero("TPM2", "Reserved", tpm2->reserved, &passed); > > - if (tpm2->start_method < 1 || tpm2->start_method >= 12) { > + if (tpm2->start_method < 1 || tpm2->start_method >= 14) { > passed = false; > fwts_failed(fw, LOG_LEVEL_HIGH, > "TPM2BadStartMethod", > - "TPM2's Start Method must be between one to eleven, got 0x%" PRIx16, > + "TPM2's Start Method must be between 0x1 and 0xd, got 0x%" PRIx16, > tpm2->start_method); > } > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/acpi/tpm2/tpm2.c b/src/acpi/tpm2/tpm2.c index 02147d18..8d9cc9f1 100644 --- a/src/acpi/tpm2/tpm2.c +++ b/src/acpi/tpm2/tpm2.c @@ -51,11 +51,11 @@ static int tpm2_test1(fwts_framework *fw) fwts_acpi_reserved_zero("TPM2", "Reserved", tpm2->reserved, &passed); - if (tpm2->start_method < 1 || tpm2->start_method >= 12) { + if (tpm2->start_method < 1 || tpm2->start_method >= 14) { passed = false; fwts_failed(fw, LOG_LEVEL_HIGH, "TPM2BadStartMethod", - "TPM2's Start Method must be between one to eleven, got 0x%" PRIx16, + "TPM2's Start Method must be between 0x1 and 0xd, got 0x%" PRIx16, tpm2->start_method); }
Pluton TPM uses start method 0xd and is supported by the TPM CRB driver. This shouldn't cause a test failure. ``` tpm2: TPM2's Start Method must be between one to eleven, got 0xd ``` Link: https://github.com/torvalds/linux/blob/v6.5/include/acpi/actbl3.h#L446 Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- src/acpi/tpm2/tpm2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)