From patchwork Thu Mar 9 09:00:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ivanhu X-Patchwork-Id: 1754545 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=I0cyw/8k; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PXNSd2NMJz246y for ; Thu, 9 Mar 2023 20:00:49 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1paC8e-0005pO-Mw; Thu, 09 Mar 2023 09:00:40 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1paC8O-0005nx-SS for fwts-devel@lists.ubuntu.com; Thu, 09 Mar 2023 09:00:24 +0000 Received: from canonical.com (unknown [106.104.136.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 4C2CB3F258 for ; Thu, 9 Mar 2023 09:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1678352424; bh=/3AXfg8TAM+2syHTdHU1Y+BRoBGwdJrHJriktmzgTwo=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=I0cyw/8kJNcspoQS2AS6l2qhOEatZkzh9E5SDV5Sr5eOSQ/ol2TfqhuauX2fyAYut VJhOzswBxxv/ZJwhiIAH5GBuOmoeWWnxzMeA+Kl/WALFvF1X9STi8qZjvbLOthKsVT CV1otwDbL/+Ngms6IjziCKK+yOKIUUesVrE3iFPQoYkGoOapnZjO3oGV+/whO5ZBW7 v48pWwW58ErR6PaTovNEKNEr9Pk8VgjKzBdYFgbj06UXK4k1itXGYZuHI2yuX4s1Y5 CnrnrzpjoSLXfERwvT6LqpbXhbrcaTXGb32aCwzz5ALphsvQ+kuz7zgzl/8whOrc3W xogmFL+Yo1lMQ== From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH 01/10] dmicheck: fix the extended bios ROM size bit check of type 0 Date: Thu, 9 Mar 2023 17:00:09 +0800 Message-Id: <20230309090018.32029-1-ivan.hu@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From the SMBIOS specification, 7.1 the Extended Bios ROM Size Bits 14:15, only 10b and 11b are reserved Signed-off-by: Ivan Hu --- src/dmi/dmicheck/dmicheck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index 497a5c5f..22b7a6ec 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -1297,7 +1297,7 @@ static void dmicheck_entry(fwts_framework *fw, /* new fields in spec 3.11 */ if (hdr->length < 0x1a) break; - dmi_reserved_bits_check(fw, table, addr, "Extended BIOS ROM Size", hdr, sizeof(uint16_t), 0x18, 14, 15); + dmi_reserved_bits_check(fw, table, addr, "Extended BIOS ROM Size", hdr, sizeof(uint16_t), 0x18, 15, 15); break; case 1: /* 7.2 */