From patchwork Wed May 11 09:42:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Hu X-Patchwork-Id: 1629516 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=p4RjPU6c; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Kyqgt38vdz9sG0 for ; Wed, 11 May 2022 19:42:17 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1noirG-0001EO-ES; Wed, 11 May 2022 09:42:14 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1noirF-0001Db-8o for fwts-devel@lists.ubuntu.com; Wed, 11 May 2022 09:42:13 +0000 Received: from canonical.com (unknown [106.104.72.120]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 6168B3FAB8 for ; Wed, 11 May 2022 09:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1652262131; bh=D/OBsvtQRiDaoy8RALqQqTr01l+hlObBCtpZ7kPEQ3U=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=p4RjPU6cdpietjLqZA/izYw3ZNAQBQZtb9Ua+srQNH/huw7oyORoVosR/Mvsb7Il6 RrD19lEy+acys8JJ7qP66fYJtBXAtcEXvRDnxh7x8j3n4R/cfTTRaiofvbliiYfUo9 krg9zQzAlBEjbbKSgVumhvnVcCrcN5IO/BksYpEBtrHxAOsZN4ufMhuuVUkHSDyMBW TQn5wyzCqXDQcxmtLE+wkwXSyuEnGg5P4MEMJUHwUo+kcH3PdBlk9V1dqN37qq1PXj kaiaJ11BgvqdTlQEc+IeJkK/zG2BoKB+X7m/IjeL7fE7+HpRZ9AVzPSz3gNPaxSLzI Be9X+32cgLaOg== From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: mcfg: checking kernel lockdown when doing mmap PCI config space Date: Wed, 11 May 2022 17:42:06 +0800 Message-Id: <20220511094206.20916-1-ivan.hu@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" Buglink: https://bugs.launchpad.net/fwts/+bug/1972973 Signed-off-by: Ivan Hu --- src/acpi/mcfg/mcfg.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/acpi/mcfg/mcfg.c b/src/acpi/mcfg/mcfg.c index 83e4ec8e..b0832b6b 100644 --- a/src/acpi/mcfg/mcfg.c +++ b/src/acpi/mcfg/mcfg.c @@ -65,6 +65,20 @@ static int compare_config_space( } if ((mapped_config_space = fwts_mmap(config->base_address, page_size)) == FWTS_MAP_FAILED) { + char *data; + + if ((data = fwts_get("/sys/kernel/security/lockdown")) != NULL) { + if (strstr(data, "[none]") == NULL) { + free(data); + fwts_log_info(fw, "Kernel is in lockdown mode. Aborted."); + fwts_log_info(fw, "Please unlock the kernel before testing."); + fwts_log_info(fw, "Make sure you disable secureboot and disable " + "the kernel lockdown, (by kernel parameter lockdown=None)."); + return FWTS_ABORTED; + } + } + free(data); + fwts_failed(fw, LOG_LEVEL_MEDIUM, "MMapUnmappable", "Cannot mmap PCI config space at 0x%" PRIx64 ".", config->base_address);