From patchwork Tue Nov 30 18:30:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1561772 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=hoeuSWsp; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4J3W4q4bdYz9sRN for ; Wed, 1 Dec 2021 05:31:07 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ms7uB-00036h-Ft; Tue, 30 Nov 2021 18:31:03 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ms7uA-00036G-Bf for fwts-devel@lists.ubuntu.com; Tue, 30 Nov 2021 18:31:02 +0000 Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 38C143F1B1 for ; Tue, 30 Nov 2021 18:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638297062; bh=4SXg4CbS84iyvXpIEqIP+Bdo0VxhLT9ZFNO1VgX+5EE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=hoeuSWspAKdJehM0Y+N07MGh0EmsjBVGCP9+0ROW3zpV1/xmLhcxkqm+AB04MmBaW zQ3eZ6Sb5EWDHaXe1oH+zYNwsmJisdfW4jcTw5QI/V/qwweCjzHvYrMQQDAmAhSxUf jNZVy8Fi0O1J2lP2/f47GwE1hejOfgp59NsKCZrc0fbFOz/0CewXmQFRnae6t39bLS pitGwHp7CP06mnuAsjHRoV3rbeu1HJSd4xwk2vu0W9fJf7R2gEKFe/+67fxqkPj8ot ZY9FdhpJ/yldavyACRHE+ktRwznKxa9AzMdBhdhgK4WVC75BwnSMp2TLUkUYF7hgsa 9z2qfbpebHUYA== Received: by mail-pf1-f197.google.com with SMTP id i26-20020aa7909a000000b004a4c417bfa8so13273644pfa.23 for ; Tue, 30 Nov 2021 10:31:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4SXg4CbS84iyvXpIEqIP+Bdo0VxhLT9ZFNO1VgX+5EE=; b=lo6ECUswPG4oxFyVLlwgklemR/O+eozcdnnzpGp6cFzU2wLKSM4zK/gVxtLJvv5rvE T9KWObTajkmpAq9F303WyJw2z8ukvj/fNm6KDCCVYAdTqwk6Yf7T3NwW7F9laB21EtVl WtWFOX1pHQw/kSUHPypeLSuuhyXdmO6M8YMkpHekl51lEzDvqN2PqkJFMNiZyKKKOx2l wfDJ6JsefqM18db2DCQRaAEa3Eb1WtWNDU+bMhv7TYCmj4m2J+ODFFn3bLu022iomEke nVVJCDI/QoyDy2QRLChygj95duMkzeo4gnjQuPvDASOe+tMUfQKqhofcnEgK6LTgduOF HuZA== X-Gm-Message-State: AOAM531zJ1ty2WC+2WPfe/G3Xl1PJZSB6KNALwhnQeHMcnv9Hylu16Nq bJE5kCtL7Oduz0xAF41PjM98PisP+QwbLfEa/Ty6NY3BAoijBZBCpmcokMedtLOT98rpuNpjUcO rQG5RK7BD1oywO1JpkKbxKrIWMgQXWuMKqTBAFzLs X-Received: by 2002:a17:90b:1c07:: with SMTP id oc7mr761878pjb.127.1638297060128; Tue, 30 Nov 2021 10:31:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwokwLTGQm+ed4L+zIBqkZ9Zq7xAbl2PIcgN9DJqdGrPdyz9TTC94z21GNO0COfedaPxy/1fQ== X-Received: by 2002:a17:90b:1c07:: with SMTP id oc7mr761827pjb.127.1638297059722; Tue, 30 Nov 2021 10:30:59 -0800 (PST) Received: from canonical.com (node-1w7jr9yebujeq5th4a1ypme3f.ipv6.telus.net. [2001:56a:78ed:fb00::1db]) by smtp.gmail.com with ESMTPSA id y7sm15191195pge.44.2021.11.30.10.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 10:30:59 -0800 (PST) From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH 1/2] s3: fix incorrect error messages for s2idle_residency Date: Tue, 30 Nov 2021 11:30:56 -0700 Message-Id: <20211130183057.174890-1-alex.hung@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" Signed-off-by: Alex Hung Acked-by: Ivan Hu --- src/acpi/s3/s3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c index d77108a1..c619d30d 100644 --- a/src/acpi/s3/s3.c +++ b/src/acpi/s3/s3.c @@ -388,7 +388,7 @@ static int s3_do_suspend_resume(fwts_framework *fw, (*s2idle_errors)++; fwts_failed(fw, LOG_LEVEL_HIGH, "S2idleNotDeepest", "Expected %s to increase from %" PRIu32 ", got %" PRIu32 ".", - PM_S2IDLE_SLP_S0, residency, *s2idle_residency); + PM_S2IDLE_SLP_S0, *s2idle_residency, residency); } *s2idle_residency = residency; }