From patchwork Wed Sep 22 08:11:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 1531103 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=J5N02tfk; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4HDrcB2mWTz9sVq for ; Wed, 22 Sep 2021 18:11:54 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mSxM6-0002tB-Ns; Wed, 22 Sep 2021 08:11:50 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mSxM6-0002t5-40 for fwts-devel@lists.ubuntu.com; Wed, 22 Sep 2021 08:11:50 +0000 Received: from localhost (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 0AE9C3F35F; Wed, 22 Sep 2021 08:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632298309; bh=KcwkfYU81jeJ3zQwsAN+BL7E8T/sHNFxyFjbeEPyfmI=; h=From:To:Subject:Date:Message-Id:MIME-Version:Content-Type; b=J5N02tfkJI8pRvpEjEiag4D/5y7j+BPsZmk13Bw9xtFbJHYYCDP8unrJbtFlCeYmH 8A9bYeV6YKsmpAw8aDrBz3eYITKZ3+6/rNEuzeacgu3ZDVZ9Ix40TB7SxOy3eHVQBm m+ZWui62ZvFUYGA94IPnbfNEK/0dXSuTThftKT2xoqH7NsXjQtWK07uNLXRAWu6bNx w+n06xASQ4/W9lh00QQSUmVrCp3SHAOMduQIeRMyG4cYYy7M+h1ZfmLh2wqnq3PRYv ER0fCtO3k1ai6iZsN1MN850aNyYFFYNgsc0kYhOwDqak9hb3fML9p3jEkhYmdNWxdv XEKWsmy+3WbXg== From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] fwts_acpi_tables: NULLify table pointers Date: Wed, 22 Sep 2021 09:11:48 +0100 Message-Id: <20210922081148.38093-1-colin.king@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Colin Ian King Clear up some overly pedantic coverity warnings that seem to be false positives but it's good practice to initialize the pointers anyhow. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/lib/src/fwts_acpi_tables.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c index 9f12539f..79f019a2 100644 --- a/src/lib/src/fwts_acpi_tables.c +++ b/src/lib/src/fwts_acpi_tables.c @@ -300,7 +300,7 @@ int fwts_acpi_free_tables(void) */ fwts_bool fwts_acpi_is_reduced_hardware(fwts_framework *fw) { - fwts_acpi_table_info *table; + fwts_acpi_table_info *table = NULL; const fwts_acpi_table_fadt *fadt; if (fwts_acpi_find_table(fw, "FACP", 0, &table) != FWTS_OK) { @@ -969,7 +969,7 @@ void fwts_acpi_fixup_addr_from_fadt( uint32_t addr32, uint64_t addr64) { - fwts_acpi_table_info *table; + fwts_acpi_table_info *table = NULL; /* Fetch the table */ if (fwts_acpi_find_table(fw, name, 0, &table) != FWTS_OK) @@ -999,7 +999,7 @@ static int fwts_acpi_load_tables_fixup(fwts_framework *fw) { int i, j, count; char *oem_tbl_id; - fwts_acpi_table_info *table; + fwts_acpi_table_info *table = NULL; fwts_acpi_table_rsdp *rsdp = NULL; fwts_acpi_table_fadt *fadt = NULL; uint64_t rsdt_fake_addr = 0, xsdt_fake_addr = 0;