diff mbox series

lib: use <poll.h> rather than <sys/poll.h>

Message ID 20210912001529.118983-1-colin.king@canonical.com
State Accepted
Headers show
Series lib: use <poll.h> rather than <sys/poll.h> | expand

Commit Message

Colin Ian King Sept. 12, 2021, 12:15 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Should be using poll.h, fixes musl C builds and is the correct
way to pick up the poll definitions.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_ipmi.c   | 2 +-
 src/lib/src/fwts_pipeio.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

ivanhu Sept. 13, 2021, 4:07 a.m. UTC | #1 
On 9/12/21 8:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Should be using poll.h, fixes musl C builds and is the correct
> way to pick up the poll definitions.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_ipmi.c   | 2 +-
>  src/lib/src/fwts_pipeio.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lib/src/fwts_ipmi.c b/src/lib/src/fwts_ipmi.c
> index ca7c55bb..9809651e 100644
> --- a/src/lib/src/fwts_ipmi.c
> +++ b/src/lib/src/fwts_ipmi.c
> @@ -21,7 +21,7 @@
>  #include <sys/types.h>
>  #include <sys/stat.h>
>  #include <fcntl.h>
> -#include <sys/poll.h>
> +#include <poll.h>
>  #include <sys/ioctl.h>
>  #include <linux/ipmi.h>
>  
> diff --git a/src/lib/src/fwts_pipeio.c b/src/lib/src/fwts_pipeio.c
> index 716297c4..f0a49917 100644
> --- a/src/lib/src/fwts_pipeio.c
> +++ b/src/lib/src/fwts_pipeio.c
> @@ -32,7 +32,7 @@
>  #include <paths.h>
>  
>  #include <sys/param.h>
> -#include <sys/poll.h>
> +#include <poll.h>
>  #include <sys/types.h>
>  #include <sys/wait.h>
>  #include <errno.h>
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Alex Hung Sept. 17, 2021, 5:53 p.m. UTC | #2 
On 2021-09-11 6:15 p.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Should be using poll.h, fixes musl C builds and is the correct
> way to pick up the poll definitions.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_ipmi.c   | 2 +-
>  src/lib/src/fwts_pipeio.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lib/src/fwts_ipmi.c b/src/lib/src/fwts_ipmi.c
> index ca7c55bb..9809651e 100644
> --- a/src/lib/src/fwts_ipmi.c
> +++ b/src/lib/src/fwts_ipmi.c
> @@ -21,7 +21,7 @@
>  #include <sys/types.h>
>  #include <sys/stat.h>
>  #include <fcntl.h>
> -#include <sys/poll.h>
> +#include <poll.h>
>  #include <sys/ioctl.h>
>  #include <linux/ipmi.h>
>  
> diff --git a/src/lib/src/fwts_pipeio.c b/src/lib/src/fwts_pipeio.c
> index 716297c4..f0a49917 100644
> --- a/src/lib/src/fwts_pipeio.c
> +++ b/src/lib/src/fwts_pipeio.c
> @@ -32,7 +32,7 @@
>  #include <paths.h>
>  
>  #include <sys/param.h>
> -#include <sys/poll.h>
> +#include <poll.h>
>  #include <sys/types.h>
>  #include <sys/wait.h>
>  #include <errno.h>
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
diff mbox series

Patch

diff --git a/src/lib/src/fwts_ipmi.c b/src/lib/src/fwts_ipmi.c
index ca7c55bb..9809651e 100644
--- a/src/lib/src/fwts_ipmi.c
+++ b/src/lib/src/fwts_ipmi.c
@@ -21,7 +21,7 @@ 
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
-#include <sys/poll.h>
+#include <poll.h>
 #include <sys/ioctl.h>
 #include <linux/ipmi.h>
 
diff --git a/src/lib/src/fwts_pipeio.c b/src/lib/src/fwts_pipeio.c
index 716297c4..f0a49917 100644
--- a/src/lib/src/fwts_pipeio.c
+++ b/src/lib/src/fwts_pipeio.c
@@ -32,7 +32,7 @@ 
 #include <paths.h>
 
 #include <sys/param.h>
-#include <sys/poll.h>
+#include <poll.h>
 #include <sys/types.h>
 #include <sys/wait.h>
 #include <errno.h>