From patchwork Fri Aug 6 17:36:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1514451 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=pKrvLOom; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GhCMR4lcvz9s24 for ; Sat, 7 Aug 2021 03:36:34 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mC3ll-0004bg-II; Fri, 06 Aug 2021 17:36:29 +0000 Received: from smtp-relay-canonical-1.internal ([10.131.114.174] helo=smtp-relay-canonical-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mC3lk-0004bU-0m for fwts-devel@lists.ubuntu.com; Fri, 06 Aug 2021 17:36:28 +0000 Received: from canonical.com (d104-157-108-141.abhsia.telus.net [104.157.108.141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 411BE3F101; Fri, 6 Aug 2021 17:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628271387; bh=80alTjrkmjrWzbIw6BQFkhs7KUT31z8eopwtpV0Ch2Y=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pKrvLOomo3Wd1h0BQv/fv8ulvZoh/nWWpLdwVorawlkzTb5YWv4qBbStM9i6FQawa bOUAAXGk9Bijyipre+nBjqoGBZI1ae8IcvKYei6KwazdR+YZGqa15aP8tKijtI4l1G SW/tVGNtU5oT5dfX0hQLHAJgzyoVngsgZZRj+gxAHKnfu7hfoVp4/9cEJiwdS6J7Le h0IljM9orEQNL09kt+lyykdgrrFztd0e3eIbm2fv3XqIW5DlI9sjhoXSFQLDT9b7Bh Zq0MBi28x++Oqc8cq5dtTBbRSlSg5C3iD6gQqRNsOJZvNBbzNhZr0XVswYdGTvcOkO cTR7o0SsjQNOw== From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH][V2] acpi: dmar: add a warning when PCI device is not found Date: Fri, 6 Aug 2021 11:36:22 -0600 Message-Id: <20210806173622.1978360-1-alex.hung@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" BugLink: https://bugs.launchpad.net/bugs/1936458 Signed-off-by: Alex Hung Acked-by: Colin Ian King Acked-by: Ivan Hu --- [V2] Add PCI SEG:BUS:DEV:FUNC to the warning message. src/acpi/dmar/dmar.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/acpi/dmar/dmar.c b/src/acpi/dmar/dmar.c index af9ee277..5b06c8c7 100644 --- a/src/acpi/dmar/dmar.c +++ b/src/acpi/dmar/dmar.c @@ -166,8 +166,11 @@ static int acpi_parse_one_dev_scope(fwts_framework *fw, goto error; dev_type = read_pci_device_secondary_bus_number(seg, bus, path->dev, path->fn, &sec_bus); - if (dev_type < 0) /* no such device */ + if (dev_type < 0) { /* no such device */ + fwts_warning(fw, "PCI device %04Xh:%02Xh:%02Xh.%02Xh is not found.", + seg, bus, path->dev, path->fn); goto error; + } path++; count--; bus = sec_bus;