From patchwork Wed Jun 30 05:45:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grzegorz Bernacki X-Patchwork-Id: 1498737 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=heddDzYz; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GF9Ll5tjvz9sWl for ; Wed, 30 Jun 2021 15:46:06 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lyT2v-0003My-3A; Wed, 30 Jun 2021 05:46:01 +0000 Received: from mail-lj1-f172.google.com ([209.85.208.172]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lyT2t-0003Mj-Jb for fwts-devel@lists.ubuntu.com; Wed, 30 Jun 2021 05:45:59 +0000 Received: by mail-lj1-f172.google.com with SMTP id x20so1586150ljc.5 for ; Tue, 29 Jun 2021 22:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fVXJhzwhZX+Uixq+VworBcMqbWQ3Nx/xcQPq4lX+CHc=; b=heddDzYzMsyca7Es11sNCmfpvCrMWSwqgXp7JH2RycdcC9VNpkbb4FaE4DKvkyVImr UVuLqzX9xllaqPTbing77MCN95qJno00BipDb0+vEj2uXCy0iDvGwqxcNGLmxEBRPn3s eNX43nOh6s1Q5gBr/hMg8Y/11VQHh35r8qjvI0icahBElLf+PW05UUQPMhPOZhMR38hd 9ctNvi9vKph49xTp2tLBJ4mxxJCe9H+CXYbakxVm761SNF5Z8iKAuzZRhIbuMzMPpCBF eoD0lUJ8IgjkslML0QdzZO9AzcsJTG5LtwqNFhdPOsmxVGFBZth4H8kuFA88sK/cx9TV bBAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fVXJhzwhZX+Uixq+VworBcMqbWQ3Nx/xcQPq4lX+CHc=; b=gi+QM5l41nBZ16hJ67UNVj0wPLz9esSk3IB4lVDMEGvXLUMfTrTdLY3IdCoeV+STNa ODbmggxU9aGUOzwoDHlLOTGtzbM5BUhmcasDKkKjr2uEiPa7UQylf9yrtLT8SJ3xVrT5 1P8sD1UFlnj7vykjQluu9UnN52ig2F5ZBjNi734h6T39ySSMr/wxcYHGXpxqEmqP5hrY A2d3M+gwb1jN3eIU/659i9c9hvpUQBrSajPMQU1QfevdLw7hLkXIMwj4Yjw8udZCNWKN +1W4/5Iv6tppFI40pJvVDaxldGvk+0ALwjt+NW73Z0B7YG5dJu5I9UIw8otH2/W+H6FS ADJw== X-Gm-Message-State: AOAM530hmF1yGFWRUuyCCMa+/ZtDtaMj0f5yzSksc0Ilqnl/4EMPSCr4 6A8c9NUYgh6hEAi/JNKHzdm+4iHBwFQcIA== X-Google-Smtp-Source: ABdhPJwwQDaTe+dGdkRv5HB3p+Fn4Qas0SjY8/Tl13FeAwN9k/bQOrekDsojTUfYDxMLYCjrfKpaRQ== X-Received: by 2002:a2e:bf21:: with SMTP id c33mr6642009ljr.28.1625031958656; Tue, 29 Jun 2021 22:45:58 -0700 (PDT) Received: from gilgamesh.lab.semihalf.net ([83.142.187.85]) by smtp.gmail.com with ESMTPSA id d29sm1179946lfv.20.2021.06.29.22.45.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 22:45:58 -0700 (PDT) From: Grzegorz Bernacki To: fwts-devel@lists.ubuntu.com Subject: [PATCH v2] acpi: method: Make method_test_ADR() optional. Date: Wed, 30 Jun 2021 07:45:43 +0200 Message-Id: <20210630054545.959797-1-gjb@semihalf.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samer.El-Haj-Mahmoud@arm.com, upstream@semihalf.com Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" According to ACPI specification _ADR is not required if _HID exists for given device. This test focus on testing returning value of _ADR, not the existence of _ADR, that's why it should not be mandatory. BugLink: https://bugs.launchpad.net/fwts/+bug/1933493 Signed-off-by: Grzegorz Bernacki Acked-by: Alex Hung Acked-by: Colin Ian King --- src/acpi/method/method.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index 9832c4e1..9200f7d4 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -4340,12 +4340,8 @@ static int method_test_VPO(fwts_framework *fw) static int method_test_ADR(fwts_framework *fw) { - if (fw->flags & FWTS_FLAG_SBBR) - return method_evaluate_method(fw, METHOD_MANDATORY, - "_ADR", NULL, 0, fwts_method_test_integer_return, NULL); - else - return method_evaluate_method(fw, METHOD_OPTIONAL, - "_ADR", NULL, 0, fwts_method_test_integer_return, NULL); + return method_evaluate_method(fw, METHOD_OPTIONAL, + "_ADR", NULL, 0, fwts_method_test_integer_return, NULL); } static void method_test_BCL_return(