From patchwork Tue Jun 29 10:10:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grzegorz Bernacki X-Patchwork-Id: 1498273 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=v6rmiL0M; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GDgH43Btfz9sWD for ; Tue, 29 Jun 2021 20:11:12 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lyAhx-0002as-JN; Tue, 29 Jun 2021 10:11:09 +0000 Received: from mail-lf1-f48.google.com ([209.85.167.48]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lyAhw-0002ac-G1 for fwts-devel@lists.ubuntu.com; Tue, 29 Jun 2021 10:11:08 +0000 Received: by mail-lf1-f48.google.com with SMTP id k10so38456715lfv.13 for ; Tue, 29 Jun 2021 03:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YoR6tpJ40LNdODqouug8XTIjf/mOfSixOkZ6m/qqfJw=; b=v6rmiL0MbgEzNSY2QqyPs3uihlCkgVRdV0k99JDxPiyu+x0NJ3eZFnL6N0pruxARzk of0udONpZ2Z6Ga7jq62CAsU3MBOAX8qmYxtqgXde1xiXzXSeHhkokIDcKz0wkhG7HgFa or1RoCA23HHy6/iaxL47pQSCBtvO7L6mxUtxXJrBRmrNa3zZKbER4z1PYhz3DggPs4Xu yOFM1nJr95991Bn3vsUMYrWV5chHVKhJdMePZpMGLs8fmJnWyehcY12LEb0AgxqpBuhS ds4EVUNkhuRj6b2i21jvU0E5ueJvvk+T/TXvnRMUIJ8VwUFvaoiyGybxbD5QZnHOiqNT guLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YoR6tpJ40LNdODqouug8XTIjf/mOfSixOkZ6m/qqfJw=; b=t66gTCBwuyx2KVQag+jrKwFEIc/KRfqYND1iwCzOS8HYzQ5XSbDV6X55ELvEbGv5xg Gs5HQe3G6iIZj0II6RzpA4Huoyl80+6pohNAuD0eNGCRlZKxHuq5FRUfbYGe0C/mDjlG NJwXoezSFcz5v/q/TIUvnOf1QY1UekwzcZyabSRjoLfkQ13yglQ4PPFsZH7My2wKmq8c SzW0Mw2/7hEEfw7PyhfuzxB6BO2LPG2/jnOxBoUQrCvx2JTm5G8Cn4XRunX032Xyr8FA egL5+YxcsBGlYkZj/VIIq3VuzemRvv9NdKN2cifGH6DQ0VdL/cN8G/90d0cf+ieVKAUB Zo6Q== X-Gm-Message-State: AOAM531TerDlkikYwyTcALQUKY+Wg39LhZsW9tSKOPYxgU/A1LXYftS1 25ocgahcdJgXEraTt/ReNatUsD9BJ3ABeLaj X-Google-Smtp-Source: ABdhPJzifQFnhNe3FA/KWARcThvH0PzGnXohxRf9ORRtjOMlIjklhIh9VTsJHw0mTnXNRULsLCESLg== X-Received: by 2002:a19:790a:: with SMTP id u10mr20769765lfc.9.1624961467715; Tue, 29 Jun 2021 03:11:07 -0700 (PDT) Received: from gilgamesh.lab.semihalf.net ([83.142.187.85]) by smtp.gmail.com with ESMTPSA id h63sm1707368lfd.200.2021.06.29.03.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 03:11:07 -0700 (PDT) From: Grzegorz Bernacki To: fwts-devel@lists.ubuntu.com Subject: [PATCH] sbbr: Allow 16550 compatible serial port in DBG2 Date: Tue, 29 Jun 2021 12:10:47 +0200 Message-Id: <20210629101048.933733-2-gjb@semihalf.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20210629101048.933733-1-gjb@semihalf.com> References: <20210629101048.933733-1-gjb@semihalf.com> MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samer.El-Haj-Mahmoud@arm.com, upstream@semihalf.com Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" BSA 1.0 specification allow the serial port to be either Arm SBSA Generic UART, PL011, or 16550. This patch adds checking for 16550 port type. BugLink: https://bugs.launchpad.net/fwts/+bug/1932567 Signed-off-by: Grzegorz Bernacki Acked-by: Alex Hung --- src/acpi/dbg2/dbg2.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/acpi/dbg2/dbg2.c b/src/acpi/dbg2/dbg2.c index 6004dc61..ad2b7d62 100644 --- a/src/acpi/dbg2/dbg2.c +++ b/src/acpi/dbg2/dbg2.c @@ -28,9 +28,12 @@ #include "fwts_acpi_object_eval.h" -#define SBBR_DBG2_PORT_SERIAL 0x8000 -#define SBBR_DBG2_ARM_SBSA_UART 0x000E -#define SBBR_DBG2_ARM_PL011_UART 0x0003 +#define SBBR_DBG2_PORT_SERIAL 0x8000 +#define SBBR_DBG2_FULLY_16550_COMPAT 0x0000 +#define SBBR_DBG2_16550_SUBSET_COMPAT 0x0001 +#define SBBR_DBG2_ARM_PL011_UART 0x0003 +#define SBBR_DBG2_ARM_SBSA_UART 0x000E +#define SBBR_DBG2_16550_COMPAT_GAS 0x0012 static fwts_acpi_table_info *table; acpi_table_init(DBG2, &table) @@ -53,8 +56,11 @@ static int dbg2_test2(fwts_framework *fw) if (((uint8_t*)info + info->length) >= ((uint8_t*)table + table->length)) break; if (info->port_type == SBBR_DBG2_PORT_SERIAL && - (info->port_subtype == SBBR_DBG2_ARM_SBSA_UART || - info->port_subtype == SBBR_DBG2_ARM_PL011_UART)) { + (info->port_subtype == SBBR_DBG2_FULLY_16550_COMPAT || + info->port_subtype == SBBR_DBG2_16550_SUBSET_COMPAT || + info->port_subtype == SBBR_DBG2_ARM_PL011_UART || + info->port_subtype == SBBR_DBG2_ARM_SBSA_UART || + info->port_subtype == SBBR_DBG2_16550_COMPAT_GAS)) { fwts_passed(fw, "DBG2 provides a standard serial debug " "port and describes ARM SBSA Generic UART");