| Message ID | 20210618125710.280797-6-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Debian lintian cleanups | expand |
On 2021-06-18 6:57 a.m., Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Clean up lintian warning, add Homepage There is no Homepage in the patch (but in PATCH 4/5). Is this a typo? I can fix this when applying though. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > debian/control | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/debian/control b/debian/control > index 29d3c40f..6f05a93b 100644 > --- a/debian/control > +++ b/debian/control > @@ -1,6 +1,7 @@ > Source: fwts > Section: devel > Priority: optional > +Rules-Requires-Root: no > Maintainer: Firmware Testing Team <fwts-devel@lists.ubuntu.com> > Uploaders: Colin King <colin.king@ubuntu.com>, Alex Hung <alex.hung@canonical.com>, Ivan Hu <ivan.hu@canonical.com> > Standards-Version: 3.9.7 > Acked-by: Alex Hung <alex.hung@canonical.com>
On 18/06/2021 21:02, Alex Hung wrote: > On 2021-06-18 6:57 a.m., Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Clean up lintian warning, add Homepage bah, typo should be add Rules-Requires-root. Can that be reworked before applying it? > > There is no Homepage in the patch (but in PATCH 4/5). Is this a typo? > > I can fix this when applying though. > >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> debian/control | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/debian/control b/debian/control >> index 29d3c40f..6f05a93b 100644 >> --- a/debian/control >> +++ b/debian/control >> @@ -1,6 +1,7 @@ >> Source: fwts >> Section: devel >> Priority: optional >> +Rules-Requires-Root: no >> Maintainer: Firmware Testing Team <fwts-devel@lists.ubuntu.com> >> Uploaders: Colin King <colin.king@ubuntu.com>, Alex Hung <alex.hung@canonical.com>, Ivan Hu <ivan.hu@canonical.com> >> Standards-Version: 3.9.7 >> > > Acked-by: Alex Hung <alex.hung@canonical.com> >
On Fri, Jun 18, 2021 at 4:06 PM Colin Ian King <colin.king@canonical.com> wrote: > On 18/06/2021 21:02, Alex Hung wrote: > > On 2021-06-18 6:57 a.m., Colin King wrote: > >> From: Colin Ian King <colin.king@canonical.com> > >> > >> Clean up lintian warning, add Homepage > > bah, typo should be add Rules-Requires-root. Can that be reworked before > applying it? > Sure I can do that. > > > > > There is no Homepage in the patch (but in PATCH 4/5). Is this a typo? > > > > I can fix this when applying though. > > > >> > >> Signed-off-by: Colin Ian King <colin.king@canonical.com> > >> --- > >> debian/control | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/debian/control b/debian/control > >> index 29d3c40f..6f05a93b 100644 > >> --- a/debian/control > >> +++ b/debian/control > >> @@ -1,6 +1,7 @@ > >> Source: fwts > >> Section: devel > >> Priority: optional > >> +Rules-Requires-Root: no > >> Maintainer: Firmware Testing Team <fwts-devel@lists.ubuntu.com> > >> Uploaders: Colin King <colin.king@ubuntu.com>, Alex Hung < > alex.hung@canonical.com>, Ivan Hu <ivan.hu@canonical.com> > >> Standards-Version: 3.9.7 > >> > > > > Acked-by: Alex Hung <alex.hung@canonical.com> > > > >
On 6/18/21 8:57 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Clean up lintian warning, add Homepage > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > debian/control | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/debian/control b/debian/control > index 29d3c40f..6f05a93b 100644 > --- a/debian/control > +++ b/debian/control > @@ -1,6 +1,7 @@ > Source: fwts > Section: devel > Priority: optional > +Rules-Requires-Root: no > Maintainer: Firmware Testing Team <fwts-devel@lists.ubuntu.com> > Uploaders: Colin King <colin.king@ubuntu.com>, Alex Hung <alex.hung@canonical.com>, Ivan Hu <ivan.hu@canonical.com> > Standards-Version: 3.9.7 > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/debian/control b/debian/control index 29d3c40f..6f05a93b 100644 --- a/debian/control +++ b/debian/control @@ -1,6 +1,7 @@ Source: fwts Section: devel Priority: optional +Rules-Requires-Root: no Maintainer: Firmware Testing Team <fwts-devel@lists.ubuntu.com> Uploaders: Colin King <colin.king@ubuntu.com>, Alex Hung <alex.hung@canonical.com>, Ivan Hu <ivan.hu@canonical.com> Standards-Version: 3.9.7