| Message ID | 20210604051117.428840-3-alex.hung@canonical.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] sbbr: add checks for mandatory tables | expand |
On 6/4/21 1:11 PM, Alex Hung wrote: > This is based on 5.2 of Arm Server Base Boot Requirements (SBBR) 1.2 > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/dmi/dmicheck/dmicheck.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c > index fa685414..1795f5f5 100644 > --- a/src/dmi/dmicheck/dmicheck.c > +++ b/src/dmi/dmicheck/dmicheck.c > @@ -2105,6 +2105,7 @@ static sbbr_test_entry sbbr_test[] = { > { "System Boot Information", 32, 1, 0, 0 }, > { "IPMI Device Information", 38, 0, "Required for platforms with IPMI BMC Interface.", 0 }, > { "Onboard Devices Extended Information", 41, 0, RECOMMENDED_STRUCTURE_DEFAULT_MSG, 0 }, > + { "Redfish Host Interface", 42, 0, "Required for platforms supporting Redfish Host Interface[8].", 0 }, > { 0, 0, 0, 0, 0 } > }; > > Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 04/06/2021 06:11, Alex Hung wrote: > This is based on 5.2 of Arm Server Base Boot Requirements (SBBR) 1.2 > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/dmi/dmicheck/dmicheck.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c > index fa685414..1795f5f5 100644 > --- a/src/dmi/dmicheck/dmicheck.c > +++ b/src/dmi/dmicheck/dmicheck.c > @@ -2105,6 +2105,7 @@ static sbbr_test_entry sbbr_test[] = { > { "System Boot Information", 32, 1, 0, 0 }, > { "IPMI Device Information", 38, 0, "Required for platforms with IPMI BMC Interface.", 0 }, > { "Onboard Devices Extended Information", 41, 0, RECOMMENDED_STRUCTURE_DEFAULT_MSG, 0 }, > + { "Redfish Host Interface", 42, 0, "Required for platforms supporting Redfish Host Interface[8].", 0 }, > { 0, 0, 0, 0, 0 } > }; > > What's the [8] for in the Interface[8] text?
On Mon, Jun 14, 2021 at 11:32 AM Colin Ian King <colin.king@canonical.com> wrote: > On 04/06/2021 06:11, Alex Hung wrote: > > This is based on 5.2 of Arm Server Base Boot Requirements (SBBR) 1.2 > > > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > > --- > > src/dmi/dmicheck/dmicheck.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c > > index fa685414..1795f5f5 100644 > > --- a/src/dmi/dmicheck/dmicheck.c > > +++ b/src/dmi/dmicheck/dmicheck.c > > @@ -2105,6 +2105,7 @@ static sbbr_test_entry sbbr_test[] = { > > { "System Boot Information", 32, 1, 0, 0 }, > > { "IPMI Device Information", 38, 0, "Required for platforms with > IPMI BMC Interface.", 0 }, > > { "Onboard Devices Extended Information", 41, 0, > RECOMMENDED_STRUCTURE_DEFAULT_MSG, 0 }, > > + { "Redfish Host Interface", 42, 0, "Required for platforms > supporting Redfish Host Interface[8].", 0 }, > > { 0, 0, 0, 0, 0 } > > }; > > > > > > What's the [8] for in the Interface[8] text? > I thought it was part of the string written in the SBBR document, but it is in fact a link to a reference in SBBR. I will send V2 to exclude the [8].
diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index fa685414..1795f5f5 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -2105,6 +2105,7 @@ static sbbr_test_entry sbbr_test[] = { { "System Boot Information", 32, 1, 0, 0 }, { "IPMI Device Information", 38, 0, "Required for platforms with IPMI BMC Interface.", 0 }, { "Onboard Devices Extended Information", 41, 0, RECOMMENDED_STRUCTURE_DEFAULT_MSG, 0 }, + { "Redfish Host Interface", 42, 0, "Required for platforms supporting Redfish Host Interface[8].", 0 }, { 0, 0, 0, 0, 0 } };
This is based on 5.2 of Arm Server Base Boot Requirements (SBBR) 1.2 Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/dmi/dmicheck/dmicheck.c | 1 + 1 file changed, 1 insertion(+)