| Message ID | 20210420015249.181241-1-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] oops: add "kernel BUG" to oops test | expand |
On 20/04/2021 02:52, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/lib/src/fwts_oops.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/lib/src/fwts_oops.c b/src/lib/src/fwts_oops.c > index 6221f93e..860df92d 100644 > --- a/src/lib/src/fwts_oops.c > +++ b/src/lib/src/fwts_oops.c > @@ -57,6 +57,8 @@ static void fwts_klog_stack_dump( > > if (strstr(line, "Oops:")) > dumpable |= FWTS_OOPS_GOT_OOPS; > + if (strstr(line, "kernel BUG at")) > + dumpable |= FWTS_OOPS_GOT_OOPS; > if (strstr(line, "WARNING: at")) > dumpable |= FWTS_OOPS_GOT_WARN_ON; > if (strstr(line, "Call Trace:")) > @@ -129,6 +131,7 @@ int fwts_oops_check(fwts_framework *fw, fwts_list *klog, int *oopses, int *warn_ > fwts_list_foreach(item, klog) { > char *line = fwts_klog_remove_timestamp(fwts_list_data(char *, item)); > if ((strncmp("BUG:", line, 4) == 0) || > + (strncmp("kernel BUG", line, 10) == 0) || > (strncmp("WARNING:", line, 8) == 0)) > fwts_klog_stack_dump(fw, item, oopses, warn_ons); > } > Acked-by: Colin Ian King <colin.king@canonical.com>
On 4/20/21 9:52 AM, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/lib/src/fwts_oops.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/lib/src/fwts_oops.c b/src/lib/src/fwts_oops.c > index 6221f93e..860df92d 100644 > --- a/src/lib/src/fwts_oops.c > +++ b/src/lib/src/fwts_oops.c > @@ -57,6 +57,8 @@ static void fwts_klog_stack_dump( > > if (strstr(line, "Oops:")) > dumpable |= FWTS_OOPS_GOT_OOPS; > + if (strstr(line, "kernel BUG at")) > + dumpable |= FWTS_OOPS_GOT_OOPS; > if (strstr(line, "WARNING: at")) > dumpable |= FWTS_OOPS_GOT_WARN_ON; > if (strstr(line, "Call Trace:")) > @@ -129,6 +131,7 @@ int fwts_oops_check(fwts_framework *fw, fwts_list *klog, int *oopses, int *warn_ > fwts_list_foreach(item, klog) { > char *line = fwts_klog_remove_timestamp(fwts_list_data(char *, item)); > if ((strncmp("BUG:", line, 4) == 0) || > + (strncmp("kernel BUG", line, 10) == 0) || > (strncmp("WARNING:", line, 8) == 0)) > fwts_klog_stack_dump(fw, item, oopses, warn_ons); > } > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/lib/src/fwts_oops.c b/src/lib/src/fwts_oops.c index 6221f93e..860df92d 100644 --- a/src/lib/src/fwts_oops.c +++ b/src/lib/src/fwts_oops.c @@ -57,6 +57,8 @@ static void fwts_klog_stack_dump( if (strstr(line, "Oops:")) dumpable |= FWTS_OOPS_GOT_OOPS; + if (strstr(line, "kernel BUG at")) + dumpable |= FWTS_OOPS_GOT_OOPS; if (strstr(line, "WARNING: at")) dumpable |= FWTS_OOPS_GOT_WARN_ON; if (strstr(line, "Call Trace:")) @@ -129,6 +131,7 @@ int fwts_oops_check(fwts_framework *fw, fwts_list *klog, int *oopses, int *warn_ fwts_list_foreach(item, klog) { char *line = fwts_klog_remove_timestamp(fwts_list_data(char *, item)); if ((strncmp("BUG:", line, 4) == 0) || + (strncmp("kernel BUG", line, 10) == 0) || (strncmp("WARNING:", line, 8) == 0)) fwts_klog_stack_dump(fw, item, oopses, warn_ons); }
Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/lib/src/fwts_oops.c | 3 +++ 1 file changed, 3 insertions(+)