From patchwork Wed Jun 10 00:40:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1306344 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49hSnt1LXlz9sRW; Wed, 10 Jun 2020 10:40:32 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jion5-0005FS-RW; Wed, 10 Jun 2020 00:40:27 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jion3-0005FG-Ky for fwts-devel@lists.ubuntu.com; Wed, 10 Jun 2020 00:40:25 +0000 Received: from 2.general.alexhung.us.vpn ([10.172.65.255] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jion3-0001Pf-0q; Wed, 10 Jun 2020 00:40:25 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH] cpu/msr: remove General Performance Counters Date: Tue, 9 Jun 2020 18:40:22 -0600 Message-Id: <20200610004022.177152-1-alex.hung@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" The registers are specific to a core, not a cpu package. Signed-off-by: Alex Hung Acked-by: Ivan Hu Acked-by: Colin Ian King --- src/cpu/msr/msr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu/msr/msr.c b/src/cpu/msr/msr.c index 17864c0b..3a8722c2 100644 --- a/src/cpu/msr/msr.c +++ b/src/cpu/msr/msr.c @@ -454,10 +454,13 @@ static const msr_info IA32_MSRs[] = { { "VMX_TRUE_EXIT_CTLS", 0x0000048f, 0xffffffffffffffffULL, NULL }, { "VMX_TRUE_ENTRY_CTLS", 0x00000490, 0xffffffffffffffffULL, NULL }, { "VMX_VMFUNC", 0x00000491, 0xffffffffffffffffULL, NULL }, + /* Do not check syscall MSRs, they will be different on + * each CPU, so checking them across CPUs is incorrect { "A_PMC4", 0x000004c5, 0xffffffffffffffffULL, NULL }, { "A_PMC5", 0x000004c6, 0xffffffffffffffffULL, NULL }, { "A_PMC6", 0x000004c7, 0xffffffffffffffffULL, NULL }, { "A_PMC7", 0x000004c8, 0xffffffffffffffffULL, NULL }, + */ { "EFER", 0xc0000080, 0x0000000000000d01ULL, NULL }, /* Do not check syscall MSRs, they will be different on * each CPU, so checking them across CPUs is incorrect