From patchwork Tue Apr 7 00:52:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1267118 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48x85b728yz9sQx; Tue, 7 Apr 2020 10:52:51 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1jLcTx-0008IT-EK; Tue, 07 Apr 2020 00:52:49 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jLcTs-0008I7-W7 for fwts-devel@lists.ubuntu.com; Tue, 07 Apr 2020 00:52:44 +0000 Received: from 2.general.alexhung.us.vpn ([10.172.65.255] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jLcTs-0005jV-Az; Tue, 07 Apr 2020 00:52:44 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH 1/4] dmicheck: update system slot type (type 9) Date: Mon, 6 Apr 2020 18:52:34 -0600 Message-Id: <20200407005237.145347-2-alex.hung@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200407005237.145347-1-alex.hung@canonical.com> References: <20200407005237.145347-1-alex.hung@canonical.com> MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" New types (PCI Express Gen 4) was added in SMBIOS spec 3.3.0 Signed-off-by: Alex Hung Acked-by: Colin Ian King Acked-by: Ivan Hu --- src/dmi/dmicheck/dmicheck.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index feac3693..e96b2416 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -1427,10 +1427,10 @@ static void dmicheck_entry(fwts_framework *fw, break; dmi_str_check(fw, table, addr, "Slot Designation", hdr, 0x4); if (!(((data[0x5] >= 0x01) && (data[0x5] <= 0x23)) || - ((data[0x5] >= 0xa0) && (data[0x5] <= 0xb6)))) + ((data[0x5] >= 0xa0) && (data[0x5] <= 0xbd)))) fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE, "Out of range value 0x%2.2" PRIx8 " " - "(range allowed 0x01..0x23, 0xa0..0xb6) " + "(range allowed 0x01..0x23, 0xa0..0xbd) " "while accessing entry '%s' @ 0x%8.8" PRIx32 ", " "field '%s', offset 0x%2.2x", data[0x5], table, addr, "Slot Type", 0x5);