From patchwork Thu Nov 7 07:46:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Hu X-Patchwork-Id: 1190949 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 477wTN1hrmzB3x2; Thu, 7 Nov 2019 18:46:47 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1iScVA-0006cU-MI; Thu, 07 Nov 2019 07:46:44 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iScV9-0006bh-3X for fwts-devel@lists.ubuntu.com; Thu, 07 Nov 2019 07:46:43 +0000 Received: from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iScV8-0000bf-DT; Thu, 07 Nov 2019 07:46:42 +0000 From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH 3/5 V2] uefirttime: add unsupported checking with RuntimeServicesSupported variable Date: Thu, 7 Nov 2019 15:46:31 +0800 Message-Id: <1573112794-4284-2-git-send-email-ivan.hu@canonical.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1573112794-4284-1-git-send-email-ivan.hu@canonical.com> References: <1573112794-4284-1-git-send-email-ivan.hu@canonical.com> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" UEFI spec 2.8 introduced the variable RuntimeServicesSupported, which is Bitmask of which calls are implemented by the firmware during runtime services. Add tests for checking time services with RuntimeServicesSupported variable. Signed-off-by: Ivan Hu Acked-by: Colin Ian King Acked-by: Alex Hung --- src/uefi/uefirttime/uefirttime.c | 235 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 234 insertions(+), 1 deletion(-) diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c index 55ead63..d1446f2 100644 --- a/src/uefi/uefirttime/uefirttime.c +++ b/src/uefi/uefirttime/uefirttime.c @@ -1152,6 +1152,239 @@ static int uefirttime_test37(fwts_framework *fw) } #endif +static int uefirttime_test38(fwts_framework *fw) +{ + long ioret; + bool getvar_supported; + uint32_t var_runtimeservicessupported; + + struct efi_settime settime; + uint64_t status = ~0ULL; + struct efi_gettime gettime; + struct efi_getwakeuptime getwakeuptime; + uint8_t enabled, pending; + struct efi_setwakeuptime setwakeuptime; + + EFI_TIME efi_time; + EFI_TIME_CAPABILITIES efi_time_cap; + + fwts_uefi_rt_support_status_get(fd, &getvar_supported, + &var_runtimeservicessupported); + + if (!getvar_supported || (var_runtimeservicessupported == 0xFFFF)) { + fwts_skipped(fw, "Cannot get the RuntimeServicesSupported " + "variable, maybe the runtime service " + "GetVariable is not supported or " + "RuntimeServicesSupported not provided by " + "firmware."); + return FWTS_SKIP; + } + + gettime.Capabilities = &efi_time_cap; + gettime.Time = &efi_time; + gettime.status = &status; + ioret = ioctl(fd, EFI_RUNTIME_GET_TIME, &gettime); + if (ioret == -1) { + if (status == EFI_UNSUPPORTED) { + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_GET_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeGetTime", + "Get the GetTime runtime service supported " + "via RuntimeServicesSupported variable. " + "But actually is not supported by firmware."); + } else { + fwts_passed(fw, "UEFI GetTime runtime service " + "supported status test passed."); + } + } else { + if (status == ~0ULL) { + fwts_skipped(fw, "Unknown error occurred, skip test."); + return FWTS_SKIP; + } + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_GET_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_passed(fw, "UEFI GetTime runtime service " + "supported status test passed."); + } else { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeGetTime", + "Get the GetTime runtime service unsupported " + "via RuntimeServicesSupported variable. " + "But actually is supported by firmware."); + } + } + } else { + if (status != EFI_SUCCESS ) { + fwts_skipped(fw, "Unknown error occurred, skip test."); + return FWTS_SKIP; + } + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_GET_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_passed(fw, "UEFI GetTime runtime service " + "supported status test passed."); + } else { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeGetTime", + "Get the GetTime runtime service unsupported " + "via RuntimeServicesSupported variable. " + "But actually is supported by firmware."); + } + } + + settime.Time = &efi_time; + status = ~0ULL; + settime.status = &status; + + ioret = ioctl(fd, EFI_RUNTIME_SET_TIME, &settime); + if (ioret == -1) { + if (status == EFI_UNSUPPORTED) { + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_SET_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeSetTime", + "Get the SetTime runtime service supported " + "via RuntimeServicesSupported variable. " + "But actually is not supported by firmware."); + } else { + fwts_passed(fw, "UEFI SetTime runtime service " + "supported status test passed."); + } + } else { + if (status == ~0ULL) { + fwts_skipped(fw, "Unknown error occurred, skip test."); + return FWTS_SKIP; + } + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_SET_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_passed(fw, "UEFI SetTime runtime service " + "supported status test passed."); + } else { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeSetTime", + "Get the SetTime runtime service unsupported " + "via RuntimeServicesSupported variable. " + "But actually is supported by firmware."); + } + } + } else { + if (status != EFI_SUCCESS ) { + fwts_skipped(fw, "Unknown error occurred, skip test."); + return FWTS_SKIP; + } + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_SET_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_passed(fw, "UEFI SetTime runtime service " + "supported status test passed."); + } else { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeSetTime", + "Get the SetTime runtime service unsupported " + "via RuntimeServicesSupported variable. " + "But actually is supported by firmware."); + } + } + + setwakeuptime.Time = &efi_time; + status = ~0ULL; + setwakeuptime.status = &status; + setwakeuptime.Enabled = false; + + ioret = ioctl(fd, EFI_RUNTIME_SET_WAKETIME, &setwakeuptime); + if (ioret == -1) { + if (status == EFI_UNSUPPORTED) { + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_SET_WAKEUP_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeSetWakeupTime", + "Get the SetWakeupTime runtime service supported " + "via RuntimeServicesSupported variable. " + "But actually is not supported by firmware"); + + } else { + fwts_passed(fw, "UEFI SetWakeupTime runtime service " + "supported status test passed."); + } + } else { + if (status == ~0ULL) { + fwts_skipped(fw, "Unknown error occurred, skip test."); + return FWTS_SKIP; + } + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_SET_WAKEUP_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_passed(fw, "UEFI SetWakeupTime runtime service " + "supported status test passed."); + } else { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeSetWakeupTime", + "Get the SetWakeupTime runtime service unsupported " + "via RuntimeServicesSupported variable. " + "But actually is supported by firmware."); + } + } + } else { + if (status != EFI_SUCCESS ) { + fwts_skipped(fw, "Unknown error occurred, skip test."); + return FWTS_SKIP; + } + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_SET_WAKEUP_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_passed(fw, "UEFI SetWakeupTime runtime service " + "supported status test passed."); + } else { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeSetWakeupTime", + "Get the SetWakeupTime runtime service unsupported " + "via RuntimeServicesSupported variable. " + "But actually is supported by firmware."); + } + } + + getwakeuptime.Enabled = &enabled; + getwakeuptime.Pending = &pending; + getwakeuptime.Time = &efi_time; + getwakeuptime.status = &status; + + ioret = ioctl(fd, EFI_RUNTIME_GET_WAKETIME, &getwakeuptime); + if (ioret == -1) { + if (status == EFI_UNSUPPORTED) { + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_GET_WAKEUP_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeGetWakeupTime", + "Get the GetWakeupTime runtime service supported " + "via RuntimeServicesSupported variable. " + "But actually is not supported by firmware"); + } else { + fwts_passed(fw, "UEFI GetWakeupTime runtime service " + "supported status test passed."); + } + } else { + if (status == ~0ULL) { + fwts_skipped(fw, "Unknown error occurred, skip test."); + return FWTS_SKIP; + } + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_GET_WAKEUP_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_passed(fw, "UEFI GetWakeupTime runtime service " + "supported status test passed."); + } else { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeGetWakeupTime", + "Get the GetWakeupTime runtime service unsupported " + "via RuntimeServicesSupported variable. " + "But actually is supported by firmware"); + } + } + } else { + if (status != EFI_SUCCESS ){ + fwts_skipped(fw, "Unknow error occurred, skip test."); + return FWTS_SKIP; + } + if ((var_runtimeservicessupported & EFI_RT_SUPPORTED_GET_WAKEUP_TIME) + || (var_runtimeservicessupported == 0)) { + fwts_passed(fw, "UEFI GetWakeupTime runtime service " + "supported status test passed."); + } else { + fwts_failed(fw, LOG_LEVEL_HIGH, "UEFIRuntimeGetWakeupTime", + "Get the GetWakeupTime runtime service unsupported " + "via RuntimeServicesSupported variable. " + "But actually is supported by firmware"); + } + } + + return FWTS_OK; +} + static fwts_framework_minor_test uefirttime_tests[] = { { uefirttime_test1, "Test UEFI RT service get time interface." }, { uefirttime_test2, "Test UEFI RT service get time interface, NULL time parameter." }, @@ -1197,7 +1430,7 @@ static fwts_framework_minor_test uefirttime_tests[] = { #if UEFI_IGNORE_UNSET_BITS { uefirttime_test37, "Test UEFI RT service set wakeup time interface, invalid daylight 0xfc." }, #endif - + { uefirttime_test38, "Test UEFI RT time services supported status." }, { NULL, NULL } };