diff mbox

[3/3] uefidump: add dumping for the eMMC device path

Message ID 1475137643-28064-3-git-send-email-ivan.hu@canonical.com
State Accepted
Headers show

Commit Message

Ivan Hu Sept. 29, 2016, 8:27 a.m. UTC
Add dumping with uefi spec. 2.6 for new messaging device path, eMMC device path

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 src/uefi/uefidump/uefidump.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Colin Ian King Sept. 29, 2016, 8:57 a.m. UTC | #1
On 29/09/16 09:27, Ivan Hu wrote:
> Add dumping with uefi spec. 2.6 for new messaging device path, eMMC device path
> 
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  src/uefi/uefidump/uefidump.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index 03529b5..5336ba4 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -530,6 +530,12 @@ static char *uefidump_build_dev_path(char *path, fwts_uefi_dev_path *dev_path, c
>  				path = uefidump_vprintf(path, "\\WiFi(%s)", w->ssid);
>  			}
>  			break;
> +		case FWTS_UEFI_EMMC_DEVICE_PATH_SUBTYPE:
> +			if (dev_path_len >= sizeof(fwts_uefi_emmc_dev_path)) {
> +				fwts_uefi_emmc_dev_path *e = (fwts_uefi_emmc_dev_path *)dev_path;
> +				path = uefidump_vprintf(path, "\\eMMC(0x%" PRIx8 ")", e->slot_num);
> +			}
> +			break;
>  		default:
>  			path = uefidump_vprintf(path, "\\Unknown-MESSAGING-DEV-PATH(0x%" PRIx8 ")", dev_path->subtype);
>  			break;
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Alex Hung Sept. 29, 2016, 11:36 p.m. UTC | #2
On 2016-09-29 01:27 AM, Ivan Hu wrote:
> Add dumping with uefi spec. 2.6 for new messaging device path, eMMC device path
>
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  src/uefi/uefidump/uefidump.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index 03529b5..5336ba4 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -530,6 +530,12 @@ static char *uefidump_build_dev_path(char *path, fwts_uefi_dev_path *dev_path, c
>  				path = uefidump_vprintf(path, "\\WiFi(%s)", w->ssid);
>  			}
>  			break;
> +		case FWTS_UEFI_EMMC_DEVICE_PATH_SUBTYPE:
> +			if (dev_path_len >= sizeof(fwts_uefi_emmc_dev_path)) {
> +				fwts_uefi_emmc_dev_path *e = (fwts_uefi_emmc_dev_path *)dev_path;
> +				path = uefidump_vprintf(path, "\\eMMC(0x%" PRIx8 ")", e->slot_num);
> +			}
> +			break;
>  		default:
>  			path = uefidump_vprintf(path, "\\Unknown-MESSAGING-DEV-PATH(0x%" PRIx8 ")", dev_path->subtype);
>  			break;
>

Acked-by: Alex Hung <alex.hung@canonical.com>
diff mbox

Patch

diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
index 03529b5..5336ba4 100644
--- a/src/uefi/uefidump/uefidump.c
+++ b/src/uefi/uefidump/uefidump.c
@@ -530,6 +530,12 @@  static char *uefidump_build_dev_path(char *path, fwts_uefi_dev_path *dev_path, c
 				path = uefidump_vprintf(path, "\\WiFi(%s)", w->ssid);
 			}
 			break;
+		case FWTS_UEFI_EMMC_DEVICE_PATH_SUBTYPE:
+			if (dev_path_len >= sizeof(fwts_uefi_emmc_dev_path)) {
+				fwts_uefi_emmc_dev_path *e = (fwts_uefi_emmc_dev_path *)dev_path;
+				path = uefidump_vprintf(path, "\\eMMC(0x%" PRIx8 ")", e->slot_num);
+			}
+			break;
 		default:
 			path = uefidump_vprintf(path, "\\Unknown-MESSAGING-DEV-PATH(0x%" PRIx8 ")", dev_path->subtype);
 			break;