| Message ID | 1342485801-8542-1-git-send-email-colin.king@canonical.com |
|---|---|
| State | Rejected |
| Headers | show |
On 16/07/12 17:43, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Add in new ACPI 5.0 HW_REDUCED and LOW_POWER_S0 IA-PC Boot Flags > to FADT > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/acpidump/acpidump.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c > index e2eeb43..0985597 100644 > --- a/src/acpi/acpidump/acpidump.c > +++ b/src/acpi/acpidump/acpidump.c > @@ -644,7 +644,9 @@ static void acpidump_fadt(fwts_framework *fw, fwts_acpi_table_info *table) > FIELD_BITF(" Remote power on capable (V4)", fwts_acpi_table_fadt, flags, 1, 17), > FIELD_BITF(" Use APIC Cluster Model (V4)", fwts_acpi_table_fadt, flags, 1, 18), > FIELD_BITF(" Use APIC Physical Dest. Mode (V4)", fwts_acpi_table_fadt, flags, 1, 19), > - FIELD_BITF(" RESERVED", fwts_acpi_table_fadt, flags, 12, 20), > + FIELD_BITF(" ACPI hardware is not implemented (V5)", fwts_acpi_table_fadt, flags, 1, 20), > + FIELD_BITF(" S0 power savings are equal or better than S3 (V5)", fwts_acpi_table_fadt, flags, 1, 21), > + FIELD_BITF(" RESERVED", fwts_acpi_table_fadt, flags, 10, 22), > FIELD_GAS ("RESET_REG", fwts_acpi_table_fadt, reset_reg), > FIELD_UINT("RESET_VALUE", fwts_acpi_table_fadt, reset_value), > FIELD_UINT("X_FIRMWARE_CTRL", fwts_acpi_table_fadt, x_firmware_ctrl), > Bad commit message. Will resend.
diff --git a/src/acpi/acpidump/acpidump.c b/src/acpi/acpidump/acpidump.c index e2eeb43..0985597 100644 --- a/src/acpi/acpidump/acpidump.c +++ b/src/acpi/acpidump/acpidump.c @@ -644,7 +644,9 @@ static void acpidump_fadt(fwts_framework *fw, fwts_acpi_table_info *table) FIELD_BITF(" Remote power on capable (V4)", fwts_acpi_table_fadt, flags, 1, 17), FIELD_BITF(" Use APIC Cluster Model (V4)", fwts_acpi_table_fadt, flags, 1, 18), FIELD_BITF(" Use APIC Physical Dest. Mode (V4)", fwts_acpi_table_fadt, flags, 1, 19), - FIELD_BITF(" RESERVED", fwts_acpi_table_fadt, flags, 12, 20), + FIELD_BITF(" ACPI hardware is not implemented (V5)", fwts_acpi_table_fadt, flags, 1, 20), + FIELD_BITF(" S0 power savings are equal or better than S3 (V5)", fwts_acpi_table_fadt, flags, 1, 21), + FIELD_BITF(" RESERVED", fwts_acpi_table_fadt, flags, 10, 22), FIELD_GAS ("RESET_REG", fwts_acpi_table_fadt, reset_reg), FIELD_UINT("RESET_VALUE", fwts_acpi_table_fadt, reset_value), FIELD_UINT("X_FIRMWARE_CTRL", fwts_acpi_table_fadt, x_firmware_ctrl),