From patchwork Mon Apr 2 15:35:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 150179 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 33CBBB6EF3 for ; Tue, 3 Apr 2012 01:35:53 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SEjIO-0004Uy-J9 for incoming@patchwork.ozlabs.org; Mon, 02 Apr 2012 15:35:52 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SEjIN-0004TI-0V for fwts-devel@lists.ubuntu.com; Mon, 02 Apr 2012 15:35:51 +0000 Received: from [175.182.117.123] (helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SEjIM-0000Br-Cy; Mon, 02 Apr 2012 15:35:50 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH] pcie: added explanations to aspm messages. Date: Mon, 2 Apr 2012 23:35:44 +0800 Message-Id: <1333380944-10302-1-git-send-email-alex.hung@canonical.com> X-Mailer: git-send-email 1.7.5.4 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com Signed-off-by: Alex Hung Acked-by: Colin Ian King Acked-by: Keng-Yu Lin --- src/pci/aspm/aspm.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/pci/aspm/aspm.c b/src/pci/aspm/aspm.c index c4da009..b5e85b3 100644 --- a/src/pci/aspm/aspm.c +++ b/src/pci/aspm/aspm.c @@ -104,6 +104,11 @@ static int facp_get_aspm_control(fwts_framework *fw, int *aspm) } else { *aspm = 0; fwts_log_info(fw, "PCIE ASPM is not controlled by Linux kernel."); + fwts_advice(fw, + "BIOS reports that Linux kernel should not modify ASPM " + "settings that BIOS configured. It can be intentional " + "because hardware vendors identified some capability " + "bugs between the motherboard and the add-on cards."); } return FWTS_OK; @@ -170,6 +175,12 @@ int pcie_compare_rp_dev_aspm_registers(fwts_framework *fw, , rp->bus, rp->dev, rp->func, rp_aspm_cntrl); fwts_log_error(fw, "Device %02Xh:%02Xh.%02Xh has aspm = %02Xh.", dev->bus, dev->dev, dev->func, device_aspm_cntrl); + fwts_advice(fw, + "ASPM control registers between root port and device " + "must match in order for ASPM to be active. Unmatched " + "configuration indicates software did not configure " + "ASPM correctly and the system is not saving power " + "at its full potential."); } else { fwts_passed(fw, "PCIE aspm setting matched was matched."); }