Message ID | cd8cc95b59c31418b174bba521dd2599a7929fda.1730709384.git.stano.jakubek@gmail.com |
---|---|
State | Under Review |
Headers | show |
Series | [v3,1/2] dt-bindings: mfd: sprd,sc2731: convert to YAML | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | fail | build log |
On Mon, 04 Nov 2024, Stanislav Jakubek wrote: > Directly reference the sc2731-efuse bindings to simplify the schema. > Remove the duplicate example from the efuse bindings. > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > --- > Changes in V3: > - new patch due to a missing dependency in the MFD tree > > Link to V2: https://lore.kernel.org/lkml/ZyExK01iprBHhGm6@standask-GA-A55M-S2HP/ > Link to V1: https://lore.kernel.org/lkml/Zr3X1RoQs7ElTnlJ@standask-GA-A55M-S2HP/ > > .../devicetree/bindings/mfd/sprd,sc2731.yaml | 10 +------ > .../bindings/nvmem/sprd,sc2731-efuse.yaml | 29 ------------------- Srini, you happy for this to go in via MFD?
On Wed, Nov 06, 2024 at 09:05:09AM +0000, Lee Jones wrote: > On Mon, 04 Nov 2024, Stanislav Jakubek wrote: > > > Directly reference the sc2731-efuse bindings to simplify the schema. > > Remove the duplicate example from the efuse bindings. > > > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > > --- > > Changes in V3: > > - new patch due to a missing dependency in the MFD tree > > > > Link to V2: https://lore.kernel.org/lkml/ZyExK01iprBHhGm6@standask-GA-A55M-S2HP/ > > Link to V1: https://lore.kernel.org/lkml/Zr3X1RoQs7ElTnlJ@standask-GA-A55M-S2HP/ > > > > .../devicetree/bindings/mfd/sprd,sc2731.yaml | 10 +------ > > .../bindings/nvmem/sprd,sc2731-efuse.yaml | 29 ------------------- > > Srini, you happy for this to go in via MFD? Can you? AIUI, you don't have nvmem/sprd,sc2731-efuse.yaml in your tree. So take patch 1 now and this one will have to go next cycle. Rob
On Thu, 07 Nov 2024, Rob Herring wrote: > On Wed, Nov 06, 2024 at 09:05:09AM +0000, Lee Jones wrote: > > On Mon, 04 Nov 2024, Stanislav Jakubek wrote: > > > > > Directly reference the sc2731-efuse bindings to simplify the schema. > > > Remove the duplicate example from the efuse bindings. > > > > > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > > > --- > > > Changes in V3: > > > - new patch due to a missing dependency in the MFD tree > > > > > > Link to V2: https://lore.kernel.org/lkml/ZyExK01iprBHhGm6@standask-GA-A55M-S2HP/ > > > Link to V1: https://lore.kernel.org/lkml/Zr3X1RoQs7ElTnlJ@standask-GA-A55M-S2HP/ > > > > > > .../devicetree/bindings/mfd/sprd,sc2731.yaml | 10 +------ > > > .../bindings/nvmem/sprd,sc2731-efuse.yaml | 29 ------------------- > > > > Srini, you happy for this to go in via MFD? > > Can you? AIUI, you don't have nvmem/sprd,sc2731-efuse.yaml in your tree. > > So take patch 1 now and this one will have to go next cycle. Works for me.
diff --git a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml index 8beec7e8e4c6..bd5f2504b44b 100644 --- a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml +++ b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml @@ -67,15 +67,7 @@ patternProperties: "^efuse@[0-9a-f]+$": type: object - additionalProperties: true - properties: - compatible: - enum: - - sprd,sc2720-efuse - - sprd,sc2721-efuse - - sprd,sc2723-efuse - - sprd,sc2730-efuse - - sprd,sc2731-efuse + $ref: /schemas/nvmem/sprd,sc2731-efuse.yaml# "^fuel-gauge@[0-9a-f]+$": type: object diff --git a/Documentation/devicetree/bindings/nvmem/sprd,sc2731-efuse.yaml b/Documentation/devicetree/bindings/nvmem/sprd,sc2731-efuse.yaml index dc25fe3d1841..8672bde24a9b 100644 --- a/Documentation/devicetree/bindings/nvmem/sprd,sc2731-efuse.yaml +++ b/Documentation/devicetree/bindings/nvmem/sprd,sc2731-efuse.yaml @@ -36,33 +36,4 @@ allOf: - $ref: nvmem-deprecated-cells.yaml# unevaluatedProperties: false - -examples: - - | - pmic { - #address-cells = <1>; - #size-cells = <0>; - - efuse@380 { - compatible = "sprd,sc2731-efuse"; - reg = <0x380>; - hwlocks = <&hwlock 12>; - #address-cells = <1>; - #size-cells = <1>; - - /* Data cells */ - fgu_calib: calib@6 { - reg = <0x6 0x2>; - bits = <0 9>; - }; - - adc_big_scale: calib@24 { - reg = <0x24 0x2>; - }; - - adc_small_scale: calib@26 { - reg = <0x26 0x2>; - }; - }; - }; ...
Directly reference the sc2731-efuse bindings to simplify the schema. Remove the duplicate example from the efuse bindings. Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> --- Changes in V3: - new patch due to a missing dependency in the MFD tree Link to V2: https://lore.kernel.org/lkml/ZyExK01iprBHhGm6@standask-GA-A55M-S2HP/ Link to V1: https://lore.kernel.org/lkml/Zr3X1RoQs7ElTnlJ@standask-GA-A55M-S2HP/ .../devicetree/bindings/mfd/sprd,sc2731.yaml | 10 +------ .../bindings/nvmem/sprd,sc2731-efuse.yaml | 29 ------------------- 2 files changed, 1 insertion(+), 38 deletions(-)