Message ID | 20241112-fd-dp-fux-warning-v2-1-8cc4960094bd@linaro.org |
---|---|
State | Not Applicable |
Headers | show |
Series | [v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | total: 0 errors, 2 warnings, 9 lines checked |
robh/patch-applied | fail | build log |
On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote: > Add p1 region to the list of DP registers in the SA8775p example. This > fixes the following warning: > > Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short > > Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P") > Reported-by: Rob Herring <robh@kernel.org> > Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c Thanks for the patch. I think this link has an extra 'c' at the end. With that fixed, Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Changes in v2: > - EDITME: describe what is new in this series revision. > - EDITME: use bulletpoints and terse descriptions. > - Link to v1: https://lore.kernel.org/r/20241112-fd-dp-fux-warning-v1-1-705b527f5a63@linaro.org > --- > Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > index 58f8a01f29c7aaa9dc943c232363075686c06a7c..4536bb2f971f3b7173b8807f90c9af3e460bb01c 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > @@ -168,7 +168,8 @@ examples: > reg = <0xaf54000 0x104>, > <0xaf54200 0x0c0>, > <0xaf55000 0x770>, > - <0xaf56000 0x09c>; > + <0xaf56000 0x09c>, > + <0xaf57000 0x09c>; > > interrupt-parent = <&mdss0>; > interrupts = <12>; > > --- > base-commit: ff2ce06d5e28be5ee399a2ff894d6a551c70a318 > change-id: 20241112-fd-dp-fux-warning-c8764c93f787 > > Best regards,
On Tue, 12 Nov 2024 at 05:40, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote: > > > > On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote: > > Add p1 region to the list of DP registers in the SA8775p example. This > > fixes the following warning: > > > > Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short > > > > Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P") > > Reported-by: Rob Herring <robh@kernel.org> > > Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c > > Thanks for the patch. > > I think this link has an extra 'c' at the end. Oh.. Can you fix that when picking it up for -fixes or would you prefer to have a clean version in patchwork? > > With that fixed, > > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > Changes in v2: > > - EDITME: describe what is new in this series revision. > > - EDITME: use bulletpoints and terse descriptions. > > - Link to v1: https://lore.kernel.org/r/20241112-fd-dp-fux-warning-v1-1-705b527f5a63@linaro.org > > --- > > Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > > index 58f8a01f29c7aaa9dc943c232363075686c06a7c..4536bb2f971f3b7173b8807f90c9af3e460bb01c 100644 > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > > @@ -168,7 +168,8 @@ examples: > > reg = <0xaf54000 0x104>, > > <0xaf54200 0x0c0>, > > <0xaf55000 0x770>, > > - <0xaf56000 0x09c>; > > + <0xaf56000 0x09c>, > > + <0xaf57000 0x09c>; > > > > interrupt-parent = <&mdss0>; > > interrupts = <12>; > > > > --- > > base-commit: ff2ce06d5e28be5ee399a2ff894d6a551c70a318 > > change-id: 20241112-fd-dp-fux-warning-c8764c93f787 > > > > Best regards,
On Tue, 12 Nov 2024 05:21:24 +0200, Dmitry Baryshkov wrote: > Add p1 region to the list of DP registers in the SA8775p example. This > fixes the following warning: > > Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short > > Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P") > Reported-by: Rob Herring <robh@kernel.org> > Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Changes in v2: > - EDITME: describe what is new in this series revision. > - EDITME: use bulletpoints and terse descriptions. > - Link to v1: https://lore.kernel.org/r/20241112-fd-dp-fux-warning-v1-1-705b527f5a63@linaro.org > --- > Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
On 11/12/2024 5:15 AM, Dmitry Baryshkov wrote: > On Tue, 12 Nov 2024 at 05:40, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote: >> >> >> >> On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote: >>> Add p1 region to the list of DP registers in the SA8775p example. This >>> fixes the following warning: >>> >>> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short >>> >>> Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P") >>> Reported-by: Rob Herring <robh@kernel.org> >>> Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c >> >> Thanks for the patch. >> >> I think this link has an extra 'c' at the end. > > Oh.. Can you fix that when picking it up for -fixes or would you > prefer to have a clean version in patchwork? > Yes, I can fix it up while applying. Thanks Abhinav >> >> With that fixed, >> >> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> >> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >>> Changes in v2: >>> - EDITME: describe what is new in this series revision. >>> - EDITME: use bulletpoints and terse descriptions. >>> - Link to v1: https://lore.kernel.org/r/20241112-fd-dp-fux-warning-v1-1-705b527f5a63@linaro.org >>> --- >>> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml >>> index 58f8a01f29c7aaa9dc943c232363075686c06a7c..4536bb2f971f3b7173b8807f90c9af3e460bb01c 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml >>> @@ -168,7 +168,8 @@ examples: >>> reg = <0xaf54000 0x104>, >>> <0xaf54200 0x0c0>, >>> <0xaf55000 0x770>, >>> - <0xaf56000 0x09c>; >>> + <0xaf56000 0x09c>, >>> + <0xaf57000 0x09c>; >>> >>> interrupt-parent = <&mdss0>; >>> interrupts = <12>; >>> >>> --- >>> base-commit: ff2ce06d5e28be5ee399a2ff894d6a551c70a318 >>> change-id: 20241112-fd-dp-fux-warning-c8764c93f787 >>> >>> Best regards, > > >
On 12/11/2024 20:16, Abhinav Kumar wrote: > > > On 11/12/2024 5:15 AM, Dmitry Baryshkov wrote: >> On Tue, 12 Nov 2024 at 05:40, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote: >>> >>> >>> >>> On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote: >>>> Add p1 region to the list of DP registers in the SA8775p example. This >>>> fixes the following warning: >>>> >>>> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short >>>> >>>> Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P") >>>> Reported-by: Rob Herring <robh@kernel.org> >>>> Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c >>> >>> Thanks for the patch. >>> >>> I think this link has an extra 'c' at the end. >> >> Oh.. Can you fix that when picking it up for -fixes or would you >> prefer to have a clean version in patchwork? >> > > Yes, I can fix it up while applying. This was supposed to be send still for v6.13-rc1... I don't understand why not, but it happened so now v6.13-rc1 has a regression - binding warning (binding, not DTS!). All people testing on v6.13-rc1, all maintainer trees etc. now have this warning. Please send the fix soon, so maintainers can for example rebase their trees. Best regards, Krzysztof
On 12/2/2024 3:21 AM, Krzysztof Kozlowski wrote: > On 12/11/2024 20:16, Abhinav Kumar wrote: >> >> >> On 11/12/2024 5:15 AM, Dmitry Baryshkov wrote: >>> On Tue, 12 Nov 2024 at 05:40, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote: >>>> >>>> >>>> >>>> On 11/11/2024 7:21 PM, Dmitry Baryshkov wrote: >>>>> Add p1 region to the list of DP registers in the SA8775p example. This >>>>> fixes the following warning: >>>>> >>>>> Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short >>>>> >>>>> Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P") >>>>> Reported-by: Rob Herring <robh@kernel.org> >>>>> Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c >>>> >>>> Thanks for the patch. >>>> >>>> I think this link has an extra 'c' at the end. >>> >>> Oh.. Can you fix that when picking it up for -fixes or would you >>> prefer to have a clean version in patchwork? >>> >> >> Yes, I can fix it up while applying. > > This was supposed to be send still for v6.13-rc1... I don't understand > why not, but it happened so now v6.13-rc1 has a regression - binding > warning (binding, not DTS!). All people testing on v6.13-rc1, all > maintainer trees etc. now have this warning. > > Please send the fix soon, so maintainers can for example rebase their trees. > > Best regards, > Krzysztof I have queued this up in a MR and will make sure its included in a PR for msm-fixes in a day or two. Sorry for the delay. Will be picked up soon. Thanks Abhinav
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml index 58f8a01f29c7aaa9dc943c232363075686c06a7c..4536bb2f971f3b7173b8807f90c9af3e460bb01c 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml @@ -168,7 +168,8 @@ examples: reg = <0xaf54000 0x104>, <0xaf54200 0x0c0>, <0xaf55000 0x770>, - <0xaf56000 0x09c>; + <0xaf56000 0x09c>, + <0xaf57000 0x09c>; interrupt-parent = <&mdss0>; interrupts = <12>;
Add p1 region to the list of DP registers in the SA8775p example. This fixes the following warning: Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: displayport-controller@af54000: reg: [[183844864, 260], [183845376, 192], [183848960, 1904], [183853056, 156]] is too short Fixes: 409685915f00 ("dt-bindings: display/msm: Document MDSS on SA8775P") Reported-by: Rob Herring <robh@kernel.org> Closes: https://lore.kernel.org/dri-devel/CAL_JsqJ0zoyaZAgZtyJ8xMsPY+YzrbF-YG1vPN6tFoFXQaW09w@mail.gmail.com/c Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Changes in v2: - EDITME: describe what is new in this series revision. - EDITME: use bulletpoints and terse descriptions. - Link to v1: https://lore.kernel.org/r/20241112-fd-dp-fux-warning-v1-1-705b527f5a63@linaro.org --- Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- base-commit: ff2ce06d5e28be5ee399a2ff894d6a551c70a318 change-id: 20241112-fd-dp-fux-warning-c8764c93f787 Best regards,