diff mbox series

[net-next,1/2] dt-bindings: net: dsa: microchip: Add SGMII port support to KSZ9477 switch

Message ID 20241109015633.82638-2-Tristram.Ha@microchip.com
State Changes Requested
Headers show
Series net: dsa: microchip: Add SGMII port support to KSZ9477 switch | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Tristram.Ha@microchip.com Nov. 9, 2024, 1:56 a.m. UTC 
From: Tristram Ha <tristram.ha@microchip.com>

Update the KSZ9477 switch example to use SFP cage for SGMII support.

Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
---
 .../devicetree/bindings/net/dsa/microchip,ksz.yaml         | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Krzysztof Kozlowski Nov. 9, 2024, 10:43 a.m. UTC | #1 
On Fri, Nov 08, 2024 at 05:56:32PM -0800, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <tristram.ha@microchip.com>
> 
> Update the KSZ9477 switch example to use SFP cage for SGMII support.

Why? That's just an example. Why do we want it? Why no changes to
bindings? Your commit msg must answer to all these.

Best regards,
Krzysztof
Tristram.Ha@microchip.com Nov. 12, 2024, 2:45 a.m. UTC | #2 
> Subject: Re: [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: Add SGMII port
> support to KSZ9477 switch
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content
> is safe
> 
> On Fri, Nov 08, 2024 at 05:56:32PM -0800, Tristram.Ha@microchip.com wrote:
> > From: Tristram Ha <tristram.ha@microchip.com>
> >
> > Update the KSZ9477 switch example to use SFP cage for SGMII support.
> 
> Why? That's just an example. Why do we want it? Why no changes to
> bindings? Your commit msg must answer to all these.

As the added SGMII support needs the correct device tree declaration to
activate the SFP code, users may need that to use the port.  However the
driver can operate the port without that code, if the current patch is
accepted.  But if you say it is not necessary then it is better to not
change the file.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
index 30c0c3e6f37a..e989723f5ad6 100644
--- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
@@ -180,6 +180,13 @@  examples:
                         full-duplex;
                     };
                 };
+                port@6 {
+                    reg = <6>;
+                    label = "lan6";
+                    phy-mode = "sgmii";
+                    sfp = <&sfp>;
+                    managed = "in-band-status";
+                };
             };
         };